dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Remove duplicate include of hubp.h
@ 2021-04-29  3:04 Wan Jiabing
  2021-04-29 12:05 ` Rodrigo Siqueira
  0 siblings, 1 reply; 6+ messages in thread
From: Wan Jiabing @ 2021-04-29  3:04 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Airlie, Daniel Vetter, Nicholas Kazlauskas, Aric Cyr,
	Aurabindo Pillai, Rodrigo Siqueira, Wesley Chalmers,
	Bhawanpreet Lakha, Wayne Lin, Meenakshikumar Somasundaram,
	Chiawen Huang, Anson Jacob, Alvin Lee, Eric Yang, amd-gfx,
	dri-devel, linux-kernel
  Cc: kael_w, Wan Jiabing

In commit 482812d56698e ("drm/amd/display: Set max TTU on
DPG enable"), "hubp.h" was added which caused the duplicate include.
To be on the safe side, remove the later duplicate include.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 8f0a13807d05..dcaa6b1e16af 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -58,7 +58,6 @@
 #include "dc_link_ddc.h"
 #include "dm_helpers.h"
 #include "mem_input.h"
-#include "hubp.h"
 
 #include "dc_link_dp.h"
 #include "dc_dmub_srv.h"
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
  2021-04-29  3:04 [PATCH] drm/amd/display: Remove duplicate include of hubp.h Wan Jiabing
@ 2021-04-29 12:05 ` Rodrigo Siqueira
  2021-04-29 12:23   ` Jiabing Wan
  0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira @ 2021-04-29 12:05 UTC (permalink / raw)
  To: Wan Jiabing
  Cc: Anson Jacob, Eric Yang, Wesley Chalmers, Leo Li,
	Bhawanpreet Lakha, dri-devel, Chiawen Huang, linux-kernel,
	amd-gfx, Nicholas Kazlauskas, Meenakshikumar Somasundaram,
	David Airlie, Aurabindo Pillai, Alvin Lee, Wayne Lin,
	Alex Deucher, kael_w, Christian König


[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]

Nice catch!

Are you using any tool to identify this problem?

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

On 04/29, Wan Jiabing wrote:
> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> DPG enable"), "hubp.h" was added which caused the duplicate include.
> To be on the safe side, remove the later duplicate include.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 8f0a13807d05..dcaa6b1e16af 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -58,7 +58,6 @@
>  #include "dc_link_ddc.h"
>  #include "dm_helpers.h"
>  #include "mem_input.h"
> -#include "hubp.h"
>  
>  #include "dc_link_dp.h"
>  #include "dc_dmub_srv.h"
> -- 
> 2.25.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
  2021-04-29 12:05 ` Rodrigo Siqueira
@ 2021-04-29 12:23   ` Jiabing Wan
  2021-04-29 14:41     ` Rodrigo Siqueira
  0 siblings, 1 reply; 6+ messages in thread
From: Jiabing Wan @ 2021-04-29 12:23 UTC (permalink / raw)
  To: Rodrigo Siqueira
  Cc: Anson Jacob, Eric Yang, Wesley Chalmers, Leo Li,
	Bhawanpreet Lakha, dri-devel, Chiawen Huang, linux-kernel,
	amd-gfx, Nicholas Kazlauskas, Meenakshikumar Somasundaram,
	David Airlie, Aurabindo Pillai, Alvin Lee, Wayne Lin,
	Alex Deucher, kael_w, Christian König

 
>Nice catch!
>
>Are you using any tool to identify this problem?

Yes, I have a robot including many detecting scripts :)

>Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
>On 04/29, Wan Jiabing wrote:
>> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> To be on the safe side, remove the later duplicate include.
>> 
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 8f0a13807d05..dcaa6b1e16af 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -58,7 +58,6 @@
>>  #include "dc_link_ddc.h"
>>  #include "dm_helpers.h"
>>  #include "mem_input.h"
>> -#include "hubp.h"
>>  
>>  #include "dc_link_dp.h"
>>  #include "dc_dmub_srv.h"
>> -- 
>> 2.25.1
>> 
>
>-- 
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
  2021-04-29 12:23   ` Jiabing Wan
@ 2021-04-29 14:41     ` Rodrigo Siqueira
  2021-04-29 15:18       ` Jiabing Wan
  0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira @ 2021-04-29 14:41 UTC (permalink / raw)
  To: Jiabing Wan
  Cc: Anson Jacob, Eric Yang, Wesley Chalmers, Leo Li,
	Bhawanpreet Lakha, dri-devel, Chiawen Huang, linux-kernel,
	amd-gfx, Nicholas Kazlauskas, Meenakshikumar Somasundaram,
	David Airlie, Aurabindo Pillai, Alvin Lee, Wayne Lin,
	Alex Deucher, kael_w, Christian König


[-- Attachment #1.1: Type: text/plain, Size: 1751 bytes --]

Is your robot public available?

btw, applied to amd-staging-drm-next.

Thanks

On 04/29, Jiabing Wan wrote:
>  
> >Nice catch!
> >
> >Are you using any tool to identify this problem?
> 
> Yes, I have a robot including many detecting scripts :)
> 
> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >
> >On 04/29, Wan Jiabing wrote:
> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
> >> To be on the safe side, remove the later duplicate include.
> >> 
> >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> >> ---
> >>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >> 
> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> index 8f0a13807d05..dcaa6b1e16af 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> @@ -58,7 +58,6 @@
> >>  #include "dc_link_ddc.h"
> >>  #include "dm_helpers.h"
> >>  #include "mem_input.h"
> >> -#include "hubp.h"
> >>  
> >>  #include "dc_link_dp.h"
> >>  #include "dc_dmub_srv.h"
> >> -- 
> >> 2.25.1
> >> 
> >
> >-- 
> >Rodrigo Siqueira
> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&amp;reserved=0
> 
> Yours,
> Wan Jiabing
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
  2021-04-29 14:41     ` Rodrigo Siqueira
@ 2021-04-29 15:18       ` Jiabing Wan
  2021-04-29 15:21         ` Christian König
  0 siblings, 1 reply; 6+ messages in thread
From: Jiabing Wan @ 2021-04-29 15:18 UTC (permalink / raw)
  To: Rodrigo Siqueira
  Cc: Anson Jacob, Eric Yang, Wesley Chalmers, Leo Li,
	Bhawanpreet Lakha, dri-devel, Chiawen Huang, linux-kernel,
	amd-gfx, Nicholas Kazlauskas, Meenakshikumar Somasundaram,
	David Airlie, Aurabindo Pillai, Alvin Lee, Wayne Lin,
	Alex Deucher, kael_w, Christian König

 
>Is your robot public available?

Sorry, I started to write the robot just one week ago.
It is not strong and complete enough so it is not public available now.
But I am still working on it. If complete, it can be public available.

In fact, this patch is catched by the script called checkinclude.pl
in linux/script. The robot just run the script and catch it ;).

There will be more scripts in the robot and I think
it will be public available soon.

>btw, applied to amd-staging-drm-next.

Thank you very much.

>
>Thanks
>On 04/29, Jiabing Wan wrote:
>>  
>> >Nice catch!
>> >
>> >Are you using any tool to identify this problem?
>> 
>> Yes, I have a robot including many detecting scripts :)
>> 
>> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>> >
>> >On 04/29, Wan Jiabing wrote:
>> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> >> To be on the safe side, remove the later duplicate include.
>> >> 
>> >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> >> ---
>> >>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>> >>  1 file changed, 1 deletion(-)
>> >> 
>> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> index 8f0a13807d05..dcaa6b1e16af 100644
>> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> >> @@ -58,7 +58,6 @@
>> >>  #include "dc_link_ddc.h"
>> >>  #include "dm_helpers.h"
>> >>  #include "mem_input.h"
>> >> -#include "hubp.h"
>> >>  
>> >>  #include "dc_link_dp.h"
>> >>  #include "dc_dmub_srv.h"
>> >> -- 
>> >> 2.25.1
>> >> 
>> >
>> >-- 
>> >Rodrigo Siqueira
>> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&amp;reserved=0
>> 
>> Yours,
>> Wan Jiabing
>> 
>
>-- 
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
  2021-04-29 15:18       ` Jiabing Wan
@ 2021-04-29 15:21         ` Christian König
  0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2021-04-29 15:21 UTC (permalink / raw)
  To: Jiabing Wan, Rodrigo Siqueira
  Cc: Anson Jacob, Eric Yang, Wesley Chalmers, Leo Li,
	Bhawanpreet Lakha, dri-devel, Chiawen Huang, linux-kernel,
	amd-gfx, Meenakshikumar Somasundaram, David Airlie,
	Aurabindo Pillai, Alvin Lee, Wayne Lin, Alex Deucher, kael_w,
	Nicholas Kazlauskas

Well if you are bored we quite often have the problem of unused fields 
in structures.

If your robot could find fields which are never read, that would be 
quite helpful I think.

There probably will be a lot of false positives for things like padding, 
but maybe that yields something.

Christian.

Am 29.04.21 um 17:18 schrieb Jiabing Wan:
>   
>> Is your robot public available?
> Sorry, I started to write the robot just one week ago.
> It is not strong and complete enough so it is not public available now.
> But I am still working on it. If complete, it can be public available.
>
> In fact, this patch is catched by the script called checkinclude.pl
> in linux/script. The robot just run the script and catch it ;).
>
> There will be more scripts in the robot and I think
> it will be public available soon.
>
>> btw, applied to amd-staging-drm-next.
> Thank you very much.
>
>> Thanks
>> On 04/29, Jiabing Wan wrote:
>>>   
>>>> Nice catch!
>>>>
>>>> Are you using any tool to identify this problem?
>>> Yes, I have a robot including many detecting scripts :)
>>>
>>>> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>>>
>>>> On 04/29, Wan Jiabing wrote:
>>>>> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>>>>> DPG enable"), "hubp.h" was added which caused the duplicate include.
>>>>> To be on the safe side, remove the later duplicate include.
>>>>>
>>>>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>>>>> ---
>>>>>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>>>>>   1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>>>> index 8f0a13807d05..dcaa6b1e16af 100644
>>>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>>>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>>>> @@ -58,7 +58,6 @@
>>>>>   #include "dc_link_ddc.h"
>>>>>   #include "dm_helpers.h"
>>>>>   #include "mem_input.h"
>>>>> -#include "hubp.h"
>>>>>   
>>>>>   #include "dc_link_dp.h"
>>>>>   #include "dc_dmub_srv.h"
>>>>> -- 
>>>>> 2.25.1
>>>>>
>>>> -- 
>>>> Rodrigo Siqueira
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C99075b6ba68a4c6d4f9108d90b220472%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553063002111816%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=U5VbADSJ8HJ%2Bq%2BPCGYmCuwks61s5GZtCI4n%2BdjT0LXc%3D&amp;reserved=0
>>> Yours,
>>> Wan Jiabing
>>>
>> -- 
>> Rodrigo Siqueira
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C99075b6ba68a4c6d4f9108d90b220472%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553063002111816%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=U5VbADSJ8HJ%2Bq%2BPCGYmCuwks61s5GZtCI4n%2BdjT0LXc%3D&amp;reserved=0
> Yours,
> Wan Jiabing
>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-29 15:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29  3:04 [PATCH] drm/amd/display: Remove duplicate include of hubp.h Wan Jiabing
2021-04-29 12:05 ` Rodrigo Siqueira
2021-04-29 12:23   ` Jiabing Wan
2021-04-29 14:41     ` Rodrigo Siqueira
2021-04-29 15:18       ` Jiabing Wan
2021-04-29 15:21         ` Christian König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).