From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 629BEC47092 for ; Tue, 1 Jun 2021 16:50:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1831861263 for ; Tue, 1 Jun 2021 16:50:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1831861263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 486D76EAB8; Tue, 1 Jun 2021 16:50:39 +0000 (UTC) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC90C6EABA for ; Tue, 1 Jun 2021 16:50:38 +0000 (UTC) Received: from mail-wm1-f70.google.com ([209.85.128.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lo7bA-0003TX-6q for dri-devel@lists.freedesktop.org; Tue, 01 Jun 2021 16:50:36 +0000 Received: by mail-wm1-f70.google.com with SMTP id n127-20020a1c27850000b02901717a27c785so1294039wmn.9 for ; Tue, 01 Jun 2021 09:50:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding :content-disposition; bh=iTrKi3oqRMBuOtiLPrLLphRsYza82qg3+M0S5I+h4is=; b=mn6ywEoKxnyQxbiOjFIyC102KVwfBK2fL+AqXnJdDm3+KW/gW6Oo8LPXZIXZ4NiLv+ r84Z7iz/dfBlA8K1rjYrGtmvIFkv0C9DKL9WQJb99LpPOwshwAOTUm4HOnl8zOjxylvl 4n1nZPEfHFx+e2Og2T/sGVs1MEFFG2qrPn73pKsMwaJ7mS3dFHtuEHFSLONLYCiVevCF 2Q3WHDSkSTQArWW/EI2MxP47B/j9hidTMgx0QaS+sd7VJO9hIEFowBk3ZdZuOJb3SOFO oZn1pfLGI48kPI6vmoQsSFllCb5bSEQf8ZLTSzxP+KUtNzH4AdgRCamSbEJLj7Hsb9hc h9Gw== X-Gm-Message-State: AOAM5330PwdSHczua7dhWsspaq3RAR93n5yogIbzHTrvGlzpqBRsDNOr /YC9dx4RvfMqETO+dnmqOXGYNTDIDUxQywrl4hlcSTPxyitbRg9azVh9n0klEpGT1q1XCOS6Sf1 +li+OK2H8wZFrjzXpWw5orvZ5KRfUvL/UvIECMVKr51EkOA== X-Received: by 2002:a05:600c:154e:: with SMTP id f14mr871812wmg.36.1622566235790; Tue, 01 Jun 2021 09:50:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygCvzkOOEdkehhNOGbTNUEUrWeb4BZSr7fwfbIpmPYmZOqAJBI2SD1NKf+9uEpdefvnRVcQA== X-Received: by 2002:a05:600c:154e:: with SMTP id f14mr871784wmg.36.1622566235628; Tue, 01 Jun 2021 09:50:35 -0700 (PDT) Received: from tricky (84.127.144.65.dyn.user.ono.com. [84.127.144.65]) by smtp.gmail.com with ESMTPSA id t4sm2270986wru.53.2021.06.01.09.50.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Jun 2021 09:50:35 -0700 (PDT) Date: Tue, 1 Jun 2021 18:50:33 +0200 From: Marco Trevisan To: Emil Velikov Message-ID: In-Reply-To: References: Subject: Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2) X-Mailer: Mailspring MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ML dri-devel , Mark Gross , Thomas Zimmermann , Sebastien Bacher , David Airlie , Mario Limonciello , intel-gfx , "=?utf-8?Q?platform-driver-x86=40vger.kernel.org?=" , Hans de Goede , Rodrigo Vivi , Pekka Paalanen , Mark Pearson , Rajat Jain , Andy Shevchenko Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Emil, On giu 1 2021, at 5:31 pm, Emil Velikov wrote: > Hi Hans, > > What happened with this series, did it fall through the cracks? It's mostly waiting me to finish to propose the changes to GNOME, unfortunately I've been busy in the past weeks with downstream work, so I couldn't finish it, but I hope I can be back at it soon. Cheers > >> --- /dev/null >> +++ b/drivers/gpu/drm/drm_privacy_screen.c > >> +#include "drm_internal.h" > > I think we don't need this include, do we? > > >> --- /dev/null >> +++ b/include/drm/drm_privacy_screen_consumer.h > >> +#include > > Ditto > >> --- /dev/null >> +++ b/include/drm/drm_privacy_screen_driver.h > >> +#include > > Ditto > > I like how you avoided leaking any DRM details within the new code, > modulo the includes above. With above tweaks, the series is: > Reviewed-by: Emil Velikov > > Theoretically one could also remove the `depends on DRM` from patch > 8/9 but I'm not sure how much that saves us. > > HTH > -Emil >