From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A34C433EF for ; Thu, 23 Sep 2021 20:23:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA51861019 for ; Thu, 23 Sep 2021 20:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA51861019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B08E06E10B; Thu, 23 Sep 2021 20:23:43 +0000 (UTC) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31DCF6E10B for ; Thu, 23 Sep 2021 20:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1632428609; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=/Fu/1P6DQwQHDqsjMG0KclVOKGNcHoYlaL004oIKx5g=; b=WuXnwQ2cZLasII/XBmXacDA2ZwWU6UzbnedDHdKN24VVCNzge25Fko4UxUZ1iOIONK T9HJqYpVz5EDYsxo5g7JmP5t03CU6jAFuiDj40QL2kx55JoXxVGlmMy2RAzlSevhBpeq dOMRC5xVKFID4m66rCVOy0LbiPFTUeIi5maGvnPz0qMeTif/sRADWt1iylLKtNSIt1XA Lq18oqfOD+DqVlmDz0OLaOcKxcjFpSHyIKAa+SCgl+CXvvEcxO37WXN4BPNChp+3NRlo +eVhzC9WS2jekF2PHCV7Ptgcj00kA3tScVKXeykJIiHVaSeRyzVlZ0vKjI00ekMAQlKJ F/3Q== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7gpw91N5y2S3iMUQeg==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.33.8 SBL|AUTH) with ESMTPSA id I01f74x8NKNSMAP (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 23 Sep 2021 22:23:28 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders From: "H. Nikolaus Schaller" In-Reply-To: Date: Thu, 23 Sep 2021 22:23:28 +0200 Cc: Laurent Pinchart , David Airlie , Daniel Vetter , linux-mips , list@opendingux.net, dri-devel , linux-kernel , Paul Boddie Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210922205555.496871-1-paul@crapouillou.net> <20210922205555.496871-7-paul@crapouillou.net> <32234186-1802-4FDF-801A-B14E48FB86D8@goldelico.com> <896D04E4-4058-474B-8BD2-7F21B1C754E4@goldelico.com> <3764505C-7CA9-40C4-8CFA-8B0F2361E6D5@goldelico.com> <7U2WZQ.D8DTPCJ0ZPKO3@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul, > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : >=20 >=20 >=20 > Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller = a =C3=A9crit : >> Hi Paul, >>> Am 23.09.2021 um 15:30 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller = a =C3=A9crit : >>>> Hi Laurent, >>>> Ah, ok. >>>> But then we still have issues. >>>> Firstly I would assume that get_edid only works properly if it is = initialized >>>> through dw_hdmi_connector_create(). >>>> Next, in the current code, passing DRM_BRIDGE_ATTACH_NO_CONNECTOR = to >>>> dw_hdmi_bridge_attach() indeed does not call = dw_hdmi_connector_create() >>>> but returns 0. >>>> This patch 6/6 makes drm/ingenic unconditionally require a = connector >>>> to be attached which is defined somewhere else (device tree e.g. = "connector-hdmi") >>>> unrelated to dw-hdmi. Current upstream code for drm/ingenic does = not init/attach >>>> such a connector on its own so it did work before. >>>> I.e. I think we can't just use parts of dw-hdmi. >>> The fact that Laurent is using dw-hdmi with = DRM_BRIDGE_ATTACH_NO_CONNECTOR on Renesas makes me think that it's = possible here as well. There's no reason why it shouldn't work with = ingenic-drm. >> That is interesting and Laurent can probably comment on differences = between >> his setup (I wasn't able to deduce what device you are referring to) = and dw-hdmi. >> For jz4780 we tried that first. I do not remember the exact reasons = but we wasted >> weeks trying to but failed to get it working. While the dw-hdmi = connector simply works >> on top of upstream and fails only if we apply your patch. >> Another issue is how you want to tell connector-hdmi to use the extra = i2c bus driver >> for ddc which is not available directly as a standard i2c controller = of the jz4780. >> hdmi-connector.yaml defines: >> ddc-i2c-bus: >> description: phandle link to the I2C controller used for DDC = EDID probing >> $ref: /schemas/types.yaml#/definitions/phandle >> So we would need some ddc-i2c-bus =3D <&i2c-controller-inside-the = dw-hdmi>. >> But that i2c-controller-inside-the dw-hdmi does not exist in device = tree >> and can not be added unless someone significantly rewrites dw-hdmi to >> register and expose it as i2c controller. >=20 > No, you don't need to do that at all. Just don't set the "ddc-i2c-bus" = property. And then ddc from dw-hdmi works? >=20 >>> The ingenic-drm driver does not need to create any connector. The = "connector-hdmi" is connected to dw-hdmi as the "next bridge" in the = list. >> Sure. It does not *create* a connector. It expects that it can safely = call >> drm_bridge_connector_init() to get a pointer to a newly created = connector. >> But if we use the dw-hdmi connector, there is no such connector and = "next bridge". >=20 > We don't want to use the dw-hdmi connector. Your "next bridge" is the = "hdmi-connector" that should be wired in DTS. >=20 >> Or can you tell me how to make the dw-hdmi connector created by >> dw_hdmi_connector_create() become the "next bridge" in the list for = your driver? >> But without significantly rewriting dw-hdmi.c (and testing). >=20 > Wire it to the LCD node in DTS... >=20 > See how we do it for the IT66121 driver: > = https://github.com/OpenDingux/linux/blob/jz-5.15/arch/mips/boot/dts/ingeni= c/rg350m.dts#L114-L134 That is how we already tried. >=20 >>>> If drm_bridge_attach() would return some errno if = DRM_BRIDGE_ATTACH_NO_CONNECTOR >>>> is set, initialization in ingenic_drm_bind() would fail likewise = with "Unable to attach bridge". >>>> So in any case dw-hdmi is broken by this drm/ingenic patch unless = someone >>>> reworks it to make it compatible. >>> Where would the errno be returned? Why would drm_bridge_attach() = return an error code? >> Currently dw_hdmi_bridge_attach() returns 0 if it is asked to support >> DRM_BRIDGE_ATTACH_NO_CONNECTOR. >> This is not treated as an error by drm_bridge_attach(). >> Here it could return an error (-ENOTSUPP?) instead, to allow for = error handling >> by its caller. >=20 > And why would you do that? If you don't want to attach a connector, = then drm_bridge_attach() doesn't need to do much. So it's normal that it = returns zero. >=20 >> But that raises an error message like "failed to attach bridge to = encoder" and >> the bridge is reset and detached. >>>> Another issue is that dw_hdmi_connector_create() does not only do = dcd/edid >>>> but appears to detects hot plug and does some special = initialization. >>>> So we probably loose hotplug detect if we just use = drm_bridge_funcs.get_edid(). >>> There's drm_bridge_funcs.detect(). >> You mean in dw-hdmi? Yes, it calls dw_hdmi_bridge_detect() which = calls dw_hdmi_detect(). >> This does some read_hpd. >> Anyways, this does not solve the problem that with your drm/ingenic = proposal the >> dw-hdmi subsystem (hdmi + ddc) can no longer be initialized properly = unless someone >> fixes either. >> So IMHO this should be treated as a significant blocking point for = your patch >> because it breaks something that is working upstream and there seems = to be no >> rationale to change it. >> Your commit message just says: >> "All the bridges are now attached with = DRM_BRIDGE_ATTACH_NO_CONNECTOR." >> but gives no reason why. >> I fully understand that you want to change it and Laurent said that = it will become >> standard in the far future. Therefore I suggest to find a way that = you can find out >> if a connector has already been created by drm_bridge_attach() to = stay compatible >> with current upstream code. >=20 > No, absolutely not. There is nothing upstream yet that can bind the = ingenic-drm driver with the dw-hdmi driver. We have proposed it a while ago using nothing special. > This is your downstream patch. I'm not breaking anything that's = upstream, so there is no blocking point. >=20 > Besides, even with your downstream patch I don't see any reason why = the dw-hdmi driver wouldn't work with this patch, provided it's wired = properly, and you never did show a proof of failure either. You come up = with "possible points where it will fail" but these are based on your = assumptions on how the drivers should be working together, and I think = you somehow miss the whole picture. Yes, maybe. >=20 > Start by wiring things properly, like in my previously linked DTS, and = *test*. If it fails, tell us where it fails. Well, I tell where drm_bridge_attach fails with = DRM_BRIDGE_ATTACH_NO_CONNECTOR... > Because your "it doesn't work" arguments have zero weight otherwise. I hope I still can find it. So I can't promise anything. We have had it complete in DTS and added code to parse it. It may have been wiped out by cleaning up patch series during rebase. >=20 > If I can find some time this weekend I will test it myself. You may be faster than me. BR and thanks, Nikolaus