From: Rohit Visavalia <RVISAVAL@xilinx.com>
To: Rohit Visavalia <RVISAVAL@xilinx.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"imirkin@alum.mit.edu" <imirkin@alum.mit.edu>,
"emil.velikov@collabora.com" <emil.velikov@collabora.com>
Cc: Ranganathan Sk <rsk@xilinx.com>,
Varunkumar Allagadapa <VARUNKUM@xilinx.com>,
Devarsh Thakkar <DEVARSHT@xilinx.com>,
Dhaval Rajeshbhai Shah <dshah@xilinx.com>
Subject: RE: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true
Date: Thu, 27 Feb 2020 08:40:20 +0000 [thread overview]
Message-ID: <BYAPR02MB40561FBCE7FCCF6ECAA96BF5B3EB0@BYAPR02MB4056.namprd02.prod.outlook.com> (raw)
In-Reply-To: <1582623496-6094-1-git-send-email-rohit.visavalia@xilinx.com>
Gentle reminder.
+ Ilia Mirkin, +Emil Velikov.
Thanks & Regards,
Rohit
> -----Original Message-----
> From: Rohit Visavalia [mailto:rohit.visavalia@xilinx.com]
> Sent: Tuesday, February 25, 2020 3:08 PM
> To: dri-devel@lists.freedesktop.org
> Cc: Hyun Kwon <hyunk@xilinx.com>; Ranganathan Sk <rsk@xilinx.com>;
> Dhaval Rajeshbhai Shah <dshah@xilinx.com>; Varunkumar Allagadapa
> <VARUNKUM@xilinx.com>; Devarsh Thakkar <DEVARSHT@xilinx.com>; Rohit
> Visavalia <RVISAVAL@xilinx.com>
> Subject: [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if
> add_property_optional returns true
>
> gamma is a optional property then also it prints error message, so set gamma
> only if add_property_optional() returns true.
>
> Signed-off-by: Rohit Visavalia <rohit.visavalia@xilinx.com>
> ---
> tests/modetest/modetest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index
> b907ab3..379b9ea 100644
> --- a/tests/modetest/modetest.c
> +++ b/tests/modetest/modetest.c
> @@ -1138,7 +1138,7 @@ static void set_gamma(struct device *dev, unsigned
> crtc_id, unsigned fourcc)
>
> add_property_optional(dev, crtc_id, "DEGAMMA_LUT", 0);
> add_property_optional(dev, crtc_id, "CTM", 0);
> - if (!add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) {
> + if (add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) {
> uint16_t r[256], g[256], b[256];
>
> for (i = 0; i < 256; i++) {
> --
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-27 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 9:38 [PATCH libdrm] modetest: call drmModeCrtcSetGamma() only if add_property_optional returns true Rohit Visavalia
2020-02-27 8:40 ` Rohit Visavalia [this message]
2020-03-03 13:11 ` Devarsh Thakkar
2020-03-03 13:38 ` Ilia Mirkin
2020-03-12 6:39 ` Rohit Visavalia
2020-03-12 10:18 ` Ilia Mirkin
2020-03-13 10:08 ` Rohit Visavalia
2020-03-13 14:46 ` Ilia Mirkin
2020-03-23 4:25 ` Rohit Visavalia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB40561FBCE7FCCF6ECAA96BF5B3EB0@BYAPR02MB4056.namprd02.prod.outlook.com \
--to=rvisaval@xilinx.com \
--cc=DEVARSHT@xilinx.com \
--cc=VARUNKUM@xilinx.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dshah@xilinx.com \
--cc=emil.velikov@collabora.com \
--cc=imirkin@alum.mit.edu \
--cc=rsk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).