From: Dexuan Cui <decui@microsoft.com>
To: Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
Saurabh Sengar <ssengar@linux.microsoft.com>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
"deller@gmx.de" <deller@gmx.de>,
Saurabh Singh Sengar <ssengar@microsoft.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1
Date: Wed, 4 May 2022 17:05:05 +0000 [thread overview]
Message-ID: <BYAPR21MB12702855D53B456E898ED5E0BFC39@BYAPR21MB1270.namprd21.prod.outlook.com> (raw)
In-Reply-To: <DM5PR21MB1749EE7458996FF22AAA9AF8CAC39@DM5PR21MB1749.namprd21.prod.outlook.com>
> From: Haiyang Zhang <haiyangz@microsoft.com>
> > > ...
> > > - if (gen2vm) {
> > > - pot_start = 0;
> > > - pot_end = -1;
> > > - } else {
> > > - if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> > > - pci_resource_len(pdev, 0) < screen_fb_size) {
> > > - pr_err("Resource not available or (0x%lx < 0x%lx)\n",
> > > - (unsigned long) pci_resource_len(pdev, 0),
> > > - (unsigned long) screen_fb_size);
> > > - goto err1;
> >
> > This restriction has been in place since day 1. Haiyang, you wrote this
> > driver. Can you comment on whether this change here is sensible?
>
> When I initially implemented this driver 10 years ago, I believe there
> was smaller limit for the fb... But I think this patch is good for the
> newer MMIO alloc scheme. I hope to see reviews also from
> @Dexuan Cui @Michael Kelley (LINUX) who are more familiar with
> the PCI/BAR/MMIO area.
>
> Thanks,
> - Haiyang
The patch looks good to me but I suggest we check with the Hyper-V
team to figure out how a Gen1 Windows VM supports a higher
resolution that needs a VRAM size of more than 64MB. Just in case we
miss something..
Thanks,
-- Dexuan
next prev parent reply other threads:[~2022-05-04 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 13:47 [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for Gen1 Saurabh Sengar
2022-04-27 19:24 ` Helge Deller
2022-04-28 14:37 ` Wei Liu
2022-05-04 16:43 ` Haiyang Zhang
2022-05-04 17:05 ` Dexuan Cui [this message]
2022-05-18 18:48 ` Dexuan Cui
2022-05-19 9:08 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR21MB12702855D53B456E898ED5E0BFC39@BYAPR21MB1270.namprd21.prod.outlook.com \
--to=decui@microsoft.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).