From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A50FEC001E0 for ; Mon, 23 Oct 2023 08:27:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C722210E17B; Mon, 23 Oct 2023 08:27:26 +0000 (UTC) Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) by gabe.freedesktop.org (Postfix) with ESMTPS id C817E10E17B for ; Mon, 23 Oct 2023 08:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1698049641; x=1698308841; bh=E286vjDkg1qT5X7T/0laoU76NAczw6eMVxOaqO74GTQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=HHqC6H6jpKuOnCR6UjEuqgPw8HVmDomNFEobNYu+lQdncQxP4VLHQAjmGEA+bP3JN /alAi8MHa8bY53QoR2e1GKCaid6zWfgJQ+vyuOgmcxYKvZBnb0wo70x4GpchHpV5WF gLLiDhMjvtrCAOOB8njQEhf9Cognaxrh1MnAaFtfbIaV4fB1Id/cFu9LlgpKeMrXmv /vfcR4UpV07Th843zJRGjOhiUU/l3bvr9zYY4eHu0pWKfFwwwsR3OkFhP4pYHIKLIX hGvoVr+bUNkIN/P7QJUSDgMBtmziBgP1BPc5+EAJEfL0gL6kDqk49KB60pc3pObzf3 q0IQlLjyA2w/g== Date: Mon, 23 Oct 2023 08:27:17 +0000 To: =?utf-8?Q?Michel_D=C3=A4nzer?= From: Simon Ser Subject: Re: [PATCH v7 4/6] drm: Refuse to async flip with atomic prop changes Message-ID: In-Reply-To: <8c1641e4-a7e2-ecb2-ab7a-c6e2bb3e951b@mailbox.org> References: <20231017092837.32428-1-andrealmeid@igalia.com> <20231017092837.32428-5-andrealmeid@igalia.com> <3r5-_03WC5dK3LaRt1Is78zD_bmT2aaGc5h9jpUGzo2o5GCtGP1zpQNzUxglsieewFklY7xwTrOS9jtI18YlNnnzHNx2Ccw9yM2NuJpDQZU=@emersion.fr> <8c1641e4-a7e2-ecb2-ab7a-c6e2bb3e951b@mailbox.org> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pierre-eric.pelloux-prayer@amd.com, =?utf-8?Q?Andr=C3=A9_Almeida?= , =?utf-8?Q?=27Marek_Ol=C5=A1=C3=A1k=27?= , Randy Dunlap , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Pekka Paalanen , dri-devel@lists.freedesktop.org, kernel-dev@igalia.com, alexander.deucher@amd.com, hwentlan@amd.com, christian.koenig@amd.com, joshua@froggi.es Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sunday, October 22nd, 2023 at 12:12, Michel D=C3=A4nzer wrote: > On 10/17/23 14:16, Simon Ser wrote: >=20 > > After discussing with Andr=C3=A9 it seems like we missed a plane type c= heck > > here. We need to make sure FB_ID changes are only allowed on primary > > planes. >=20 > Can you elaborate why that's needed? Current drivers are in general not prepared to perform async page-flips on planes other than primary. For instance I don't think i915 has logic to perform async page-flip on an overlay plane FB_ID change.