From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CCDC4361B for ; Mon, 7 Dec 2020 09:59:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD2742310B for ; Mon, 7 Dec 2020 09:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD2742310B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=emersion.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 414D189E65; Mon, 7 Dec 2020 09:59:13 +0000 (UTC) Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2100A89E65 for ; Mon, 7 Dec 2020 09:59:12 +0000 (UTC) Date: Mon, 07 Dec 2020 09:59:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1607335150; bh=EXd7Qmwbo9g9EM1n7UVmsL222pW21FRsz/VlS1Qa0lQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=dDxmRwP4PPhSUUxgORM/7MWrvoZxOskjZ4eeiOTDjgy8PispNEq+zL2KfucYtLmt4 baF4kUWLw2TIklyYrzOp0y+FaC/97hhaUevcqzQw2qt1H8UhRzUAI4Kn9//HsUQJXL 36TTtVrqWFJAyUIy/CsMmJTRTN166+TGAZCvrLMXF4JLQXkBIP8XpUszFlIQ5JEs+6 vV6GJs+cA6i1XeI9DmkPymWG8yZksvXM1ctrVF66ni7AKsCDImEKJVSmVBC7o0zcWa xsawy0dbAXwq88IQf5hs8/dX3SvCBIcxDHFsFu9v0oePlF/UvdQBtlThSZ/GNeHolu FQxcsC/108GEw== To: James Park From: Simon Ser Subject: Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE Message-ID: In-Reply-To: References: <1607215171-36-1-git-send-email-jpark37@lagfreegames.com> <1607215171-36-2-git-send-email-jpark37@lagfreegames.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: dri-devel , James Park Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday, December 7th, 2020 at 10:55 AM, James Park wrote: > I'd noticed the #if could be combined, but they weren't in drm,h when > they could have been, so I didn't want to depart from the existing > pattern. I see. The original code really needed the two branches and drm_basic_types.h doesn't. But let's see what others think. > I think "One of the BSDs" is more informative than "Not Linux" if > that statement is still true. Given the aversion to making drm.h > robust to Windows, I don't think we want to imply compatibility that > isn't there. Well, drm_basic_types.h would be included on Windows as well from drm_fourcc.h, right? _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel