From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D0AC11D20 for ; Thu, 20 Feb 2020 21:38:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 778BB208CD for ; Thu, 20 Feb 2020 21:38:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rQTVaInb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 778BB208CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E448B6EE76; Thu, 20 Feb 2020 21:38:08 +0000 (UTC) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93B036EE76 for ; Thu, 20 Feb 2020 21:38:07 +0000 (UTC) Received: by mail-qt1-x841.google.com with SMTP id r5so4010317qtt.9 for ; Thu, 20 Feb 2020 13:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ya7BzNWkK/aNL6Tv2iIJrxyXJnuSHN2DAiGDBEKCFME=; b=rQTVaInbOR0nNBRyjg7OUiy8zpk8uVI/C0yvF8JrYqzIEQXaLVgUUhJRN1dp8pKmNm Gwz9SKu9e2EeGhGibjXdXOkIWcD65V5R0kSHQo/FV8h/yDspwYoe45a0PxLatb83l2R2 E+gKsNlBxI/ALyh7kYSXTVAZqLVIqD1E9iGgDyO2G+22xyqxeW2MvHdqZdc0W14QJYTg 2f96GaDm7RjwtN9iVrbBKVYzKK61yLmEFQTwQqwxAVhOpMiVh+lWjrYiqOjcNWiCuzsd sjrS1O0nXJqPVxmVmzKMUoIMysA64KkWboAHu9Tn9hwDODRe1zlRhxtx+7BVuZW96B3M t8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ya7BzNWkK/aNL6Tv2iIJrxyXJnuSHN2DAiGDBEKCFME=; b=b0Fnsw1xgOr3oa42S5LK0XLrUJDDLfB2KfNzwmtahPP+X/dHSCXNMZwb95gSl1V96e IKZjMfeMSEX45IIMMQRXn3URC++wPjEZz0HLyCyMHG2fI9DbW+qsWfKaQh/2aph7d4sp 7bUsIWAaP0UaRcnpvgA5nNiyEuFMhgjkD02ltTUyXhB52gOxeoRu/56XLQI8SH13/OIA ktdexqcBXpPWmqqD8Mphkw2DyRurWJAJCcvN1GNHigPr1lncPX24KPb6iTldwTV93acS D7cUYi68WzfwpC+dm3Wu9UABNWB+SEs/dzFtLbOXq5xRmBS0jLJvWYJim1pLXWDUs9EX jOnQ== X-Gm-Message-State: APjAAAVXUS4dAKgLS/6STIptqmp9bqCJeK7giUSWhHqMVsNTmvcLdJ9l GLZO2mn4QaMxJaSrTrkq6msP+gASzQVRPbyArBE= X-Google-Smtp-Source: APXvYqx9EZC0JNyWfusuB4QXxIWZmS+pIpitlsLm35JVfJohfpkIicI2phemogyTKUpyQwwnIXHCmtWvSi7373Q46BM= X-Received: by 2002:aed:2510:: with SMTP id v16mr28785378qtc.306.1582234686749; Thu, 20 Feb 2020 13:38:06 -0800 (PST) MIME-Version: 1.0 References: <20200220083508.792071-1-anarsoul@gmail.com> <20200220083508.792071-7-anarsoul@gmail.com> <20200220141725.GG4998@pendragon.ideasonboard.com> In-Reply-To: <20200220141725.GG4998@pendragon.ideasonboard.com> From: Vasily Khoruzhick Date: Thu, 20 Feb 2020 13:37:53 -0800 Message-ID: Subject: Re: [PATCH 6/6] arm64: allwinner: a64: enable LCD-related hardware for Pinebook To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , David Airlie , dri-devel , Andrzej Hajda , Thierry Reding , Sam Ravnborg , Stephen Rothwell , Samuel Holland , Heiko Stuebner , Chen-Yu Tsai , Icenowy Zheng , Stephan Gerhold , Jonas Karlman , Torsten Duwe , Rob Herring , Maxime Ripard , arm-linux , Jernej Skrabec , linux-kernel , Mark Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 20, 2020 at 6:17 AM Laurent Pinchart wrote: > > Hi Vasily, Hi Laurent, > Thank you for the patch. > > On Thu, Feb 20, 2020 at 12:35:08AM -0800, Vasily Khoruzhick wrote: > > From: Icenowy Zheng > > > > Pinebook has an ANX6345 bridge connected to the RGB666 LCD output and > > eDP panel input. The bridge is controlled via I2C that's connected to > > R_I2C bus. > > > > Enable all this hardware in device tree. > > > > Signed-off-by: Icenowy Zheng > > Signed-off-by: Vasily Khoruzhick > > --- > > .../dts/allwinner/sun50i-a64-pinebook.dts | 69 ++++++++++++++++++- > > 1 file changed, 68 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > index c06c540e6c08..f5633f550d8a 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts > > @@ -48,6 +48,18 @@ lid_switch { > > }; > > }; > > > > + panel_edp: panel-edp { > > + compatible = "neweast,wjfh116008a"; > > + backlight = <&backlight>; > > + power-supply = <®_dc1sw>; > > + > > + port { > > + panel_edp_in: endpoint { > > + remote-endpoint = <&anx6345_out_edp>; > > + }; > > + }; > > + }; > > + > > reg_vbklt: vbklt { > > compatible = "regulator-fixed"; > > regulator-name = "vbklt"; > > @@ -109,6 +121,10 @@ &dai { > > status = "okay"; > > }; > > > > +&de { > > + status = "okay"; > > +}; > > + > > &ehci0 { > > phys = <&usbphy 0>; > > phy-names = "usb"; > > @@ -119,6 +135,10 @@ &ehci1 { > > status = "okay"; > > }; > > > > +&mixer0 { > > + status = "okay"; > > +}; > > + > > &mmc0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&mmc0_pins>; > > @@ -177,12 +197,45 @@ &pwm { > > status = "okay"; > > }; > > > > -/* The ANX6345 eDP-bridge is on r_i2c */ > > &r_i2c { > > clock-frequency = <100000>; > > pinctrl-names = "default"; > > pinctrl-0 = <&r_i2c_pl89_pins>; > > status = "okay"; > > + > > + anx6345: anx6345@38 { > > + compatible = "analogix,anx6345"; > > + reg = <0x38>; > > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ > > + dvdd25-supply = <®_dldo2>; > > + dvdd12-supply = <®_fldo1>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + anx6345_in: port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + anx6345_in_tcon0: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&tcon0_out_anx6345>; > > + }; > > As there's a single endpoint, you can drop the reg property, the @0 > suffix, and the #address-cells and #size-cells property in the port@0 > node (but not in the ports node). Will do > > + }; > > + > > + anx6345_out: port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + > > + anx6345_out_edp: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&panel_edp_in>; > > + }; > > Same here. Will do > Reviewed-by: Laurent Pinchart Thanks for reviewing the series! > > > + }; > > + }; > > + }; > > }; > > > > &r_pio { > > @@ -357,6 +410,20 @@ &sound { > > "MIC2", "Internal Microphone Right"; > > }; > > > > +&tcon0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&lcd_rgb666_pins>; > > + > > + status = "okay"; > > +}; > > + > > +&tcon0_out { > > + tcon0_out_anx6345: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&anx6345_in_tcon0>; > > + }; > > +}; > > + > > &uart0 { > > pinctrl-names = "default"; > > pinctrl-0 = <&uart0_pb_pins>; > > -- > Regards, > > Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel