From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE661C2BA2B for ; Thu, 16 Apr 2020 07:00:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22E1206A2 for ; Thu, 16 Apr 2020 07:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vy4tGFrR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22E1206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47BB06EB06; Thu, 16 Apr 2020 06:59:35 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFD996EA47 for ; Wed, 15 Apr 2020 17:38:26 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id y4so4620869ljn.7 for ; Wed, 15 Apr 2020 10:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sHqR2C2kxuUQojnOegpnVpnZsXBDzDgx0iHXx8OBUys=; b=Vy4tGFrR/UDz2J5FSZuzqmOKo1GCzxTWtZYw44vcauEzWQop68wvIG9gTD/GD6vSVx XU/sx8wBiHWMnElHjd+vgG43Pu0fwjE3OO6i10GBubZa9VgOL7U0dcLRL7z//U4t7RVc yLc9JmltDVJ99nNme9B93oOoyJNrRlTztgoU7PoT7uk9kJpOkDNL2nlKBeZazkdblE01 TYsbPQTSf+oLWvQov5xMyKCCjZmXaHOs4Oj2N8do8WbBa1c82XNc6T+bPgKB33ZBEsEE wlFNw5pM/M5kzUb6Trl6SkDgQkpS5pamRzWGqC8x2YCx0gKHq/ICFrqJXnZTr9ti2G55 KnRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sHqR2C2kxuUQojnOegpnVpnZsXBDzDgx0iHXx8OBUys=; b=HwPEikuSYa/qKlqPCLlJaZMKJPdGQrg3VGxsX/wXz8OaibhgiW3xOsyd3qXV6Lgnh+ WvF15xZd7AYIwqHVKuWzEfC58q26VLMLqvas7u+p4AZBaWUZbCqVmLfoq49XGCDJRR6I tLcnER2342RpnudPpU35NLIqrHZPR/gGQrv1rz60UHASBvv16gywT9ZqaAYhG4LDXYl4 IWTKErDkvCvtBZDWGeb1TogUrQxuOn/UrpL1WtMUiYXwrFVzWwDjaYqdLwCWlLjBiy8H kRmbYRPq5meECkgzLUH9COyOjKarfyLIleRdg5AvMiw6yHkX3kHgw5izXCPA28RlP/5g FLrg== X-Gm-Message-State: AGi0PuZKRRIYCUX5wrDAHWeluIwX6cLWlzHuzZtlK5u0mHscQziyRmCD MIb7bO3XbBRK7/G3k746EjHq+o7TP/CjEvn75o3nDw== X-Google-Smtp-Source: APiQypLDAmF2P6A5YCpLFM2PBnROKXHaBtzTgdG+1WeYnzrJQ57PGXzD+r87BQuOOpT+tLulD2nVxdXC0mh6T+pWCAQ= X-Received: by 2002:a2e:9455:: with SMTP id o21mr3998409ljh.245.1586972304780; Wed, 15 Apr 2020 10:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20200228103752.1944629-1-christian.gmeiner@gmail.com> <4a5436201ff4345194f64aac1553f9656887203a.camel@pengutronix.de> In-Reply-To: <4a5436201ff4345194f64aac1553f9656887203a.camel@pengutronix.de> From: Naresh Kamboju Date: Wed, 15 Apr 2020 23:08:13 +0530 Message-ID: Subject: Re: [PATCH v2] drm/etnaviv: rework perfmon query infrastructure To: Lucas Stach , Christian Gmeiner , Greg Kroah-Hartman , Sasha Levin X-Mailman-Approved-At: Thu, 16 Apr 2020 06:59:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , lkft-triage@lists.linaro.org, open list , linux- stable , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Russell King , Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 3 Mar 2020 at 17:19, Lucas Stach wrote: > > On Fr, 2020-02-28 at 11:37 +0100, Christian Gmeiner wrote: > > Report the correct perfmon domains and signals depending > > on the supported feature flags. > > > > Reported-by: Dan Carpenter > > Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to query perf counter") > > Cc: stable@vger.kernel.org > > Signed-off-by: Christian Gmeiner > > Thanks, applied to etnaviv/next. > > Regards, > Lucas > > > > > --- > > Changes V1 -> V2: > > - Handle domain == NULL case better to get rid of BUG_ON(..) usage. > > --- > > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 59 ++++++++++++++++++++--- > > 1 file changed, 52 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > index 8adbf2861bff..e6795bafcbb9 100644 > > --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c > > @@ -32,6 +32,7 @@ struct etnaviv_pm_domain { > > }; > > > > struct etnaviv_pm_domain_meta { > > + unsigned int feature; > > const struct etnaviv_pm_domain *domains; > > u32 nr_domains; > > }; > > @@ -410,36 +411,78 @@ static const struct etnaviv_pm_domain doms_vg[] = { > > > > static const struct etnaviv_pm_domain_meta doms_meta[] = { > > { > > + .feature = chipFeatures_PIPE_3D, make modules failed for arm architecture on stable rc 4.19 branch. drivers/gpu/drm/etnaviv/etnaviv_perfmon.c:392:14: error: 'chipFeatures_PIPE_3D' undeclared here (not in a function) .feature = chipFeatures_PIPE_3D, ^~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/etnaviv/etnaviv_perfmon.c:397:14: error: 'chipFeatures_PIPE_2D' undeclared here (not in a function); did you mean 'chipFeatures_PIPE_3D'? .feature = chipFeatures_PIPE_2D, ^~~~~~~~~~~~~~~~~~~~ chipFeatures_PIPE_3D drivers/gpu/drm/etnaviv/etnaviv_perfmon.c:402:14: error: 'chipFeatures_PIPE_VG' undeclared here (not in a function); did you mean 'chipFeatures_PIPE_2D'? .feature = chipFeatures_PIPE_VG, ^~~~~~~~~~~~~~~~~~~~ chipFeatures_PIPE_2D ref: https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.19/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/511/consoleText _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel