From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B5CC433E2 for ; Fri, 22 May 2020 06:56:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3298A2065C for ; Fri, 22 May 2020 06:56:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aP5ju1bh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3298A2065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B82AB6E990; Fri, 22 May 2020 06:56:16 +0000 (UTC) Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66FE16E125 for ; Wed, 20 May 2020 08:21:20 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id s1so2700513qkf.9 for ; Wed, 20 May 2020 01:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GeohJKPS7M9KB2Z0UOMQZ+VWn+6x4apfiV2ZaqWSAWU=; b=aP5ju1bhRU9QWpsnVmHodgx/YH9viaoIrlq53IbD2Oo8bVgsZcgqSFu0+VkLaB+mu6 XjIcAbcBDX3+4rgxSNwaI66rluDudwmhw23fcrx0iFCLDrn4INeGj5xt4W69uC22LT+z zshvuydRZkPnBqKzWH9AppzFimSHJKYcILP/R9Ar7C8BsDmhca6LyPhw/XShvC8eCyNE fRjr7auJGGf8NS0NI+0+gkFEZ224Yu3baS1r4nHx6g9W2qIWHGlVELDtT0k5CU6YKHWl gW7UwZqZVA8gDwrk4E6ZkocUMzlJKBJxzKhClLHIdY4LDe8mRLoSVBaAWSZDNUznsZJ/ FNbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GeohJKPS7M9KB2Z0UOMQZ+VWn+6x4apfiV2ZaqWSAWU=; b=Fsi1P6ti2GbqoMFzbVA/AZ1xGM+dcnbmv9eQDgknsDUjT0xLZJ89pwuJ6YKy8/n0CK iiuZGphq8wIGhuX+ZqFBavBDRfDnSeBrTjJ4ZG9kFN+Sp51kwry35TyY32QA1LhYoaub CtdNWYagF0FzAh3fYsOW2VqQsnkvv1pGf4VeN2G1OqbQNz8L0+jkX4hht7DNRlAdTtLf 867MQ7ifVP+aoQ5D9Oh1hEBHXOYtiHbBZVoDhkvCR9ftpRsqJvzFwFm+2KCPxJhMKBSS 6AD77i0loEZjj1Hue8a/tvGdEpXrpvRS3EBVER5UtLET32LE8XIi17TnSJp1Y/EZ+57u SZXA== X-Gm-Message-State: AOAM531y32CE3a5KrTy989U6ZeJNtOleE/A4sZRxLs6F6D7zkHktm0Mh 9ENVdmUHhsdkpGzh9PoHa8DocN/8f3PFeBCvYf4= X-Google-Smtp-Source: ABdhPJzYY7WX5SvpZjR2Le4eqs31NSOpqqDD+AIItDcDtsc4sttLE1mqOlXDIimV9KUzSfqtbLesZ/hM8pwJaCmVgpM= X-Received: by 2002:a37:a50d:: with SMTP id o13mr3477552qke.121.1589962879446; Wed, 20 May 2020 01:21:19 -0700 (PDT) MIME-Version: 1.0 References: <1589881301-4143-1-git-send-email-shengjiu.wang@nxp.com> <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> In-Reply-To: <0866cd8cdb0c22f0b2a6814c4dafa29202aad5f3.camel@pengutronix.de> From: Shengjiu Wang Date: Wed, 20 May 2020 16:20:58 +0800 Message-ID: Subject: Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe To: Lucas Stach X-Mailman-Approved-At: Fri, 22 May 2020 06:56:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-mm-sig@lists.linaro.org, Linux-ALSA , linuxppc-dev@lists.ozlabs.org, linux-kernel , Timur Tabi , Xiubo Li , shawnguo@kernel.org, Shengjiu Wang , Takashi Iwai , Liam Girdwood , dri-devel@lists.freedesktop.org, perex@perex.cz, Nicolin Chen , Mark Brown , linux-imx@nxp.com, kernel@pengutronix.de, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > There are two requirements that we need to move the request > > of dma channel from probe to open. > > How do you handle -EPROBE_DEFER return code from the channel request if > you don't do it in probe? I use the dma_request_slave_channel or dma_request_channel instead of dmaengine_pcm_request_chan_of. so there should be not -EPROBE_DEFER return code. > > > - When dma device binds with power-domains, the power will > > be enabled when we request dma channel. If the request of dma > > channel happen on probe, then the power-domains will be always > > enabled after kernel boot up, which is not good for power > > saving, so we need to move the request of dma channel to .open(); > > This is certainly something which could be fixed in the dmaengine > driver. Dma driver always call the pm_runtime_get_sync in device_alloc_chan_resources, the device_alloc_chan_resources is called when channel is requested. so power is enabled on channel request. > > > - With FE-BE case, if the dma channel is requested in probe, > > then there will be below issue, which is caused by that the > > dma channel will be requested duplicately > > Why is this requested a second time? Is this just some missing cleanup > on a deferred probe path? Not relate with deferred probe. With DMA1->ASRC->DMA2->ESAI case, the DMA1->ASRC->DMA2 is in FE, ESAI is in BE. When ESAI drvier probe, DMA3 channel is created with ESAI's "dma:tx" (DMA3 channel is not used in this FE-BE case). When FE-BE startup, DMA2 channel is created, it needs the ESAI's "dma:tx", so below warning comes out. > > Regards, > Lucas > > > [ 638.906268] sysfs: cannot create duplicate filename '/devices/soc0/soc/2000000.bus/2000000.spba-bus/2024000.esai/dma:tx' > > [ 638.919061] CPU: 1 PID: 673 Comm: aplay Not tainted 5.7.0-rc1-12956-gfc64b2585593 #287 > > [ 638.927113] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) > > [ 638.933690] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [ 638.941464] [] (show_stack) from [] (dump_stack+0xe4/0x118) > > [ 638.948808] [] (dump_stack) from [] (sysfs_warn_dup+0x50/0x64) > > [ 638.956406] [] (sysfs_warn_dup) from [] (sysfs_do_create_link_sd+0xc8/0xd4) > > [ 638.965134] [] (sysfs_do_create_link_sd) from [] (dma_request_chan+0xb0/0x210) > > [ 638.974120] [] (dma_request_chan) from [] (dma_request_slave_channel+0x8/0x14) > > [ 638.983111] [] (dma_request_slave_channel) from [] (fsl_asrc_dma_hw_params+0x1e0/0x438) > > [ 638.992881] [] (fsl_asrc_dma_hw_params) from [] (soc_pcm_hw_params+0x4a0/0x6a8) > > [ 639.001952] [] (soc_pcm_hw_params) from [] (dpcm_fe_dai_hw_params+0x70/0xe4) > > [ 639.010765] [] (dpcm_fe_dai_hw_params) from [] (snd_pcm_hw_params+0x158/0x418) > > [ 639.019750] [] (snd_pcm_hw_params) from [] (snd_pcm_ioctl+0x734/0x183c) > > [ 639.028129] [] (snd_pcm_ioctl) from [] (ksys_ioctl+0x2ac/0xb98) > > [ 639.035812] [] (ksys_ioctl) from [] (ret_fast_syscall+0x0/0x28) > > [ 639.043490] Exception stack(0xec529fa8 to 0xec529ff0) > > [ 639.048565] 9fa0: bee84650 01321870 00000004 c25c4111 bee84650 0002000f > > [ 639.056766] 9fc0: bee84650 01321870 01321820 00000036 00001f40 00000000 0002c2f8 00000003 > > [ 639.064964] 9fe0: b6f483fc bee8451c b6ee2655 b6e1dcf8 > > [ 639.070339] fsl-esai-dai 2024000.esai: Cannot create DMA dma:tx symlink > > > > Signed-off-by: Shengjiu Wang > > --- > > sound/soc/fsl/imx-pcm-dma.c | 173 +++++++++++++++++++++++++++++++++--- > > 1 file changed, 159 insertions(+), 14 deletions(-) > > > > diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c > > index 04a9bc749016..dae53b384df4 100644 > > --- a/sound/soc/fsl/imx-pcm-dma.c > > +++ b/sound/soc/fsl/imx-pcm-dma.c > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -29,24 +30,168 @@ static bool filter(struct dma_chan *chan, void *param) > > return true; > > } > > > > -static const struct snd_dmaengine_pcm_config imx_dmaengine_pcm_config = { > > - .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, > > - .compat_filter_fn = filter, > > -}; > > +static int imx_pcm_hw_params(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream, > > + struct snd_pcm_hw_params *params) > > +{ > > + struct snd_pcm_runtime *runtime = substream->runtime; > > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > > + struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0); > > + struct snd_dmaengine_dai_dma_data *dma_data; > > + struct dma_slave_config config; > > + struct dma_chan *chan; > > + int ret = 0; > > > > -int imx_pcm_dma_init(struct platform_device *pdev, size_t size) > > + snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); > > + runtime->dma_bytes = params_buffer_bytes(params); > > + > > + chan = snd_dmaengine_pcm_get_chan(substream); > > + if (!chan) > > + return -EINVAL; > > + > > + ret = snd_hwparams_to_dma_slave_config(substream, params, &config); > > + if (ret) > > + return ret; > > + > > + dma_data = snd_soc_dai_get_dma_data(cpu_dai, substream); > > + if (!dma_data) > > + return -EINVAL; > > + > > + snd_dmaengine_pcm_set_config_from_dai_data(substream, > > + dma_data, > > + &config); > > + return dmaengine_slave_config(chan, &config); > > +} > > + > > +static int imx_pcm_hw_free(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream) > > { > > - struct snd_dmaengine_pcm_config *config; > > + snd_pcm_set_runtime_buffer(substream, NULL); > > + return 0; > > +} > > + > > +static snd_pcm_uframes_t imx_pcm_pointer(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream) > > +{ > > + return snd_dmaengine_pcm_pointer(substream); > > +} > > + > > +static int imx_pcm_trigger(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream, int cmd) > > +{ > > + return snd_dmaengine_pcm_trigger(substream, cmd); > > +} > > + > > +static int imx_pcm_open(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream) > > +{ > > + struct snd_soc_pcm_runtime *rtd = substream->private_data; > > + bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; > > + struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0); > > + struct snd_dmaengine_dai_dma_data *dma_data; > > + struct device *dev = component->dev; > > + struct snd_pcm_hardware hw; > > + struct dma_chan *chan; > > + int ret; > > + > > + ret = snd_pcm_hw_constraint_integer(substream->runtime, > > + SNDRV_PCM_HW_PARAM_PERIODS); > > + if (ret < 0) { > > + dev_err(dev, "failed to set pcm hw params periods\n"); > > + return ret; > > + } > > + > > + dma_data = snd_soc_dai_get_dma_data(cpu_dai, substream); > > + if (!dma_data) > > + return -EINVAL; > > + > > + chan = dma_request_slave_channel(cpu_dai->dev, tx ? "tx" : "rx"); > > + if (!chan) { > > + /* Try to request channel using compat_filter_fn */ > > + chan = snd_dmaengine_pcm_request_channel(filter, > > + dma_data->filter_data); > > + if (!chan) > > + return -ENXIO; > > + } > > > > - config = devm_kzalloc(&pdev->dev, > > - sizeof(struct snd_dmaengine_pcm_config), GFP_KERNEL); > > - if (!config) > > - return -ENOMEM; > > - *config = imx_dmaengine_pcm_config; > > + ret = snd_dmaengine_pcm_open(substream, chan); > > + if (ret) > > + goto pcm_open_fail; > > > > - return devm_snd_dmaengine_pcm_register(&pdev->dev, > > - config, > > - SND_DMAENGINE_PCM_FLAG_COMPAT); > > + memset(&hw, 0, sizeof(hw)); > > + hw.info = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID | > > + SNDRV_PCM_INFO_INTERLEAVED; > > + hw.periods_min = 2; > > + hw.periods_max = UINT_MAX; > > + hw.period_bytes_min = 256; > > + hw.period_bytes_max = dma_get_max_seg_size(chan->device->dev); > > + hw.buffer_bytes_max = IMX_DEFAULT_DMABUF_SIZE; > > + hw.fifo_size = dma_data->fifo_size; > > + > > + /* Refine the hw according to caps of DMA. */ > > + ret = snd_dmaengine_pcm_refine_runtime_hwparams(substream, > > + dma_data, > > + &hw, > > + chan); > > + if (ret < 0) > > + goto refine_runtime_hwparams_fail; > > + > > + snd_soc_set_runtime_hwparams(substream, &hw); > > + > > + /* Support allocate memory from IRAM */ > > + ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV_IRAM, > > + chan->device->dev, > > + hw.buffer_bytes_max, > > + &substream->dma_buffer); > > + if (ret < 0) > > + goto alloc_pagas_fail; > > + > > + return 0; > > + > > +alloc_pagas_fail: > > +refine_runtime_hwparams_fail: > > + snd_dmaengine_pcm_close(substream); > > +pcm_open_fail: > > + dma_release_channel(chan); > > + > > + return ret; > > +} > > + > > +static int imx_pcm_close(struct snd_soc_component *component, > > + struct snd_pcm_substream *substream) > > +{ > > + if (substream) { > > + snd_dma_free_pages(&substream->dma_buffer); > > + substream->dma_buffer.area = NULL; > > + substream->dma_buffer.addr = 0; > > + } > > + > > + return snd_dmaengine_pcm_close_release_chan(substream); > > +} > > + > > +static int imx_pcm_new(struct snd_soc_component *component, > > + struct snd_soc_pcm_runtime *rtd) > > +{ > > + struct snd_card *card = rtd->card->snd_card; > > + > > + return dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32)); > > +} > > + > > +static const struct snd_soc_component_driver imx_pcm_component = { > > + .name = "imx-pcm-dma", > > + .pcm_construct = imx_pcm_new, > > + .open = imx_pcm_open, > > + .close = imx_pcm_close, > > + .hw_params = imx_pcm_hw_params, > > + .hw_free = imx_pcm_hw_free, > > + .trigger = imx_pcm_trigger, > > + .pointer = imx_pcm_pointer, > > +}; > > + > > +int imx_pcm_dma_init(struct platform_device *pdev, size_t size) > > +{ > > + return devm_snd_soc_register_component(&pdev->dev, > > + &imx_pcm_component, NULL, 0); > > } > > EXPORT_SYMBOL_GPL(imx_pcm_dma_init); > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel