From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B42C2C54EE9 for ; Wed, 7 Sep 2022 21:13:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6497010E898; Wed, 7 Sep 2022 21:13:26 +0000 (UTC) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0366210E897 for ; Wed, 7 Sep 2022 21:13:21 +0000 (UTC) Received: by mail-yb1-xb36.google.com with SMTP id p200so4392550yba.1 for ; Wed, 07 Sep 2022 14:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=SJK16+uU9VJEIIC+Fyc2hg8dmVOoE7V69f5hgdf9kE4=; b=NtUZNHRVtILcxEdJzyYbhvTu6lkoDxvevKubhxPvpMJQ5Vbr3WMJuP7FFobpT02O0u SDNwi16ddRmxLfus5OBbt6+v5zo0WzHcsth9Ex+vvikfTuy+Fu7U0iL5lNUqpCj+Cx9z O4VbyF26LMWpSts+MvoivoU1S/Cu4FM0+0PiuCIHEYvtKItK33oIgnhxKRiaBH9cgfg9 bWNY49JYQrY1tk9cqtkc353I/B453F9ZHQxzXXJqdqU+P82wWFMqEIsLOW1bZJISOqdx lWant4c+E3rY4RaWCYU4379LT/JW+TgvBt4b++23ByoeAtAaSv95WCUYM5zUsCghKcwC zrKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=SJK16+uU9VJEIIC+Fyc2hg8dmVOoE7V69f5hgdf9kE4=; b=xIDNJnIYPL+ZUzUIQfTicyt/GzWYYc6RI0/ie638vBOhLIk2B7WRGk4LQhCL12USfb qFteWCVqxSabsZnVF99DIkZEQV+VyFNsdP69OkjnUt5uLquGHTBBxgtK3dPZgtw9m+PU AqYxRKI/XF3L6ZZ0UEUbQNEduQlpDv67myS85+CJiwD8wyTuWY05S4lwu5VT/Coj3/LQ tnheLiwipYbMP4X5HdWxBYrFgRhsTheQn5fOkmP/ByiiYlD0lnyK5JN6ylWydqqLNJTM lPqqQ7c8Qv5+P6cH+OKHijC/OmnfKZ8zo1op1USig6i0qLEKON9cTHPK6/jXEGX4Ssr7 RRnw== X-Gm-Message-State: ACgBeo1xxVndx4ANnnlEpRHIWzT99rC7paPun+4yJwGZhm3xYmiLu/Uj y3e+MaOSAooaq8NTbuAp4BIMBWPGjLLejy84ha5WsA== X-Google-Smtp-Source: AA6agR5vM/SputRDG2oAeSWV36MXAxdfUAjvvRWGWx+d7CpyXT+ZZ7ssin5/mMOx6PxOrE0DBqKbbKlAWxXlKNp/TWg= X-Received: by 2002:a5b:2ce:0:b0:67a:6054:9eb0 with SMTP id h14-20020a5b02ce000000b0067a60549eb0mr4423720ybp.15.1662585201138; Wed, 07 Sep 2022 14:13:21 -0700 (PDT) MIME-Version: 1.0 References: <20220901102312.2005553-1-dmitry.baryshkov@linaro.org> <20220901102312.2005553-5-dmitry.baryshkov@linaro.org> <20220907195904.GA98468-robh@kernel.org> In-Reply-To: <20220907195904.GA98468-robh@kernel.org> From: Dmitry Baryshkov Date: Thu, 8 Sep 2022 00:13:10 +0300 Message-ID: Subject: Re: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml To: Rob Herring Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Loic Poulain , David Airlie , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , dri-devel@lists.freedesktop.org, Stephen Boyd , Andy Gross , Krzysztof Kozlowski , freedreno@lists.freedesktop.org, Sean Paul , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, 7 Sept 2022 at 22:59, Rob Herring wrote: > > On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > > > Note, this removes description of individual DPU port@ nodes. However > > such definitions add no additional value. The reg values do not > > correspond to hardware INTF indices. The driver discovers and binds > > these ports not paying any care for the order of these items. Thus just > > leave the reference to graph.yaml#/properties/ports and the description. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > .../bindings/display/msm/dpu-common.yaml | 44 ++++++++++++++++++ > > .../bindings/display/msm/dpu-msm8998.yaml | 46 ++----------------- > > .../bindings/display/msm/dpu-qcm2290.yaml | 41 ++--------------- > > .../bindings/display/msm/dpu-sc7180.yaml | 45 ++---------------- > > .../bindings/display/msm/dpu-sc7280.yaml | 45 ++---------------- > > .../bindings/display/msm/dpu-sdm845.yaml | 46 ++----------------- > > 6 files changed, 64 insertions(+), 203 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > new file mode 100644 > > index 000000000000..bf5764e9932b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > @@ -0,0 +1,44 @@ > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Display DPU dt properties (common properties) > > + > > +maintainers: > > + - Krishna Manikandan > > + - Dmitry Baryshkov > > + - Rob Clark > > + > > +description: | > > + Common properties for QCom DPU display controller. > > + > > +properties: > > + interrupts: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + operating-points-v2: true > > + opp-table: > > + type: object > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + description: | > > + Contains the list of output ports from DPU device. These ports > > + connect to interfaces that are external to the DPU hardware, > > + such as DSI, DP etc. > > Haven't we been over this already? > > You have to define 'port' nodes or else anything is allowed in them > (and endpoint nodes). If you want to define them as pattern, then fine. > But you must have a ref to graph.yaml#/properties/port. Last time you asked to do this, I did a check. Adding any additional property results in a schema error. And this is logical. graph.yaml#/properties/ports already limits the node properties. I thus do not see a need to define port@[0-9a-f]+$. Did I miss anything? > > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - clocks > > + - interrupts > > + - power-domains > > + - operating-points-v2 > > + - ports > > + > > +additionalProperties: true > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml > > index 253665c693e6..0d6743eabd27 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml > > @@ -62,7 +62,10 @@ patternProperties: > > "^display-controller@[0-9a-f]+$": > > type: object > > description: Node containing the properties of DPU. > > - additionalProperties: false > > + unevaluatedProperties: false > > + > > + allOf: > > + - $ref: /schemas/display/msm/dpu-common.yaml# > > Don't need allOf here. (and elsewhere) Ack > > Rob -- With best wishes Dmitry