From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, quic_mkrishn@quicinc.com,
krzysztof.kozlowski+dt@linaro.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
Date: Tue, 8 Nov 2022 19:55:52 +0300 [thread overview]
Message-ID: <CAA8EJpoepOn4ScZT6V7a1T73pWdQKsxUzVKA5KsBy9SFfNVBKQ@mail.gmail.com> (raw)
In-Reply-To: <a8c36604-5f52-0be9-29d7-f64811541c97@linaro.org>
On Tue, 8 Nov 2022 at 17:42, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> On 08/11/2022 12:59, Dmitry Baryshkov wrote:
> >>
> >> Warnings about missing regulators can be resolved by updating the
> >> relevant
> >> dtsi files to point to fixed always-on regulators where appropriate.
> >
> > Ugh. Are they missing or are they optional/not used on these platforms?
>
> Some platforms either don't implement them or worse possibly do
> implement but don't model them when they should.
>
> > Can you possibly list all regulator warnings?
>
>
> Downstream we have
>
> arch/arm/boot/dts/qcom/msm8916-mdss.dtsi
>
> mdss_dsi0: qcom,mdss_dsi@1a98000 {
> vdda-supply = <&pm8916_l2>;
> vdd-supply = <&pm8916_l17>;
> vddio-supply = <&pm8916_l6>;
> };
>
> Looking at something like
>
> arch/arm/boot/dts/qcom/msm8916-mtp.dtsi which references
> arch/arm/boot/dts/qcom/dsi-panel-jdi-1080p-video.dtsi it doesn't appear
> to delete andy of the vdd*-supply references
Good example. We have vdda-supply and vddio-supply in
msm8916-pm8916.dtsi (correct).
And the mentioned vdd-supply is not applicable to this platform. It
powers up the external DSI-to-HDMI bridge. I'd assume that the same
regulator was destined to power up the panel.
So, I'd suggest defining all supplies at the top level and then
pushing all the required: parts into the per-SoC entries.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-11-08 16:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221107235654.1769462-1-bryan.odonoghue@linaro.org>
2022-11-07 23:56 ` [PATCH v2 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint Bryan O'Donoghue
2022-11-07 23:56 ` [PATCH v2 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint Bryan O'Donoghue
2022-11-08 21:10 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 03/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2022-11-08 12:59 ` Dmitry Baryshkov
2022-11-08 14:42 ` Bryan O'Donoghue
2022-11-08 16:55 ` Dmitry Baryshkov [this message]
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 04/18] dt-bindings: msm: dsi-controller-main: Fix clock declarations Bryan O'Donoghue
2022-11-08 13:00 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 05/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock Bryan O'Donoghue
2022-11-08 13:01 ` Dmitry Baryshkov
2022-11-08 21:12 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 06/18] dt-bindings: msm: dsi-controller-main: Alphanumerically sort compatible enum Bryan O'Donoghue
2022-11-08 21:13 ` Krzysztof Kozlowski
2022-11-07 23:56 ` [PATCH v2 07/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2022-11-08 12:46 ` Dmitry Baryshkov
2022-11-08 21:15 ` Krzysztof Kozlowski
2022-11-18 13:29 ` Bryan O'Donoghue
2022-11-18 13:30 ` Dmitry Baryshkov
2022-11-07 23:56 ` [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2022-11-08 12:43 ` Dmitry Baryshkov
2022-11-08 12:45 ` Bryan O'Donoghue
2022-11-08 21:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpoepOn4ScZT6V7a1T73pWdQKsxUzVKA5KsBy9SFfNVBKQ@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).