From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 334A9C32771 for ; Sat, 24 Sep 2022 18:27:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B6C510E08B; Sat, 24 Sep 2022 18:27:28 +0000 (UTC) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7936F10E07A for ; Sat, 24 Sep 2022 18:27:22 +0000 (UTC) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-3457bc84d53so31186987b3.0 for ; Sat, 24 Sep 2022 11:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=JxrzgfxApmWB8NBqb1wQvRFuNzvTICyUAKynMb46yI8=; b=g94fGvcEckzfyT/KF/vWdxoEhe0MKwlX+DUzNgYXklxi/UtSSVvcgPvXBkFLWZsu4U 6GVTx4NdvHsyim/zVyJmRB27Y95Xa772Ej+njy5Dsoy6R6xpPiK7UGR+faCJSreOOrww gV9mz39X1ywE+O2SRGDGvJiHm+8TfoU220MT1dpUFQl0gbPAhLgOciNw7XHpqBSGFNaQ QHOfi7WQdCunK7YmByjVS6rksszxAQDYu0HuqAzRniHVidflSVo0NiyqVp1Jkbbxv6NC yfRZqdkq4pBkgCgU+tBj+2tZU/l4H0/LRMlbgN4bsdCipiFcH8SLwdp88pfCAZI2TOFG kyvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=JxrzgfxApmWB8NBqb1wQvRFuNzvTICyUAKynMb46yI8=; b=GjmJVJ8rnTpi4GjYj4gNkapenqWZcPnEo2W37r3QxSQgFlNHOZ+gW5gNlUDj+wimWo hR7f67kRgM2ODocANHPWjuv7T9uMRf7042MG4m2/qnR334ER4BfmJ6rhFw9bhC+t/Ayg 6KFM7DT+zvZppNgoZXJatNfYAng5ozGiDoI9JzSQuvdo56pJDFqBtOw112JTDTfTMpQu qY6FEYptBH4nxY0q+b5R5l74W6vKBuZr5Pwaats6sZwiXV2VlFsC9VFLiHnMj6qPJKWz 4txVtowURKMIHyNkXBApm1BkQOjdR8lWmQW0XnQQ9zHTbjejIMZkUBwW6IIyZvw8uEd7 nwPw== X-Gm-Message-State: ACrzQf2WDqKvGsfEUSUvGGUqBlMnrx3hM4beYIqM6SuAhhAsHRkOKQPH nwKsvXmkHBcNMO0DVTB/OBvoVjnBc6dpMtBhvwJNTg== X-Google-Smtp-Source: AMsMyM7v+tXK8lfQAiAaF9Qy6dCtG7stCIz1g+xy7jiiQaS0jaNh05vITohMH5ZizxvRVFIMPYCyl4HOeFlB13ny9ew= X-Received: by 2002:a81:c45:0:b0:34d:21de:b794 with SMTP id 66-20020a810c45000000b0034d21deb794mr14850122ywm.138.1664044041621; Sat, 24 Sep 2022 11:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20220924123611.225520-1-dmitry.baryshkov@linaro.org> <20220924123611.225520-2-dmitry.baryshkov@linaro.org> <20220924172339.bebekrawee4ubogv@krzk-bin> In-Reply-To: <20220924172339.bebekrawee4ubogv@krzk-bin> From: Dmitry Baryshkov Date: Sat, 24 Sep 2022 21:27:10 +0300 Message-ID: Subject: Re: [PATCH v8 01/12] dt-bindings: display/msm: split qcom, mdss bindings To: Krzysztof Kozlowski , "Bryan O'Donoghue" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , Krzysztof Kozlowski , devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , dri-devel@lists.freedesktop.org, Stephen Boyd , Rob Herring , Andy Gross , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sat, 24 Sept 2022 at 20:23, Krzysztof Kozlowski wrote: > > On Sat, 24 Sep 2022 15:36:00 +0300, Dmitry Baryshkov wrote: > > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > > yaml file. Changes to the existing (txt) schema: > > - Added optional "vbif_nrt_phys" region used by msm8996 > > - Made "bus" and "vsync" clocks optional (they are not used by some > > platforms) > > - Added optional resets property referencing MDSS reset > > - Defined child nodes pointing to corresponding reference schema. > > - Dropped the "lut" clock. It was added to the schema by mistake (it is > > a part of mdp4 schema, not the mdss). > > > > Reviewed-by: Rob Herring > > Signed-off-by: Dmitry Baryshkov > > --- > > .../devicetree/bindings/display/msm/mdp5.txt | 30 +- > > .../bindings/display/msm/qcom,mdss.yaml | 264 ++++++++++++++++++ > > 2 files changed, 265 insertions(+), 29 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:0: 'byte' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:1: 'byte_intf' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:2: 'pixel' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:3: 'core' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:4: 'iface' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: clock-names:5: 'bus' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: phy-names:0: 'dsi' was expected > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: 'power-domains' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,mdss.example.dtb: dsi@1a98000: 'operating-points-v2' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml These are the errors generated by the dsi@ node from the example. The DSI schema is handled separately (by Bryan, added to the Cc list). Can we have a lifter for this patch? Or I can revert to dropping the dsi@ part from the example. > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1681881 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. -- With best wishes Dmitry