From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA0AC54EE9 for ; Sun, 11 Sep 2022 17:45:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9928E10E085; Sun, 11 Sep 2022 17:45:36 +0000 (UTC) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28AD310E079 for ; Sun, 11 Sep 2022 17:45:32 +0000 (UTC) Received: by mail-yb1-xb2a.google.com with SMTP id y82so9670683yby.6 for ; Sun, 11 Sep 2022 10:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=ZcSkLIsXblWiUck8OJ+SgUpInZcR1xIm0ofo17gXyfA=; b=htzx+rPBSWmBexOWYgvvYalDR4sq9l9+h6JnVj2Yj9XX3q8g6C2J9BVfa7OumCJc8F W5a8Og0H27W2srS50J0/WVBoKMS3LaYi8IElKfVi9d9xhUiEyCe8NWg1eNbx349O+44L IIv4K2mmWJCFHcgq0NlnNmevgpfr7MZ4fH+YOCkmzEFqKoufQwB19u0TPR4JV95n5IzZ 7VoXtxInrJIOV9ivmEZ2M5se+9p007W2D6AS6QoL6NWSmtNuJQYAmi9+JTwYdjlUrDph aWp5AIDihSEWmqa7lWNtVfG1gstpCgsoEqllNPPEGQvgc67nRtzDZAr8OkRm7C0S76yg iS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=ZcSkLIsXblWiUck8OJ+SgUpInZcR1xIm0ofo17gXyfA=; b=Y+dSGJ9O1XLIBl0rfNvpVEjxCzz6/Dh5nrGQPyVjlzyzJu8K89qJinCSVxA3KRIYbj VMWym505ZeVHzMDkzp+1LWlDMF0sQTAmVYcD4UNH+LTkjLzhXI91T2zdgo3LwZ67RL2c OMjVl3bH+TTDlXVxWZlZYY/1/QWWH262KZmLBvMwWRZqt2oKG5YOIBnL/GIperKfYMFn o1z6znFgmLuGTMvC5VjGLddx+LfTLtZjdtfCdLcFMpivnE+20nTxqogAskJCwABIqcde WLWfsc67br4pM352Vvkz14zra7d1xwZjdi5jcpVeKOl9kCEgyt18o14xJM6cUAs/34vo oFeQ== X-Gm-Message-State: ACgBeo1YCFzyWZpNqnChppG5VDY3aGn2YiBPuTbFGmXd70kGkIRtXBxO +7Jz6oltjeKgtDOYNOIPdVYTJsZMMQbNjq4nuRNXzA== X-Google-Smtp-Source: AA6agR4c6Fc3MsDIpfTcUFqNXoFK01t8NfhXio0j+7mP1q7r3AQ5VpXCKyBYguMnVkBKKhEeTlNq52ZroBcK3bKK+i8= X-Received: by 2002:a25:5c3:0:b0:6a9:90fb:c9e6 with SMTP id 186-20020a2505c3000000b006a990fbc9e6mr19452672ybf.152.1662918331162; Sun, 11 Sep 2022 10:45:31 -0700 (PDT) MIME-Version: 1.0 References: <20220901102312.2005553-1-dmitry.baryshkov@linaro.org> <20220901102312.2005553-2-dmitry.baryshkov@linaro.org> <3e525135-d205-eddc-ff2d-98c8321386e3@linaro.org> <20220908193705.GA3002673-robh@kernel.org> <1ebe64a3-fab9-1dd7-517a-01001a176d9f@linaro.org> <2204eab4-b22d-8ee7-4595-49139cb387a8@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Sun, 11 Sep 2022 20:45:20 +0300 Message-ID: Subject: Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Loic Poulain , devicetree@vger.kernel.org, David Airlie , linux-arm-msm , Bjorn Andersson , Konrad Dybcio , Abhinav Kumar , dri-devel , Stephen Boyd , Andy Gross , Krzysztof Kozlowski , freedreno , Sean Paul , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 11 Sept 2022 at 16:57, Krzysztof Kozlowski wrote: > > On 11/09/2022 15:45, Dmitry Baryshkov wrote: > > On Sun, 11 Sept 2022 at 14:27, Krzysztof Kozlowski > > wrote: > >> > >> On 10/09/2022 14:54, Dmitry Baryshkov wrote: > >>>> > >>>> However I think there is no such problem, as Dmitry said, that ref > >>>> changes anything. There will be always failure - either from parent > >>>> schema (using $ref) or from device child schema (the one which actually > >>>> misses the property). > >>> > >>> Initially I stumbled upon this issue with the dsi and dsi_phy nodes > >>> for msm8996 devices. If I have $ref here, dsi1/dsi1_phy nodes will > >>> emit warnings regarding the missing -supply properties despite nodes > >>> being disabled. If I use `compatible' here, the schema checks pass. > >>> Thus I'd prefer to leave `compatible' here. Not to mention that it > >>> also allows specifying a tighter binding than just using the $ref. > >> > >> I don't think we understood each other. I claim that error will be there > >> anyway, just from different schema. So your change fixes nothing in > >> total schema check... > > > > If the node is disabled, there will be no different schema check. > > As I wrote before, there was. The following results were captured with the following command, with most of the DSI and MDSS schema files fixed, using the following command: $ PATH=~/.local/bin/:$PATH make -C ../build-64/ ARCH=arm64 qcom/sda660-inforce-ifc6560.dtb CHECK_DTBS=y DT_SCHEMA_FILES=display/msm As you can see from the example below, when using 'compatible' I'm getting warnings just for the gpu@5000000 node, while using $ref I also got warnings for the dsi-phy@c996400 node (disabled in the DT file). For your reference the tree in question is uploaded to the: https://git.linaro.org/people/dmitry.baryshkov/kernel.git msm-mdss-yaml Logs: #1 mdss.yaml using compatible enum for dsi-phy: "^dsi-phy@[1-9a-f][0-9a-f]*$": type: object properties: compatible: enum: - qcom,dsi-phy-14nm - qcom,dsi-phy-14nm-660 - qcom,dsi-phy-20nm - qcom,dsi-phy-28nm-hpm - qcom,dsi-phy-28nm-lp make: Entering directory '/home/lumag/Projects/Qcomm/build-64' /home/lumag/Projects/Qcomm/kernel/arch/arm64/Makefile:36: Detected assembler with broken .inst; disassembly will be unreliable UPD include/config/kernel.release LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json /home/lumag/Projects/Qcomm/kernel/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml: ignoring, error in schema: patternProperties: ^(5vs[1-2]|(l|s)[1-9][0-9]?|lvs[1-3])$: properties DTC/CHECK arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb /home/lumag/Projects/Qcomm/build-64/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: gpu@5000000: clock-names:4: 'anyOf' conditional failed, one must be fixed: 'core' was expected 'iface' was expected 'mem' was expected 'mem_iface' was expected 'alt_mem_iface' was expected 'gfx3d' was expected 'rbbmtimer' was expected >From schema: /home/lumag/Projects/Qcomm/kernel/Documentation/devicetree/bindings/display/msm/gpu.yaml make: Leaving directory '/home/lumag/Projects/Qcomm/build-64' #2 mdss.yaml having dsi-phy rewritten to $ref: "^dsi-phy@[1-9a-f][0-9a-f]*$": type: object oneOf: - $ref: dsi-phy-14nm.yaml - $ref: dsi-phy-20nm.yaml - $ref: dsi-phy-28nm.yaml make: Entering directory '/home/lumag/Projects/Qcomm/build-64' /home/lumag/Projects/Qcomm/kernel/arch/arm64/Makefile:36: Detected assembler with broken .inst; disassembly will be unreliable LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json /home/lumag/Projects/Qcomm/kernel/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.yaml: ignoring, error in schema: patternProperties: ^(5vs[1-2]|(l|s)[1-9][0-9]?|lvs[1-3])$: properties DTC/CHECK arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb /home/lumag/Projects/Qcomm/build-64/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: gpu@5000000: clock-names:4: 'anyOf' conditional failed, one must be fixed: 'core' was expected 'iface' was expected 'mem' was expected 'mem_iface' was expected 'alt_mem_iface' was expected 'gfx3d' was expected 'rbbmtimer' was expected >From schema: /home/lumag/Projects/Qcomm/kernel/Documentation/devicetree/bindings/display/msm/gpu.yaml /home/lumag/Projects/Qcomm/build-64/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb: mdss@c900000: dsi-phy@c996400: 'oneOf' conditional failed, one must be fixed: 'vcca-supply' is a required property 'vddio-supply' is a required property Unevaluated properties are not allowed ('compatible', 'reg-names' were unexpected) 'qcom,dsi-phy-20nm' was expected 'qcom,dsi-phy-14nm-660' is not one of ['qcom,dsi-phy-28nm-hpm', 'qcom,dsi-phy-28nm-lp', 'qcom,dsi-phy-28nm-8960'] 'dsi_pll' was expected 'dsi_phy' was expected 'dsi_phy_regulator' was expected >From schema: /home/lumag/Projects/Qcomm/kernel/Documentation/devicetree/bindings/display/msm/mdss.yaml make: Leaving directory '/home/lumag/Projects/Qcomm/build-64' -- With best wishes Dmitry