From: Tomasz Figa <tfiga@chromium.org>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: xw@rock-chips.com, zwl@rock-chips.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
dkm@rock-chips.com, sandy.huang@rock-chips.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3
Date: Tue, 21 Jul 2015 16:38:05 +0900 [thread overview]
Message-ID: <CAAFQd5BTJujrzbz2u1jggfV8P9DwZtfJigoV2eiJ5Yesap=7Lw@mail.gmail.com> (raw)
In-Reply-To: <1435313249-4549-5-git-send-email-mark.yao@rock-chips.com>
I missed it originally, but if it's not too late yet...
On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao <mark.yao@rock-chips.com> wrote:
> Window 1 support scale and yuv format, it's waste use it for a
> cursor, use window 3 is enough.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> Changes in v2: None
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index f6ef634..40107bb 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -342,13 +342,14 @@ static const struct vop_reg_data vop_init_reg_table[] = {
> /*
> * Note: rk3288 has a dedicated 'cursor' window, however, that window requires
> * special support to get alpha blending working. For now, just use overlay
> - * window 1 for the drm cursor.
> + * window 3 for the drm cursor.
> + *
I guess this blank line is not necessary, as pointed on chromium review.
Best regards,
Tomasz
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-21 7:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 10:07 [PATCH v2 0/5] drm/rockchip: support yuv overlay and plane scale Mark Yao
2015-06-26 10:07 ` [PATCH v2 1/5] drm/rockchip: vop: optimize virtual stride calculate Mark Yao
2015-07-02 4:59 ` Tomasz Figa
2015-07-02 6:13 ` Mark yao
2015-06-26 10:07 ` [PATCH v2 2/5] drm/rockchip: vop: fix yuv plane support Mark Yao
2015-07-02 6:00 ` Tomasz Figa
2015-07-02 6:53 ` Mark yao
[not found] ` <5594DFF2.8020609-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-07-02 7:07 ` Tomasz Figa
2015-06-26 10:07 ` [PATCH v2 3/5] drm/rockchip: vop: support plane scale Mark Yao
2015-07-03 7:46 ` Tomasz Figa
2015-07-03 9:17 ` Mark yao
[not found] ` <55965344.5050502-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-07-03 9:58 ` Tomasz Figa
2015-07-03 10:14 ` Russell King - ARM Linux
2015-07-03 10:22 ` Mark yao
2015-07-03 14:37 ` Tomasz Figa
2015-06-26 10:07 ` [PATCH v2 4/5] drm/rockchip: vop: switch cursor plane to window 3 Mark Yao
2015-07-03 7:55 ` Tomasz Figa
2015-07-21 7:38 ` Tomasz Figa [this message]
2015-06-26 10:10 ` [PATCH v2 5/5] drm/rockchip: default enable win2/3 area0 bit Mark Yao
2015-07-03 8:02 ` Tomasz Figa
2015-07-03 8:19 ` Mark yao
2015-07-03 9:24 ` Tomasz Figa
2015-07-03 10:08 ` Mark yao
2015-07-21 7:33 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAFQd5BTJujrzbz2u1jggfV8P9DwZtfJigoV2eiJ5Yesap=7Lw@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=dkm@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=sandy.huang@rock-chips.com \
--cc=xw@rock-chips.com \
--cc=zwl@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).