dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: xinlei.lee@mediatek.com
Cc: chunkuang.hu@kernel.org, jitao.shi@mediatek.com,
	devicetree@vger.kernel.org, airlied@linux.ie,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	shuijing.li@mediatek.com, robh+dt@kernel.org,
	linux-mediatek@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c
Date: Mon, 12 Jun 2023 23:18:09 +0800	[thread overview]
Message-ID: <CAAOTY_-QwzY55V-dFcb2z69fRQwtoAat7ZKdScW29=3Lfe_LGA@mail.gmail.com> (raw)
In-Reply-To: <1681366162-4949-3-git-send-email-xinlei.lee@mediatek.com>

Hi, Xinlei:

Reorder this patch after patch "[3/3] drm/mediatek: dsi: Add dsi
cmdq_ctl to send panel initial code"

Regards,
Chun-Kuang.

<xinlei.lee@mediatek.com> 於 2023年4月13日 週四 下午2:09寫道:
>
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because there are different definitions for cmdq
> register bit control in mt8188.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
>  drivers/gpu/drm/mediatek/mtk_dsi.c     | 8 ++++++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index a13b36ac03a1..9ba05961479d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -654,6 +654,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
>           .data = (void *)MTK_DSI },
>         { .compatible = "mediatek,mt8186-dsi",
>           .data = (void *)MTK_DSI },
> +       { .compatible = "mediatek,mt8188-dsi",
> +         .data = (void *)MTK_DSI },
>         { }
>  };
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 7d5250351193..500a3054282d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = {
>         .has_size_ctl = true,
>  };
>
> +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> +       .reg_cmdq_off = 0xd00,
> +       .has_shadow_ctl = true,
> +       .has_size_ctl = true,
> +};
> +
>  static const struct of_device_id mtk_dsi_of_match[] = {
>         { .compatible = "mediatek,mt2701-dsi",
>           .data = &mt2701_dsi_driver_data },
> @@ -1217,6 +1223,8 @@ static const struct of_device_id mtk_dsi_of_match[] = {
>           .data = &mt8183_dsi_driver_data },
>         { .compatible = "mediatek,mt8186-dsi",
>           .data = &mt8186_dsi_driver_data },
> +       { .compatible = "mediatek,mt8188-dsi",
> +         .data = &mt8188_dsi_driver_data },
>         { },
>  };
>  MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);
> --
> 2.18.0
>

  parent reply	other threads:[~2023-06-12 15:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  6:09 [PATCH 0/3] Add mt8188 compatiable for DSI cmd packet control xinlei.lee
2023-04-13  6:09 ` [PATCH 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188 xinlei.lee
2023-04-13  7:55   ` Krzysztof Kozlowski
2023-04-13  9:02   ` Matthias Brugger
2023-06-12 15:19   ` Chun-Kuang Hu
2023-04-13  6:09 ` [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c xinlei.lee
2023-04-13  9:02   ` Matthias Brugger
2023-06-12 15:18   ` Chun-Kuang Hu [this message]
2023-04-13  6:09 ` [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code xinlei.lee
2023-04-13  7:27   ` Rex-BC Chen (陳柏辰)
2023-06-16  6:24     ` Shuijing Li (李水静)
2023-04-13  9:09   ` Matthias Brugger
2023-06-16  6:50     ` Shuijing Li (李水静)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAOTY_-QwzY55V-dFcb2z69fRQwtoAat7ZKdScW29=3Lfe_LGA@mail.gmail.com' \
    --to=chunkuang.hu@kernel.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jitao.shi@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shuijing.li@mediatek.com \
    --cc=xinlei.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).