From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE71C10F27 for ; Wed, 11 Mar 2020 13:45:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6ACAA2146E for ; Wed, 11 Mar 2020 13:45:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EjJtNO+W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6ACAA2146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9E266E426; Wed, 11 Mar 2020 13:45:11 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 029786E426 for ; Wed, 11 Mar 2020 13:45:10 +0000 (UTC) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8645020873 for ; Wed, 11 Mar 2020 13:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583934309; bh=Wn5k1ry5C0LknHTCb1r+lmW5qjLJi/Km5rBu6nKU/DM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EjJtNO+WtNcMI5F516716ActFEGYsdUf25iBi06MWgwONNjnm2vaeOdknb+FuYyeB lB7PhRIXjsUGd0caawvgtVVLjrIo3tGE3bef+PQdU94eD4tx4HXauaK9d/yq9nXX5B zIEYQ2t6kXrFg+xZ5ip0Bh2VVEKhKS2VCa5uKJd0= Received: by mail-ed1-f50.google.com with SMTP id z65so2972899ede.0 for ; Wed, 11 Mar 2020 06:45:09 -0700 (PDT) X-Gm-Message-State: ANhLgQ0iwiqUFhEKazTIdA5ZjkXRTz8AHpRaDRFskvnc+0F7fZHtuEN/ z/7DGsYSRe5O4f9gSBo2btKMbQOeYHB2AKCilQ== X-Google-Smtp-Source: ADFU+vuacDZ/28xyFG455HVvKqMjgCIYXWjiXBR/xorBP6OhEDiB0U7ExzCC3P3h5cZFGvnl8NoG3rnj/TmO9xYIObA= X-Received: by 2002:a17:906:6bc9:: with SMTP id t9mr2535634ejs.206.1583934307922; Wed, 11 Mar 2020 06:45:07 -0700 (PDT) MIME-Version: 1.0 References: <20200311071823.117899-1-jitao.shi@mediatek.com> <20200311071823.117899-3-jitao.shi@mediatek.com> In-Reply-To: <20200311071823.117899-3-jitao.shi@mediatek.com> From: Chun-Kuang Hu Date: Wed, 11 Mar 2020 21:44:55 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 2/6] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage To: Jitao Shi X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , huijuan.xie@mediatek.com, stonea168@163.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1961402493==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1961402493== Content-Type: multipart/alternative; boundary="000000000000c5815705a094712e" --000000000000c5815705a094712e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jitao Shi =E6=96=BC 2020=E5=B9=B43=E6=9C=8811=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:18=E5=AF=AB=E9=81=93=EF=BC=9A > Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. > Set > the dpi pins to gpio mode and output-low to avoid leakage current when dp= i > disabled. > Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > index 58914cf681b8..260ae75ac640 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt > @@ -17,6 +17,10 @@ Required properties: > Documentation/devicetree/bindings/graph.txt. This port should be > connected > to the input port of an attached HDMI or LVDS encoder chip. > > +Optional properties: > +- pinctrl-names: Contain "default" and "sleep". > + pinctrl-names see > Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt > + > Example: > > dpi0: dpi@1401d000 { > @@ -27,6 +31,9 @@ dpi0: dpi@1401d000 { > <&mmsys CLK_MM_DPI_ENGINE>, > <&apmixedsys CLK_APMIXED_TVDPLL>; > clock-names =3D "pixel", "engine", "pll"; > + pinctrl-names =3D "default", "sleep"; > + pinctrl-0 =3D <&dpi_pin_func>; > + pinctrl-1 =3D <&dpi_pin_idle>; > > port { > dpi0_out: endpoint { > -- > 2.21.0 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > --000000000000c5815705a094712e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Jitao Shi <jitao.shi@mediatek.com> =E6=96= =BC 2020=E5=B9=B43=E6=9C=8811=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D= =883:18=E5=AF=AB=E9=81=93=EF=BC=9A
Add property &= quot;pinctrl-names" to swap pin mode between gpio and dpi mode. Set the dpi pins to gpio mode and output-low to avoid leakage current when dpi<= br> disabled.

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
=C2=A0

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
=C2=A0.../devicetree/bindings/display/mediatek/mediatek,dpi.txt=C2=A0 | 7 += ++++++
=C2=A01 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp= i.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt=
index 58914cf681b8..260ae75ac640 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt @@ -17,6 +17,10 @@ Required properties:
=C2=A0 =C2=A0Documentation/devicetree/bindings/graph.txt. This port should = be connected
=C2=A0 =C2=A0to the input port of an attached HDMI or LVDS encoder chip.
+Optional properties:
+- pinctrl-names: Contain "default" and "sleep".
+=C2=A0 pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-= bindings.txt
+
=C2=A0Example:

=C2=A0dpi0: dpi@1401d000 {
@@ -27,6 +31,9 @@ dpi0: dpi@1401d000 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<&mmsy= s CLK_MM_DPI_ENGINE>,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<&apmi= xedsys CLK_APMIXED_TVDPLL>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 clock-names =3D "pixel", "engine= ", "pll";
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pinctrl-names =3D "default", "sl= eep";
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pinctrl-0 =3D <&dpi_pin_func>;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pinctrl-1 =3D <&dpi_pin_idle>;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 port {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dpi0_out: endpoint = {
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-de= vel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin= fo/dri-devel
--000000000000c5815705a094712e-- --===============1961402493== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1961402493==--