From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] drm/mediatek: Fix Kconfig warning
Date: Sun, 26 Apr 2020 16:20:39 +0800 [thread overview]
Message-ID: <CAAOTY__km=QZQACp8g-Qr+aWZ4r0Yp7O5j7u8ZTpDpTXXfUdNw@mail.gmail.com> (raw)
In-Reply-To: <20200420135045.27984-1-yuehaibing@huawei.com>
Hi, YueHaibing:
YueHaibing <yuehaibing@huawei.com> 於 2020年4月20日 週一 下午10:04寫道:
>
> WARNING: unmet direct dependencies detected for MTK_MMSYS
> Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> Selected by [y]:
> - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
>
> Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
From the code relationship, mediatek drm has relation with mediatek
mmsys, and mediatek mmsys has relation with medaitek clock.
So I think it's better that CONFIG_MTK_MMSYS select
CONFIG_COMMON_CLK_MT8173_MMSYS.
Regards,
Chun-Kuang.
>
> Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index c420f5a3d33b..4d9b5540de68 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -6,6 +6,7 @@ config DRM_MEDIATEK
> depends on COMMON_CLK
> depends on HAVE_ARM_SMCCC
> depends on OF
> + depends on COMMON_CLK_MT8173_MMSYS
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> --
> 2.17.1
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-26 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 13:50 [PATCH -next] drm/mediatek: Fix Kconfig warning YueHaibing
2020-04-26 8:20 ` Chun-Kuang Hu [this message]
2020-04-28 3:17 ` [PATCH v2 -next] soc: mediatek: " YueHaibing
2020-04-28 14:55 ` [PATCH -next] drm/mediatek: " Daniel Vetter
2020-04-28 16:05 ` Chun-Kuang Hu
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
2020-04-29 14:02 ` Enric Balletbo i Serra
2020-04-29 14:15 ` Chun-Kuang Hu
2020-05-06 0:28 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOTY__km=QZQACp8g-Qr+aWZ4r0Yp7O5j7u8ZTpDpTXXfUdNw@mail.gmail.com' \
--to=chunkuang.hu@kernel.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).