From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FBDC0044D for ; Wed, 11 Mar 2020 23:36:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE6C520754 for ; Wed, 11 Mar 2020 23:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="m1Rot4bz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE6C520754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09488895D7; Wed, 11 Mar 2020 23:36:31 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DEB8895D7 for ; Wed, 11 Mar 2020 23:36:30 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id c20so3234971lfb.0 for ; Wed, 11 Mar 2020 16:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YKKTGMGuC7csysaHUesEZogJs7wnfht4eIuQDMWN8RY=; b=m1Rot4bztTgh2wPUxiSW/rqn0jSM0lhavj6u4hAqIl77E3iaCQG/e/kkCksb97Xhqf 1XvpZHOinpeFWhukb5Adv4V5rnhXTaZKAEZgKjtNi7QxGpGkMQfFlPyPYPjCnfzfBbDK UjwFxBhd/Kfd1uCnOa2tBMdTUhBtRSeoSqJq0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YKKTGMGuC7csysaHUesEZogJs7wnfht4eIuQDMWN8RY=; b=TKt3WlnWuXObHp3BT45RPw/OR0zO8LgKCWiWYuQuqD+4XHTLxyHdNXrKHGti0yW1x+ +JVahOjSzGsSEoOqRNngqaY+XCil89ecu7guvH1MWLnSG0FdOPBJZWb91k3gj3OzOGix m11XHz8EUcy4rK6XCzrBUJkZpc7TunKzN3/YQp8v+WJiXz1TzkjTyT9jM6zZeSoc8G6v L685EraTyuC+vXDJlJxFyTFxoZjs7sLr2a3PeUDrKliBaicuNWtCuAR3XFWlVNE3a+2G +ZCLdWfTEXSAC7uW6QRQf2J1Rv9gAOXS/sIQ+50d/EQkhTYrbQC9NCumqRkmsE8TAZ7o fwYA== X-Gm-Message-State: ANhLgQ2hUOUjyfhO3iUHSrT94uMgnIwT+3zbI3/By47CeFsF4NheLROk YX00/De05P0VjdXV1gswWJrYp6/V694= X-Google-Smtp-Source: ADFU+vvHlxa7MydcZmTMbkhzmZpvDyuq3cyQGI9RPzakB2jn+OQx9IABTbi5tKNksTs3z+kxklRpFg== X-Received: by 2002:a19:cbc3:: with SMTP id b186mr3572714lfg.182.1583969788184; Wed, 11 Mar 2020 16:36:28 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id o26sm21874994ljg.33.2020.03.11.16.36.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2020 16:36:27 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id d23so4264233ljg.13 for ; Wed, 11 Mar 2020 16:36:27 -0700 (PDT) X-Received: by 2002:a05:651c:1026:: with SMTP id w6mr3295587ljm.168.1583969787038; Wed, 11 Mar 2020 16:36:27 -0700 (PDT) MIME-Version: 1.0 References: <20200310010818.569-1-gurchetansingh@chromium.org> <20200310074302.yx6anlvqvsg37yzs@sirius.home.kraxel.org> <20200311103609.ei446gelkvbqrdzm@sirius.home.kraxel.org> In-Reply-To: <20200311103609.ei446gelkvbqrdzm@sirius.home.kraxel.org> From: Gurchetan Singh Date: Wed, 11 Mar 2020 16:36:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 0/8] *** Per context fencing *** To: Gerd Hoffmann X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chad Versace , ML dri-devel , John Bates Content-Type: multipart/mixed; boundary="===============1000791270==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1000791270== Content-Type: multipart/alternative; boundary="0000000000007e257305a09cb425" --0000000000007e257305a09cb425 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 11, 2020 at 3:36 AM Gerd Hoffmann wrote: > Hi, > > > I should've been more clear -- this is an internal cleanup/preparation > and > > the per-context changes are invisible to host userspace. > > Ok, it wasn't clear that you don't flip the switch yet. In general the > commit messages could be a bit more verbose ... > > I'm wondering though why we need the new fence_id in the first place. > Isn't it enough to have per-context (instead of global) last_seq? > Heh, that was to leave open the possibility of multiple timelines per context. Roughly speaking, V2 -- multiple processes V3 -- multiple processes and multiple threads (due to VK multi-threaded command buffers) I think we all agree on V2. It seems we still have to discuss V3 (multi-queue, thread pools, a fence context associated with each thread) a bit more before we start landing pieces. > > Multi-queue sounds very interesting indeed, especially with VK > > multi-threaded command submission. That to me is V3 rather than V2.. > let's > > start easy! > > Having v2 if we plan to obsolete it with v3 soon doesn't look like a > good plan to me. It'll make backward compatibility more complex for > no good reason ... > > Also: Does virglrenderer render different contexts in parallel today? > Only in case it does we'll actually get benefits from per-context > fences. But I think it doesn't, so there is no need to rush. > > I think we should better have a rough plan for parallel rendering first, > then go start implementing the pieces needed. > > cheers, > Gerd > > --0000000000007e257305a09cb425 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 11, 2020 at 3:36 AM Gerd = Hoffmann <kraxel@redhat.com>= wrote:
=C2=A0 H= i,

> I should've been more clear -- this is an internal cleanup/prepara= tion and
> the per-context changes are invisible to host userspace.

Ok, it wasn't clear that you don't flip the switch yet.=C2=A0 In ge= neral the
commit messages could be a bit more verbose ...

I'm wondering though why we need the new fence_id in the first place. Isn't it enough to have per-context (instead of global) last_seq?

Heh, that was to leave open the possibility = of multiple timelines per context.=C2=A0 Roughly speaking,

V2 -- multiple processes
V3 -- multiple processes and mu= ltiple threads (due to VK multi-threaded command buffers)

I think we all agree on V2.=C2=A0 It seems we still=C2=A0have to di= scuss V3 (multi-queue, thread pools, a fence context associated with each t= hread) a bit more before we start landing pieces.=C2=A0


> Multi-queue sounds very interesting indeed, especially with VK
> multi-threaded command submission.=C2=A0 That to me is V3 rather than = V2.. let's
> start easy!

Having v2 if we plan to obsolete it with v3 soon doesn't look like a good plan to me.=C2=A0 It'll make backward compatibility more complex f= or
no good reason ...

Also: Does virglrenderer render different contexts in parallel today?
Only in case it does we'll actually get benefits from per-context
fences.=C2=A0 But I think it doesn't, so there is no need to rush.

I think we should better have a rough plan for parallel rendering first, then go start implementing the pieces needed.

cheers,
=C2=A0 Gerd

--0000000000007e257305a09cb425-- --===============1000791270== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1000791270==--