From: Huacai Chen <chenhuacai@kernel.org>
To: Sui Jingfeng <suijingfeng@loongson.cn>
Cc: Nathan Chancellor <nathan@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
inux-kernel@vger.kernel.org,
Christian Koenig <christian.koenig@amd.com>,
Emil Velikov <emil.l.velikov@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Sui Jingfeng <15330273260@189.cn>,
loongson-kernel@lists.loongnix.cn,
Liu Peibao <liupeibao@loongson.cn>,
dri-devel@lists.freedesktop.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v15 1/2] drm: Add kms driver for loongson display controller
Date: Mon, 19 Jun 2023 18:20:06 +0800 [thread overview]
Message-ID: <CAAhV-H5XR+tbxuDoGHZo3vshes6xwhBOGC=OrZy11Mq5fizaCA@mail.gmail.com> (raw)
In-Reply-To: <3e41da42-7bfc-c934-d8a1-ec18047849dc@loongson.cn>
On Mon, Jun 19, 2023 at 6:12 PM Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>
> Hi.
>
> On 2023/6/19 17:18, Huacai Chen wrote:
> >> +
> >> +enum loongson_chip_id {
> >> + CHIP_LS7A1000 = 0,
> >> + CHIP_LS7A2000 = 1,
> >> + CHIP_LS_LAST,
> > CHIP_LAST or CHIP_LOONGSON_LAST?
> >
> This is intended, CHIP_LAST is already defined by other drivers.
>
> It will not cause redefinition, but it deny my VIM text editor jump to
>
> the right place on one shot.
Then use CHIP_LOONGSON_LAST please.
Huacai
>
> --
> Jingfeng
>
next prev parent reply other threads:[~2023-06-19 10:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 14:36 [PATCH v15 0/2] drm: Add kms driver for loongson display controller Sui Jingfeng
2023-06-15 14:36 ` [PATCH v15 1/2] " Sui Jingfeng
2023-06-19 9:18 ` Huacai Chen
2023-06-19 9:36 ` Sui Jingfeng
2023-06-19 10:07 ` Sui Jingfeng
2023-06-19 10:19 ` Huacai Chen
2023-06-27 15:27 ` Sui Jingfeng
2023-06-27 15:41 ` Sui Jingfeng
2023-06-19 10:12 ` Sui Jingfeng
2023-06-19 10:20 ` Huacai Chen [this message]
2023-06-19 11:36 ` Sui Jingfeng
2023-06-19 10:25 ` Sui Jingfeng
2023-06-25 7:56 ` liyi
2023-06-28 1:20 ` Sui Jingfeng
2023-06-15 14:36 ` [PATCH v15 2/2] MAINTAINERS: add maintainers for DRM LOONGSON driver Sui Jingfeng
2023-06-21 18:25 ` [PATCH v15 0/2] drm: Add kms driver for loongson display controller Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H5XR+tbxuDoGHZo3vshes6xwhBOGC=OrZy11Mq5fizaCA@mail.gmail.com' \
--to=chenhuacai@kernel.org \
--cc=15330273260@189.cn \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=inux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=suijingfeng@loongson.cn \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).