From: Dave Emett <david.emett@broadcom.com>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Spurden <thomas.spurden@broadcom.com>
Subject: Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.
Date: Fri, 8 Mar 2019 16:38:08 +0000 [thread overview]
Message-ID: <CAApk1dVubN7ME6GNuedGmF4V1qnH_JYnSEvFffAzwsMFaZNmgg@mail.gmail.com> (raw)
In-Reply-To: <20190220233658.986-1-eric@anholt.net>
Sorry, a few things I thought of after sending the Reviewed-by email...
> + v3d->reset = devm_reset_control_get_exclusive(dev, NULL);
> + if (IS_ERR(v3d->reset)) {
> + ret = PTR_ERR(v3d->reset);
> +
> + if (ret == -EPROBE_DEFER)
> + goto dev_free;
Might be preferable to make this explicitly check against the
not-found error code (whatever that is)? As in if (not found)
<fallback to bridge> else <return error code>. Similarly...
> + if (platform_get_irq(v3d->pdev, 1) < 0) {
This should probably explicitly check for not-found rather than any
error. As-is, we might silently go down the single-interrupt-line path
on a platform with 2 interrupt lines if platform_get_irq(v3d->pdev, 1)
hits some other error.
> + ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, 0),
> + v3d_hub_irq, IRQF_SHARED,
> + "v3d_hub", v3d);
> + ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, 1),
> + v3d_irq, IRQF_SHARED,
> + "v3d_core0", v3d);
Not introduced by this change, but return value from first
devm_request_irq ignored here?
next prev parent reply other threads:[~2019-03-08 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 23:36 [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2 Eric Anholt
2019-02-20 23:36 ` [PATCH v3 2/3] drm/v3d: Don't try to set OVRTMUOUT on V3D 4.x Eric Anholt
2019-03-08 16:45 ` Dave Emett
2019-02-20 23:36 ` [PATCH v3 3/3] drm/v3d: Make sure the GPU is on when measuring clocks Eric Anholt
2019-03-08 16:47 ` Dave Emett
2019-03-08 16:22 ` [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2 Dave Emett
2019-03-08 16:38 ` Dave Emett [this message]
2019-03-08 16:51 ` Eric Anholt
2019-03-08 17:47 ` Eric Anholt
2019-03-08 18:10 ` Dave Emett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAApk1dVubN7ME6GNuedGmF4V1qnH_JYnSEvFffAzwsMFaZNmgg@mail.gmail.com \
--to=david.emett@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.spurden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).