From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CF52C433EF for ; Wed, 22 Jun 2022 07:12:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A16B10F6AE; Wed, 22 Jun 2022 07:12:40 +0000 (UTC) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D7ED10F6AE for ; Wed, 22 Jun 2022 07:12:39 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id v14so22028995wra.5 for ; Wed, 22 Jun 2022 00:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RDKZYtCFuI4hhvdB+I5Xxsl+1SWiRqZ/nc/uthD5llI=; b=QwEiVInRKq6N7jg9KMkKdIINqR1Qp8irQMnsjVFRrJMh4smMCD3qTmFThVOLREmk7x Fwhl3fHQW6hymA+uD49nPJztuIpchjyo4UQ5CHqwzNJLTwl3fINZh0TzwTcmHSFtFrKS H1AtRTjgvST5U/OlpdC/9ufKETYu5iRHw0/Lp33qHz2bNn3cW5Y6/5k4EAFWxUToLswW FsnIKPTrkhftkjOHAYL/k7ffAA2TXFfR1TB1cuagBWOuF0+bgeB1m75LZWT5GYR+NFAl 7/QoYrckYxR3UonbjnHN0RRpm/M7eZvjykWexvQnl7cr7cuxiioY31Y0fOl1R+s5E/u1 4vUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RDKZYtCFuI4hhvdB+I5Xxsl+1SWiRqZ/nc/uthD5llI=; b=RdaVN+Zuh0IynRYUNzHaFKw2br873tJYeqMmF1EGLoTZ5Lvleydaya5jto1cHlBu1T sXWdUYVPwJPzAaut2zmllvafyON0ubvCQ/ZpU87oG6TZRj9dmzWTilf65FlRx3atl4jD kHljdX3hDearksaEPq4+quSS2FQf3bGQhgxGetjGQsNVtKjqmlmLlcr1W+SxTcz9wh4M Ur2DxsFEAqnBnNxUHj9qpGpiJcqKAh0WpGvLwYstJ61tgkkh6Zu7u9ziTqttYDXnkkWH rkY7/VFyOyqbq0k02vQk7UxXa+I5r40jnZgLzrdtRDbAsT45hq+6a3iNT+gQ5ktTJ3/z FVCw== X-Gm-Message-State: AJIora+9b+pMT0AkfcAP5msXjs4m+mnOAN+dqWO8MnWZksW/JNLoZ3xJ ekMLvPFj+aS1NqoFIGP2LbvOPcDKUKiGN9Q3qlPEsw== X-Google-Smtp-Source: AGRyM1thVkSwFHSrbqy+ZI6m35qN0uPuxiviR5i8XLANMs5sMO9TNlgwVQzKRsEodNba6+FEL+5YqW7+gQBHOxB42Kw= X-Received: by 2002:a05:6000:1f98:b0:21b:9cf4:c681 with SMTP id bw24-20020a0560001f9800b0021b9cf4c681mr1720643wrb.89.1655881957748; Wed, 22 Jun 2022 00:12:37 -0700 (PDT) MIME-Version: 1.0 References: <20220620160640.3790-1-jose.exposito89@gmail.com> <20220620160640.3790-2-jose.exposito89@gmail.com> <045f480b-9f47-6f10-9e5d-4436335b272e@suse.de> In-Reply-To: <045f480b-9f47-6f10-9e5d-4436335b272e@suse.de> From: David Gow Date: Wed, 22 Jun 2022 15:12:26 +0800 Message-ID: Subject: Re: [PATCH v4 1/3] drm/rect: Add DRM_RECT_INIT() macro To: Thomas Zimmermann Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000e6d2b405e2040f8c" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: magalilemes00@gmail.com, David Airlie , =?UTF-8?B?TWHDrXJhIENhbmFs?= , Daniel Latypov , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , Jani Nikula , tales.aparecida@gmail.com, =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Isabella Basso , KUnit Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --000000000000e6d2b405e2040f8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 21, 2022 at 6:02 PM Thomas Zimmermann wro= te: > > Hi > > Am 21.06.22 um 11:38 schrieb David Gow: > > On Tue, Jun 21, 2022 at 12:06 AM Jos=C3=A9 Exp=C3=B3sito [ ... ] > >> +/** > >> + * DRM_RECT_INIT - initialize a rectangle from x/y/w/h > >> + * @x: x coordinate > >> + * @y: y coordinate > >> + * @w: width > >> + * @h: height > >> + * > >> + * RETURNS: > >> + * A new rectangle of the specified size. > >> + */ > >> +#define DRM_RECT_INIT(x, y, w, h) ((struct drm_rect){ \ > >> + .x1 =3D (x), \ > >> + .y1 =3D (y), \ > >> + .x2 =3D (x) + (w), \ > >> + .y2 =3D (y) + (h) }) > >> + > > > > My only slight concern here is that it might be a little bit confusing > > that a macro called DRM_RECT_INIT() accepts x/y/w/h, whereas the > > actual struct drm_rect is x1/y1/x2/y2. If the macro were called > > something like DRM_RECT_INIT_FROM_XYWH() or similar. > > The existing drm_rect_init() function uses xywh arguments. So the > current name is consistent with existing practice. I don't think we > refer to x2,y2 much, if ever. > Ah, fair enough. I wasn't aware of the existing drm_rect_init() function, so this makes sense as-is. Cheers, -- David --000000000000e6d2b405e2040f8c Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPnwYJKoZIhvcNAQcCoIIPkDCCD4wCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz5MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNgwggPAoAMCAQICEAGH0uAg+eV8wUdHQOJ7 yfswDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjA2MjAw MjAzNTNaFw0yMjEyMTcwMjAzNTNaMCQxIjAgBgkqhkiG9w0BCQEWE2RhdmlkZ293QGdvb2dsZS5j b20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCv9aO5pJtu5ZPHSb99iASzp2mcnJtk JIh8xsJ+fNj9OOm0B7Rbg2l0+F4c19b1DyIzz/DHXIX9Gc55kfd4TBzhITOJmB+WdbaWS8Lnr9gu SVO8OISymO6uVA0Lmkfne3zV0TwRtFkEeff0+P+MqdaLutOmOcLQRp8eAzb/TNKToSROBYmBRcuA hDOMCVZZozIJ7T4nHBjfOrR+nJ4mjBIDRnDucs4dazypyiYiHYLfedCxp8vldywHMsTxl59Ue9Yk RVewDw3HWvWUIMbc+Y636UXdUn4axP1TXN0khUpexMoc5qCHxpBIE/AyeS4WPASlE8uVY9Qg8dT6 kJmeOT+ZAgMBAAGjggHUMIIB0DAeBgNVHREEFzAVgRNkYXZpZGdvd0Bnb29nbGUuY29tMA4GA1Ud DwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIwHQYDVR0OBBYEFDyAvtuc z/tQRXr3iPeVmZCr7nttMEwGA1UdIARFMEMwQQYJKwYBBAGgMgEoMDQwMgYIKwYBBQUHAgEWJmh0 dHBzOi8vd3d3Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAwGA1UdEwEB/wQCMAAwgZoGCCsG AQUFBwEBBIGNMIGKMD4GCCsGAQUFBzABhjJodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9jYS9n c2F0bGFzcjNzbWltZWNhMjAyMDBIBggrBgEFBQcwAoY8aHR0cDovL3NlY3VyZS5nbG9iYWxzaWdu LmNvbS9jYWNlcnQvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3J0MB8GA1UdIwQYMBaAFHzMCmjXouse LHIb0c1dlW+N+/JjMEYGA1UdHwQ/MD0wO6A5oDeGNWh0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20v Y2EvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3JsMA0GCSqGSIb3DQEBCwUAA4IBAQAx+EQjLATc/sze VoZkH7OLz+/no1+y31x4BQ3wjW7lKfay9DAAVym896b7ECttSo95GEvS7pYMikzud57WypK7Bjpi ep8YLarLRDrvyyvBuYtyDrIewkuASHtV1oy5E6QZZe2VOxMm6e2oJnFFjbflot4A08D3SwqDwV0i OOYwT0BUtHYR/3903Dmdx5Alq+NDvUHDjozgo0f6oIkwDXT3yBV36utQ/jFisd36C8RD5mM+NFpu 3aqLXARRbKtxw29ErCwulof2dcAonG7cd5j+gmS84sLhKU+BhL1OQVXnJ5tj7xZ5Ri5I23brcwk0 lk/gWqfgs3ppT9Xk7zVit9q8MYICajCCAmYCAQEwaDBUMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQ R2xvYmFsU2lnbiBudi1zYTEqMCgGA1UEAxMhR2xvYmFsU2lnbiBBdGxhcyBSMyBTTUlNRSBDQSAy MDIwAhABh9LgIPnlfMFHR0Die8n7MA0GCWCGSAFlAwQCAQUAoIHUMC8GCSqGSIb3DQEJBDEiBCCK zcW2Z1uaXYMzJtnISri3rG2gDp5+7FseI92N/ugVHzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0yMjA2MjIwNzEyMzhaMGkGCSqGSIb3DQEJDzFcMFowCwYJYIZIAWUD BAEqMAsGCWCGSAFlAwQBFjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwCwYJKoZIhvcNAQEKMAsG CSqGSIb3DQEBBzALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEggEAjz7g9C/UX39UCPuovgSd 3HF9i/V5oEr9fHSHH4s7Fpoyhjd3qRMtdOnfqE3SsglemHE0sxUB6dbh2bMnJSlPr2El+DcV/A8v Xu3n2pjG2i4+Hvc/NAhA/b27cXCfYo45a7LACpspcD3+hH7l4O7Yw6IegG7xhCqyLocmE9ffJdoX RM5UxvfWOpVMUX9BI2w/C8JtK/+QcmRT5kU1wlwOBAnfgWijTXDWJuFCmkcNJDrZAwGR5EiSSwUf k7rwsLSXs2tv2hpcE/Sb2xBDpJckhskgtEYoZoWUcRexNkCqmyBP1dIWStST7JCCfabNyMxzXNt9 NA1K7MocUp/m3ziJ6Q== --000000000000e6d2b405e2040f8c--