From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5AF5C433DB for ; Wed, 3 Feb 2021 08:13:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 835E464F50 for ; Wed, 3 Feb 2021 08:13:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 835E464F50 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lagfreegames.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A62926E9D7; Wed, 3 Feb 2021 08:13:08 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C1176E09F for ; Tue, 2 Feb 2021 18:15:18 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id p20so12096305ejb.6 for ; Tue, 02 Feb 2021 10:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lagfreegames.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kmod/TM4yTTwB8JXm3ef9//IZzNhybL2qZHmMqtiATE=; b=Q4ovLeWSr2HSjosq07RfsWSRTkkrTIzF55woEYCclWG2sWZsLU3gMfHFjp0VwdGSIg gbpL1/09ScS2GuCTaxgTZWucWswzQIEJBQJhH5/XJtWlCSy6eiFDxWAbLEQO6fXCMr4I vstMFJDhHuR2TdY5NrWt1Zh3HF2nADwhtOJjSbw/V283UxPfP31Zttjke8SEswYxS3kO ulVRBRzMSXnb5KLmBJZrebvnx/pmtQLFw4CV6G/l1l4Jc7/oYptNtXB+pJIcUAHAWSAW So8H9zPvwwRYWOMdaE3EBBQkGBZlqxswwBS8Tnq+mOORzxVrUiLwTAwle3iJXqC5//A+ aI0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kmod/TM4yTTwB8JXm3ef9//IZzNhybL2qZHmMqtiATE=; b=uU9MWH8wPs7UVUPOLndTDSDqWqUXO6pMJ341aSOW+yjUfNR6KWXV+8L0TwMnTvGE8U zE+Wswf03wFBWTLVZgZoMcmAAmUbswoAvckxge8R+gnRU1rfd4YNA7T9VXNgdRpLsZ4W 6FZlAAxdCrUE/61p5JUYtKByxX5GAmYZy1dNh1trEJJSEwTO9xepIp4UOxrkzbTZZJ68 oSrjk03mwBpFWDGic9zhu+3v9y9V+SFQGaXyXHJatx5whq14DY4PvQQnjpwcDzwt+b5f KGCO82hon78Mv8hG//16bBEb4cbzHjR6dQ5P3Y9rb6B6zhtI7GD52yJXBTPeWZY6vhP+ DdQw== X-Gm-Message-State: AOAM5308EUJ6viLOU6HjTVPTb0Qe/e4CdEmtbu/F7A9uB8LuUzbqLRMe w9ymNL4609cm4fLZ9jcnPTrtxzcG/7/LtGgAsxVbgQ== X-Google-Smtp-Source: ABdhPJy8qTG1B8uamv6+rAAXIcCkAhXeu4fLlQKg9iIWeMp/kwkvp+/jR2J+nXdJQV8nftel3Bi4g0SC/BrdYpcFYX0= X-Received: by 2002:a17:906:7ca:: with SMTP id m10mr15717991ejc.257.1612289716695; Tue, 02 Feb 2021 10:15:16 -0800 (PST) MIME-Version: 1.0 References: <20201210103553.1ae238d2@eldfell> <1607591574-949-1-git-send-email-jpark37@lagfreegames.com> <1607591574-949-2-git-send-email-jpark37@lagfreegames.com> In-Reply-To: From: James Park Date: Tue, 2 Feb 2021 10:14:42 -0800 Message-ID: Subject: Re: [PATCH] drm: drm_basic_types.h, DRM_FOURCC_STANDALONE To: Emil Velikov X-Mailman-Approved-At: Wed, 03 Feb 2021 08:13:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel Content-Type: multipart/mixed; boundary="===============1398836760==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1398836760== Content-Type: multipart/alternative; boundary="000000000000d6d02505ba5e7369" --000000000000d6d02505ba5e7369 Content-Type: text/plain; charset="UTF-8" I'm not sure what your suggestion is. Move which #ifdef block where? I don't think everyone is of the opinion that adding drm.h and pulling in unnecessary kernel structures is fine. If I'm not mistaken, the reason people are making me jump through hoops in the first place is to avoid that. I appreciate the feedback though. - James On Tue, Feb 2, 2021 at 9:28 AM Emil Velikov wrote: > Hi James, > > On Tue, 2 Feb 2021 at 08:27, James Park > wrote: > > > > Hello, > > > > Is there something I can do to help move this patch along? > > > > Thanks, > > James Park > > > > On Thu, Dec 10, 2020 at 1:13 AM James Park > wrote: > >> > >> Create drm_basic_types.h to define types previously defined by drm.h. > >> > >> Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h. > >> > >> This will allow Mesa to port code to Windows more easily. > >> > >> Signed-off-by: James Park > >> Acked-by: Simon Ser > >> Reviewed-by: Pekka Paalanen > >> --- > >> include/uapi/drm/drm.h | 12 ++------- > >> include/uapi/drm/drm_basic_types.h | 52 > ++++++++++++++++++++++++++++++++++++++ > >> include/uapi/drm/drm_fourcc.h | 4 +++ > >> 3 files changed, 58 insertions(+), 10 deletions(-) > >> create mode 100644 include/uapi/drm/drm_basic_types.h > >> > Have you considered the possibility of having the ifdef block inlined > within drm_fourcc.h? > > Sure some users might need to add an drm.h include in their code. At > the same time they also need to explicitly define > DRM_FOURCC_STANDALONE, so that is fine. > We had all sorts of issues with these headers in the past, so adding > another one might end up repeating some of those yet again. > > Thanks > Emil > --000000000000d6d02505ba5e7369 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm not sure what your suggestion is. Move which #ifde= f block where?

I don't think everyone is of the opin= ion that adding drm.h and pulling in unnecessary kernel structures is fine.= If I'm not mistaken, the reason people are making me jump through hoop= s in the first place is to avoid that.

I appreciat= e the feedback though.

- James

On Tue, Feb 2,= 2021 at 9:28 AM Emil Velikov <emil.l.velikov@gmail.com> wrote:
Hi James,

On Tue, 2 Feb 2021 at 08:27, James Park <james.park@lagfreegames.com> wrote= :
>
> Hello,
>
> Is there something I can do to help move this patch along?
>
> Thanks,
> James Park
>
> On Thu, Dec 10, 2020 at 1:13 AM James Park <jpark37@lagfreegames.com> wro= te:
>>
>> Create drm_basic_types.h to define types previously defined by drm= .h.
>>
>> Use DRM_FOURCC_STANDALONE to include drm_fourcc.h without drm.h. >>
>> This will allow Mesa to port code to Windows more easily.
>>
>> Signed-off-by: James Park <jpark37@lagfreegames.com>
>> Acked-by: Simon Ser <contact@emersion.fr>
>> Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.com>
>> ---
>>=C2=A0 include/uapi/drm/drm.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0| 12 ++-------
>>=C2=A0 include/uapi/drm/drm_basic_types.h | 52 ++++++++++++++++++++= ++++++++++++++++++
>>=C2=A0 include/uapi/drm/drm_fourcc.h=C2=A0 =C2=A0 =C2=A0 |=C2=A0 4 = +++
>>=C2=A0 3 files changed, 58 insertions(+), 10 deletions(-)
>>=C2=A0 create mode 100644 include/uapi/drm/drm_basic_types.h
>>
Have you considered the possibility of having the ifdef block inlined
within drm_fourcc.h?

Sure some users might need to add an drm.h include in their code. At
the same time they also need to explicitly define
DRM_FOURCC_STANDALONE, so that is fine.
We had all sorts of issues with these headers in the past, so adding
another one might end up repeating some of those yet again.

Thanks
Emil
--000000000000d6d02505ba5e7369-- --===============1398836760== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1398836760==--