From: Nicolas Chauvet <kwizart@gmail.com>
To: Ben Skeggs <skeggsb@gmail.com>
Cc: regressions@lists.linux.dev, kherbst@redhat.com,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>,
airlied@redhat.com
Subject: Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79
Date: Mon, 30 Jan 2023 17:05:23 +0100 [thread overview]
Message-ID: <CABr+WT=a3YqyS0VWCoRDE-QGGJrP8AL3CpMPsZXR3Ps-tmjrWQ@mail.gmail.com> (raw)
In-Reply-To: <CACAvsv5sA8pmhYEVhJk9PEAWyKRZYvcsSHa-04CsJxgu7+YEiw@mail.gmail.com>
Le dim. 29 janv. 2023 à 23:36, Ben Skeggs <skeggsb@gmail.com> a écrit :
>
> On Fri, 27 Jan 2023 at 20:42, Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt> wrote:
> >
> > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote:
> > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt> wrote:
> > > >
> > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote:
> > > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt> wrote:
> > > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote:
> > > > > > > As a quick check can you try changing
> > > > > > >
> > > > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target
> > > > > > > from NVKM_MEM_TARGET_HOST to NVKM_MEM_TARGET_NCOH ?
> > > >
> > > > > In addition to Dave's change, can you try changing the
> > > > > nvkm_falcon_load_dmem() call in gm20b_pmu_init() to:
> > > > >
> > > > > nvkm_falcon_pio_wr(falcon, (u8 *)&args, 0, 0, DMEM, addr_args,
> > > > > sizeof(args), 0, false);
> > > >
> > > > Chiming in just to say that with this change I see the same as Nicolas
> > > > except that the init message size is 255 instead of 0:
> > > >
> > > > [ 2.196934] nouveau 57000000.gpu: pmu: unexpected init message size 255 vs 42
> > > I've attached an entirely untested patch (to go on top of the other
> > > hacks/fixes so far), that will hopefully get us a little further.
> >
> > Hello,
> >
> > Thank you for the patch! I can confirm that it fixes the problem
> > on the Pixel C, and everything works as before the regression.
> > With this, for the combination of patches
> >
> > Tested-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> >
> > which I can resend after testing the final patch version.
> Thank you (both!) for testing!
>
> I've attached a "final" version of a patch that I'll send (assuming it
> still works ;)) after re-testing. There's only a minor change to
> avoid breaking the non-Tegra path, so I expect it should be fine.
Fine with me.
Tested-By: Nicolas Chauvet <kwizart@gmail.com>
Thanks.
next prev parent reply other threads:[~2023-01-30 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 14:49 [REGRESSION] GM20B probe fails after commit 2541626cfb79 Diogo Ivo
2023-01-05 12:28 ` Thorsten Leemhuis
2023-01-13 13:19 ` Linux kernel regression tracking (Thorsten Leemhuis)
2023-01-14 3:27 ` Karol Herbst
2023-01-14 16:03 ` Diogo Ivo
2023-01-14 18:56 ` Karol Herbst
2023-01-14 15:58 ` Diogo Ivo
2023-02-03 9:13 ` Linux kernel regression tracking (#update)
2023-01-15 21:45 ` David Airlie
2023-01-16 12:24 ` Diogo Ivo
2023-01-18 1:28 ` Ben Skeggs
2023-01-18 8:42 ` [Nouveau] " Nicolas Chauvet
2023-01-20 11:34 ` Diogo Ivo
2023-01-27 6:00 ` Ben Skeggs
2023-01-27 9:03 ` Nicolas Chauvet
2023-01-27 10:48 ` Diogo Ivo
2023-01-27 10:39 ` Diogo Ivo
2023-01-29 22:36 ` Ben Skeggs
2023-01-30 13:54 ` Diogo Ivo
2023-01-30 16:05 ` Nicolas Chauvet [this message]
2023-01-17 15:55 ` [Nouveau] " Nicolas Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABr+WT=a3YqyS0VWCoRDE-QGGJrP8AL3CpMPsZXR3Ps-tmjrWQ@mail.gmail.com' \
--to=kwizart@gmail.com \
--cc=airlied@redhat.com \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=regressions@lists.linux.dev \
--cc=skeggsb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).