From: Ben Skeggs <skeggsb@gmail.com>
To: Dave Airlie <airlied@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Ben Skeggs" <bskeggs@redhat.com>
Subject: Re: [PATCH 00/45] TTM move refactoring
Date: Wed, 30 Sep 2020 15:51:14 +1000 [thread overview]
Message-ID: <CACAvsv7tp3E1a6WBMSg3cyaQBVJbuGxeqO4fo5ZtyovLk57h4A@mail.gmail.com> (raw)
In-Reply-To: <20200924051845.397177-1-airlied@gmail.com>
On Thu, 24 Sep 2020 at 15:19, Dave Airlie <airlied@gmail.com> wrote:
>
> This refactors how TTM moves get called between core and drivers.
>
> 1) puts the driver in charge of all moves, and enforces
> drivers have a move callback.
> 2) moves move_notify actions around moves to the driver side
> 3) moves binding/unbinding completely into move and driver side
> 4) add a new invalidate callback to replace the last use of move_notify
> 5) add some helpers to cleanup the resulting move code
>
> There's a bit of internal churn to try and make each patch logical, so
> don't get too caught up in each patches changes unless the end result
> is a problem.
I've looked over the nouveau-specific patches, and the ttm ones
(mostly ignoring the changes to other drivers beyond a quick glance
over). For all but 37/45 and the patches that depend on it:
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
I'll add some more specific comments to one of the patches, but it's
also fine as-is.
Ben.
>
> Dave.
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-09-30 5:51 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 5:18 [PATCH 00/45] TTM move refactoring Dave Airlie
2020-09-24 5:18 ` [PATCH 01/45] drm/qxl: drop unused code Dave Airlie
2020-09-24 10:23 ` Christian König
2020-09-24 5:18 ` [PATCH 02/45] drm/ttm: handle the SYSTEM->TT path in same place as others Dave Airlie
2020-09-24 10:24 ` Christian König
2020-09-24 5:18 ` [PATCH 03/45] drm/amdgpu/ttm: handle tt moves properly Dave Airlie
2020-09-24 11:10 ` Christian König
2020-09-24 5:18 ` [PATCH 04/45] drm/radeon/ttm: handle ttm " Dave Airlie
2020-09-24 11:10 ` Christian König
2020-09-24 5:18 ` [PATCH 05/45] drm/nouveau/ttm: " Dave Airlie
2020-09-24 11:11 ` Christian König
2020-09-24 5:18 ` [PATCH 06/45] drm/vmwgfx: move null mem checks outside move notifies Dave Airlie
2020-09-24 11:12 ` Christian König
2020-09-24 5:18 ` [PATCH 07/45] drm/vmwgfx: add a move callback Dave Airlie
2020-09-24 11:13 ` Christian König
2020-09-24 5:18 ` [PATCH 08/45] drm/vram_helper: implement a ttm " Dave Airlie
2020-09-24 11:14 ` Christian König
2020-09-24 5:18 ` [PATCH 09/45] drm/ttm: make move callback compulstory Dave Airlie
2020-09-24 11:15 ` Christian König
2020-09-24 5:18 ` [PATCH 10/45] drm/ttm: refactor out common code to setup a new tt backed resource Dave Airlie
2020-09-24 11:17 ` Christian König
2020-09-24 5:18 ` [PATCH 11/45] drm/ttm: split out the move to system from move ttm code Dave Airlie
2020-09-24 11:22 ` Christian König
2020-09-24 5:18 ` [PATCH 12/45] drm/ttm: drop free old node wrapper Dave Airlie
2020-09-24 11:23 ` Christian König
2020-09-24 5:18 ` [PATCH 13/45] drm/ttm: use new move interface for known system->ttm moves Dave Airlie
2020-09-24 11:26 ` Christian König
2020-09-24 5:18 ` [PATCH 14/45] drm/ttm: add move old to system to drivers Dave Airlie
2020-09-24 12:02 ` Christian König
2020-09-24 5:18 ` [PATCH 15/45] drm/ttm: push copy unbind into drivers Dave Airlie
2020-09-24 12:17 ` Christian König
2020-09-24 5:18 ` [PATCH 16/45] drm/radeon/ttm: do move notify actions inside move Dave Airlie
2020-09-24 5:18 ` [PATCH 17/45] drm/amdgpu/ttm: handle invalidation in move callback Dave Airlie
2020-09-24 5:18 ` [PATCH 18/45] drm/nouveau: handle move notify inside " Dave Airlie
2020-09-30 5:53 ` Ben Skeggs
2020-09-24 5:18 ` [PATCH 19/45] drm/qxl/ttm: " Dave Airlie
2020-09-24 5:18 ` [PATCH 20/45] drm/vmwgfx/ttm: handle move notify inside move Dave Airlie
2020-09-24 5:18 ` [PATCH 21/45] drm/vram_helper: call move notify from the move callback Dave Airlie
2020-09-24 5:18 ` [PATCH 22/45] drm/ttm: don't call move notify around move Dave Airlie
2020-09-24 5:18 ` [PATCH 23/45] drm/ttm: move bind out of move_to_new_tt_mem Dave Airlie
2020-09-24 5:18 ` [PATCH 24/45] drm/ttm: handle binding in move callback Dave Airlie
2020-09-24 5:18 ` [PATCH 25/45] drm/ttm: don't call ttm_bo_move_ttm from drivers Dave Airlie
2020-09-24 5:18 ` [PATCH 26/45] drm/ttm: remove bind/unbind callbacks Dave Airlie
2020-09-24 13:32 ` Christian König
2020-09-24 5:18 ` [PATCH 27/45] drm/radeon/ttm: cleanup move exit paths Dave Airlie
2020-09-24 5:18 ` [PATCH 28/45] drm/nouveau/ttm: memcpy waits for bo already Dave Airlie
2020-09-24 5:18 ` [PATCH 29/45] drm/ttm: don't expose move old to system helper to drivers Dave Airlie
2020-09-24 5:18 ` [PATCH 30/45] drm/ttm: add a new invalidate notify callback Dave Airlie
2020-09-24 9:33 ` Daniel Vetter
2020-09-24 12:25 ` Christian König
2020-09-29 3:23 ` Dave Airlie
2020-09-29 7:05 ` Christian König
2020-09-24 5:18 ` [PATCH 31/45] drm/radeon: switch to " Dave Airlie
2020-09-24 5:18 ` [PATCH 32/45] drm/amdgpu/ttm: " Dave Airlie
2020-09-24 5:18 ` [PATCH 33/45] drm/nouveau/ttm: " Dave Airlie
2020-09-24 5:18 ` [PATCH 34/45] drm/qxl/ttm: move " Dave Airlie
2020-09-24 5:18 ` [PATCH 35/45] drm/vram-helper: move to invalidate callback Dave Airlie
2020-09-24 7:10 ` Thomas Zimmermann
2020-09-24 5:18 ` [PATCH 36/45] drm/ttm: drop move_notify callback Dave Airlie
2020-09-24 5:18 ` [PATCH 37/45] drm/ttm: add a helper to allocate a temp tt for copies Dave Airlie
2020-09-24 12:42 ` Christian König
2020-09-24 23:14 ` Dave Airlie
2020-09-25 7:39 ` Christian König
2020-09-25 8:16 ` Daniel Vetter
2020-09-25 8:18 ` Daniel Vetter
2020-09-25 9:34 ` Christian König
2020-09-25 13:17 ` Daniel Vetter
2020-09-25 13:40 ` Christian König
2020-09-25 13:56 ` Daniel Vetter
2020-09-24 5:18 ` [PATCH 38/45] drm/nouveau/ttm: use helper to allocate tt temp Dave Airlie
2020-09-24 5:18 ` [PATCH 39/45] drm/radeon/ttm: use new helper to create tmp tt Dave Airlie
2020-09-24 5:18 ` [PATCH 40/45] drm/amdgpu/ttm: use new ttm helper to create temp tt Dave Airlie
2020-09-24 5:18 ` [PATCH 41/45] drm/amdgpu/ttm: use helper function for caching/populate Dave Airlie
2020-09-24 5:18 ` [PATCH 42/45] drm/radeon/ttm: " Dave Airlie
2020-09-24 5:18 ` [PATCH 43/45] drm/nouveau/ttm: use helper for placement + populaate Dave Airlie
2020-09-24 5:18 ` [PATCH 44/45] drm/ttm: move more functionality into helper function Dave Airlie
2020-09-24 5:18 ` [PATCH 45/45] drm/ttm: add a new helper for a cleaning up after a ram move Dave Airlie
2020-09-24 6:40 ` [PATCH 00/45] TTM move refactoring Dave Airlie
2020-09-30 5:51 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACAvsv7tp3E1a6WBMSg3cyaQBVJbuGxeqO4fo5ZtyovLk57h4A@mail.gmail.com \
--to=skeggsb@gmail.com \
--cc=airlied@gmail.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).