From: Linus Walleij <linus.walleij@linaro.org>
To: Javier Martinez Canillas <javierm@redhat.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Peter Robinson <pbrobinson@gmail.com>,
kernel test robot <lkp@intel.com>, Borislav Petkov <bp@suse.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
He Ying <heying24@huawei.com>,
John Stultz <john.stultz@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Subject: Re: [PATCH] drivers/firmware: fix sysfb depends to prevent build failures
Date: Tue, 10 Aug 2021 14:51:26 +0200 [thread overview]
Message-ID: <CACRpkdY9UNYEs3w3JHLR78OmPSA+wkLb=FDP5kXdWTZpxnRU1g@mail.gmail.com> (raw)
In-Reply-To: <20210722044155.864600-1-javierm@redhat.com>
On Thu, Jul 22, 2021 at 6:42 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
> The Generic System Framebuffers support is built when the COMPILE_TEST
> option is enabled. But this wrongly assumes that all the architectures
> declare a struct screen_info.
>
> This is true for most architectures, but at least the following do not:
> arc, m68k, microblaze, openrisc, parisc and s390.
>
> By attempting to make this compile testeable on all architectures, it
> leads to linking errors as reported by the kernel test robot for parisc:
>
> All errors (new ones prefixed by >>):
>
> hppa-linux-ld: drivers/firmware/sysfb.o: in function `sysfb_init':
> (.init.text+0x24): undefined reference to `screen_info'
> >> hppa-linux-ld: (.init.text+0x28): undefined reference to `screen_info'
>
> To prevent these errors only allow sysfb to be built on systems that are
> going to need it, which are x86 BIOS and EFI.
>
> The EFI Kconfig symbol is used instead of (ARM || ARM64 || RISC) because
> some of these architectures only declare a struct screen_info if EFI is
> enabled. And also, because the sysfb code is only used for EFI on these
> architectures. For !EFI the "simple-framebuffer" device is registered by
> OF when parsing the Device Tree Blob (if a DT node for this is defined).
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I don't know who picks up firmware patches though, I would send them
to soc@kernel.org if nothing else works.
Yours,
Linus Walleij
prev parent reply other threads:[~2021-08-10 12:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 4:41 [PATCH] drivers/firmware: fix sysfb depends to prevent build failures Javier Martinez Canillas
2021-08-10 12:51 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY9UNYEs3w3JHLR78OmPSA+wkLb=FDP5kXdWTZpxnRU1g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=dinguyen@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heying24@huawei.com \
--cc=javierm@redhat.com \
--cc=john.stultz@linaro.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nsaenz@kernel.org \
--cc=pbrobinson@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).