From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608C7C43461 for ; Fri, 30 Apr 2021 00:59:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D868861433 for ; Fri, 30 Apr 2021 00:58:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D868861433 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B4EB6E408; Fri, 30 Apr 2021 00:58:59 +0000 (UTC) Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C5476E408 for ; Fri, 30 Apr 2021 00:58:57 +0000 (UTC) Received: by mail-lj1-x230.google.com with SMTP id s9so20808759ljj.6 for ; Thu, 29 Apr 2021 17:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ug9+khgowmMqU2OH1VgDimh2CfwPCpiExOxiCSc2h0I=; b=UxYUIpC8zsej/AXMWEHLS+xgrFyIWrbe7S8c1+dqc6mKLDjUldq5OrdhSuTcgwyGvX EKur9XF+1qsoYmcQmJdKijXOXA5igWdz5sgsZ7NURwA0CR0W3b1Jl2E9pixlRFIfjyLn it+7n6Dz5UefHeJ3m1vDdsE2T22SE+/8blWlA6RTpDRqmlxsX8wPwlRRsSnVtBcxMXsp RELuSlLchmV/w47kuL3vicmHMyaRa6u36BXD3257xyrLaRtMPNwkYDNbDQ+XT4n+4Ktl K1viEypW8UvyiH61oVCc3HvBUjmC4UUWD+hkdEW3HwU3Jkc5lkk4pbfoeT4ytnx+7Rp/ cbMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ug9+khgowmMqU2OH1VgDimh2CfwPCpiExOxiCSc2h0I=; b=ZFrgpZcyXYLtvLIvl63IPvD07bVvPOAhc1IQi/o5Bkh7oLaOnnalvPfcfLcVTQw6BO 5GE3m+l1pDcgPU0jXk6JEpYNshzbL+Yv/VcflptUkqY/MKzfXjQyDzWUF4/PV5XxTN0n P0XuberE5zLjsrx8ptjmWNSC78X3rRk0l/A2Ne14rh6FOSBthEV712Ivc9hWN2M+51w1 6IjOHE4BGr9cukJtQ2EeREFpnzfm/6Hg11rXyyJBp4JucqcZ3PFWZNOl1cpoGsN9Rk4h Dsm1EkYfQJTrnPiYK0bXZMCwACCydw1X37nG+BfFXHAfnO+ucFMwjpDtvMZzT90Thpwg 6OqA== X-Gm-Message-State: AOAM533zi/uYj5Yu0/cjiWVdh7V1GZGVxDKx77yg5E1a4/80fj8x1I+b gZCik5PRHMGc/W4yhTrD9V99ZYGkCnZJSHbnm1DI4w== X-Google-Smtp-Source: ABdhPJwlDZuKaqC8sT7GBS1lf5GJl0FtZXQZiW32Kva3RDd+ccG2UGF9RZliYJHFvIg1Ax8Qelrh/y+Im6KaZthl1FQ= X-Received: by 2002:a05:651c:503:: with SMTP id o3mr1774994ljp.368.1619744336001; Thu, 29 Apr 2021 17:58:56 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> From: Linus Walleij Date: Fri, 30 Apr 2021 02:58:45 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Douglas Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Stanislav Lisovskiy , Jernej Skrabec , Jonas Karlman , David Airlie , MSM , "open list:DRM PANEL DRIVERS" , Neil Armstrong , linux-kernel , Steev Klimaszewski , Stephen Boyd , Wolfram Sang , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Bjorn Andersson , Sam Ravnborg , linux-i2c Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 23, 2021 at 6:59 PM Douglas Anderson wrote: > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > avoid excessive unprepare / prepare") we started using pm_runtime, but > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > them now. > > Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") > Reported-by: Bjorn Andersson > Signed-off-by: Douglas Anderson This patch as such: Reviewed-by: Linus Walleij Notice however: you turn on pm runtime pm_runtime_enable() in panel_simple_probe() but are you ever turning it off in panel_simple_remove()? I think pm_runtime_disable(); need to be added there? Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel