From: Linus Walleij <linus.walleij@linaro.org>
To: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
thierry.reding@gmail.com, sam@ravnborg.org
Subject: Re: [RESEND v2 2/2] dt-bindings: display: Add STARRY 2081101QFH032011-53G
Date: Wed, 20 Apr 2022 22:48:52 +0200 [thread overview]
Message-ID: <CACRpkdZ--RCgM65nnEd=ebFQpQAPqZDvrBotynYTf+sdisAbsQ@mail.gmail.com> (raw)
In-Reply-To: <20220414081916.11766-2-xiazhengqiao@huaqin.corp-partner.google.com>
On Thu, Apr 14, 2022 at 10:19 AM xiazhengqiao
<xiazhengqiao@huaqin.corp-partner.google.com> wrote:
> Add dt-bindings for 10.1" TFT LCD module called STARRY 2081101
> QFH032011-53G.
>
> Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
(...)
> + enable-gpios:
> + description: a GPIO spec for the enable pin
The way this is used in the code makes me suspect this should
be named reset-gpios. What is the name of the pin on the
panel?
It also appears you should tag this as active low so in that case
write that in the description "always tag with GPIO_ACTIVE_LOW"
(and alter the code in the driver to match the inversion)
> + pp1800-supply:
> + description: core voltage supply
Hm the name of this supply makes me think the display controller is
actually named pp1800. Is this correct?
> + enable-gpios = <&pio 45 0>;
Don't use ordinal flags in examples.
examples:
- |
#include <dt-bindings/gpio/gpio.h>
(...)
reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-04-20 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 8:19 [RESEND v2 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver xiazhengqiao
2022-04-14 8:19 ` [RESEND v2 2/2] dt-bindings: display: Add STARRY 2081101QFH032011-53G xiazhengqiao
2022-04-20 20:48 ` Linus Walleij [this message]
2022-04-20 20:41 ` [RESEND v2 1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ--RCgM65nnEd=ebFQpQAPqZDvrBotynYTf+sdisAbsQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).