From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF25C18E5B for ; Sun, 15 Mar 2020 16:25:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 342D120637 for ; Sun, 15 Mar 2020 16:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p3BYWIc8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 342D120637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D7A489819; Sun, 15 Mar 2020 16:25:06 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F75889819 for ; Sun, 15 Mar 2020 16:25:05 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id d23so15818584ljg.13 for ; Sun, 15 Mar 2020 09:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bhIY9OOZnxZOPAI5wEukr5F3CCpgPoGyTg20FwGK9Tw=; b=p3BYWIc86jjcI6oonq+LpWal5UzLF4chdphbUkZtArCrHw3fHc0r6fLgOPpwW0F8hR gP4Wfu+rzzPF0TiSEeQmNwk7YZek2PC/56HeWXaU9kxZFmJvQJWL48w/6bXJGpQpscx5 mQX9XtRjy9J6ILCe4VTqiwLdoLeZcGSF3Iysfgputl8Zcpgi6nfthRWP8WGtplaOHCLV CNMRfxnmU/gE4fUM38FDIXmAIE3eXmYiOp66YfTTZUEbCG7yNMmznET0H3BKDguuKLBT R/j398gdVF4udQkU44i1ljFDNFJWmHisvPXTUXOtNS5ggRoJNJLfpoNBC6m0Wd1NyfIy bWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bhIY9OOZnxZOPAI5wEukr5F3CCpgPoGyTg20FwGK9Tw=; b=q2mDDIa5QaRs86FtUjtN2nDrv4jtg86y5cuFNk6Xelxgpzyh6EBlqToHF7C+eeKXvt afbnEgG52HMRqPcnLvSxQgmU1MLKnZTg3ire+Y2o8h7iAIP+B2KgiqsD4gBcZIMzM7tt Epqb/aDCogUk4Mi/d6aKRlsc0v2v5a88bBrkvOzhI3a3jwqqc3SelbfDocrBWwWMGolg Zb0Nv78BtZYJ8OKiG7r2VmjlTnZ8lXY3sJWP+22f4vLsy6dV2tHUZo6ns4kK1trT8snv oJEeIykKTkG1aXUH8p+N6UlEY4gvOhQBFttnmttpQ2+6V6yfRUcnMJvjWA9DkbLI18nh Hnjw== X-Gm-Message-State: ANhLgQ1JW1TwNsVzLDQyElS29vtPkxLUQ5AD6CmU1Cho1RBgqrIPWTbl Y8ZTxzxmDKMyL9gBEf8ZtGCzyONsbJkdqqIFZGAlQg== X-Google-Smtp-Source: ADFU+vvfAn91cdIuck/jsg/zit0I3le1KpoewT5X+4/992npdZo2Qy9O+m/M8W1xq/3HAyQmj+l2pjjAwAxIq9vsk0M= X-Received: by 2002:a2e:9a96:: with SMTP id p22mr12246494lji.258.1584289503947; Sun, 15 Mar 2020 09:25:03 -0700 (PDT) MIME-Version: 1.0 References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-3-sam@ravnborg.org> In-Reply-To: <20200315134416.16527-3-sam@ravnborg.org> From: Linus Walleij Date: Sun, 15 Mar 2020 17:24:52 +0100 Message-ID: Subject: Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves To: Sam Ravnborg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Nikolaus Schaller , Jonathan Bakker , Sandeep Panda , "open list:DRM PANEL DRIVERS" , Paul Cercueil , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Chris Zhong , Marco Franchi , Stefan Mavrodiev , Jerry Han , Hoegeun Kwon , Tony Lindgren , Nickey Yang , Tomi Valkeinen , Jagan Teki , Robert Chiras , Vinay Simha BN , Marek Belisko , Heiko Schocher , Guido Gunther , Brian Masney , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Mark Brown , Alexandre Courbot , Werner Johansson , Purism Kernel Team , Peter Ujfalusi , Lin Huang , Douglas Anderson , linux-spi , Peter Rosin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Mar 15, 2020 at 2:44 PM Sam Ravnborg wrote: > Independent bindings can be SPI slaves which for example is > the case for several panel bindings. > > Move SPI slave properties to spi-slave.yaml so the independent > SPI slave bindings can include spi-slave.yaml rather than > duplicating the properties. To me it seems like you are creating the common SPI slave bindings? Maybe the commit message should be about that. > + reg: > + minimum: 0 > + maximum: 256 255? Or am I wrong? Apart from that it looks good to me. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel