From: Linus Walleij <linus.walleij@linaro.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: mairacanal@riseup.net, javierm@redhat.com,
dri-devel@lists.freedesktop.org, jose.exposito89@gmail.com
Subject: Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection
Date: Mon, 15 May 2023 11:30:40 +0200 [thread overview]
Message-ID: <CACRpkdaE=v=eyazZ-scUX=SpOB9_CkVe5V9yK_GrSR=wWTt8NA@mail.gmail.com> (raw)
In-Reply-To: <61a08812-c452-b146-bb24-71aeaea26e33@suse.de>
On Mon, May 15, 2023 at 11:26 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> > I think I found this, the bandwidth limit calculation in
> > drivers/gpu/drm/pl111/pl111_display.c was using the bpp from
> > the config and this was decreased from 16 to 15 and as it determined
> > cpp by dividing bpp/8 this decreased from 2 bytes to 1 byte.
> >
> > Testing with DIV_ROUND_UP() in combination with the previous
> > fix!
>
> Great. It's the code in mode_valid, right? That fix should be good
> enough for now. In the long term, we could make some of the internal
> fb-helper code available to drivers. You'd then be able to use it to get
> the depth/bpp values for the color mode.
Yeah I sent a patch, check it out!
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-05-15 9:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 11:29 [PATCH v3 00/13] drm: Fix color-format selection in fbdev emulation Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 01/13] firmware/sysfb: Fix EFI/VESA format selection Thomas Zimmermann
2023-04-06 15:45 ` Pierre Asselin
2023-04-08 11:26 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-04-16 12:06 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-04-08 16:10 ` Pierre Asselin
2023-04-11 15:56 ` Javier Martinez Canillas
2023-04-11 19:39 ` Pierre Asselin
2023-04-12 11:22 ` Javier Martinez Canillas
2023-04-17 7:34 ` Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 02/13] drm/format-helper: Comment on RGB888 byte order Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 03/13] drm/format-helper: Fix test-input format conversion Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 04/13] drm/format-helper: Store RGB565 in little-endian order Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 05/13] drm/format-helper: Type fixes in format-helper tests Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 06/13] drm/format-helper: Flip src/dst-format branches in blit helper Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888 Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 08/13] drm/format-helper: Add conversion from XRGB8888 to ARGB2101010 Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 09/13] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 10/13] drm/fh-helper: Split fbdev single-probe helper Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection Thomas Zimmermann
2023-01-03 21:18 ` Maíra Canal
2023-01-04 8:14 ` Thomas Zimmermann
2023-01-04 10:34 ` Maíra Canal
2023-05-12 13:20 ` Linus Walleij
2023-05-12 14:11 ` Thomas Zimmermann
2023-05-15 8:01 ` Linus Walleij
2023-05-15 8:17 ` Thomas Zimmermann
2023-05-15 8:59 ` Linus Walleij
2023-05-15 9:26 ` Thomas Zimmermann
2023-05-15 9:30 ` Linus Walleij [this message]
2023-05-15 8:16 ` Daniel Vetter
2023-05-15 8:42 ` Thomas Zimmermann
2023-05-14 12:10 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-05-26 12:22 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-01-02 11:29 ` [PATCH v3 12/13] drm/format-helper: Simplify drm_fb_build_fourcc_list() Thomas Zimmermann
2023-01-02 11:29 ` [PATCH v3 13/13] drm/format-helper: Remove unnecessary conversion helpers Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaE=v=eyazZ-scUX=SpOB9_CkVe5V9yK_GrSR=wWTt8NA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=mairacanal@riseup.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).