dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200
@ 2021-05-19 20:35 Corentin Labbe
  2021-05-19 20:35 ` [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port Corentin Labbe
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Corentin Labbe @ 2021-05-19 20:35 UTC (permalink / raw)
  To: airlied, daniel, linus.walleij, robh+dt, ulli.kroll
  Cc: devicetree, Corentin Labbe, linux-arm-kernel, dri-devel, linux-kernel

Converts display/faraday,tve200.txt to yaml.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
Changes since v1:
- added two subsequent patchs fixing issue found when converting
- fixed all issues reported by Rob Herring
 .../bindings/display/faraday,tve200.txt       | 54 ---------------
 .../bindings/display/faraday,tve200.yaml      | 68 +++++++++++++++++++
 2 files changed, 68 insertions(+), 54 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/faraday,tve200.txt
 create mode 100644 Documentation/devicetree/bindings/display/faraday,tve200.yaml

diff --git a/Documentation/devicetree/bindings/display/faraday,tve200.txt b/Documentation/devicetree/bindings/display/faraday,tve200.txt
deleted file mode 100644
index 82e3bc0b7485..000000000000
--- a/Documentation/devicetree/bindings/display/faraday,tve200.txt
+++ /dev/null
@@ -1,54 +0,0 @@
-* Faraday TV Encoder TVE200
-
-Required properties:
-
-- compatible: must be one of:
-	"faraday,tve200"
-	"cortina,gemini-tvc", "faraday,tve200"
-
-- reg: base address and size of the control registers block
-
-- interrupts: contains an interrupt specifier for the interrupt
-	line from the TVE200
-
-- clock-names: should contain "PCLK" for the clock line clocking the
-	silicon and "TVE" for the 27MHz clock to the video driver
-
-- clocks: contains phandle and clock specifier pairs for the entries
-	in the clock-names property. See
-	Documentation/devicetree/bindings/clock/clock-bindings.txt
-
-Optional properties:
-
-- resets: contains the reset line phandle for the block
-
-Required sub-nodes:
-
-- port: describes LCD panel signals, following the common binding
-	for video transmitter interfaces; see
-	Documentation/devicetree/bindings/media/video-interfaces.txt
-	This port should have the properties:
-	reg = <0>;
-	It should have one endpoint connected to a remote endpoint where
-	the display is connected.
-
-Example:
-
-display-controller@6a000000 {
-	#address-cells = <1>;
-	#size-cells = <0>;
-	compatible = "faraday,tve200";
-	reg = <0x6a000000 0x1000>;
-	interrupts = <13 IRQ_TYPE_EDGE_RISING>;
-	resets = <&syscon GEMINI_RESET_TVC>;
-	clocks = <&syscon GEMINI_CLK_GATE_TVC>,
-		 <&syscon GEMINI_CLK_TVC>;
-	clock-names = "PCLK", "TVE";
-
-	port@0 {
-		reg = <0>;
-		display_out: endpoint {
-			remote-endpoint = <&panel_in>;
-		};
-	};
-};
diff --git a/Documentation/devicetree/bindings/display/faraday,tve200.yaml b/Documentation/devicetree/bindings/display/faraday,tve200.yaml
new file mode 100644
index 000000000000..e2ee77767321
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/faraday,tve200.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/faraday,tve200.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Faraday TV Encoder TVE200
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+properties:
+  compatible:
+    oneOf:
+      - const: faraday,tve200
+      - items:
+          - const: cortina,gemini-tvc
+          - const: faraday,tve200
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    minItems: 1
+
+  clock-names:
+    items:
+      - const: PCLK
+      - const: TVE
+
+  clocks:
+    minItems: 2
+
+  resets:
+    minItems: 1
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clock-names
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/cortina,gemini-clock.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/reset/cortina,gemini-reset.h>
+    display-controller@6a000000 {
+      compatible = "faraday,tve200";
+      reg = <0x6a000000 0x1000>;
+      interrupts = <13 IRQ_TYPE_EDGE_RISING>;
+      resets = <&syscon GEMINI_RESET_TVC>;
+      clocks = <&syscon GEMINI_CLK_GATE_TVC>,
+               <&syscon GEMINI_CLK_TVC>;
+      clock-names = "PCLK", "TVE";
+
+      port {
+        display_out: endpoint {
+          remote-endpoint = <&panel_in>;
+        };
+      };
+    };
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port
  2021-05-19 20:35 [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Corentin Labbe
@ 2021-05-19 20:35 ` Corentin Labbe
  2021-05-21 23:55   ` Linus Walleij
  2021-05-19 20:35 ` [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display Corentin Labbe
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Corentin Labbe @ 2021-05-19 20:35 UTC (permalink / raw)
  To: airlied, daniel, linus.walleij, robh+dt, ulli.kroll
  Cc: devicetree, Corentin Labbe, linux-arm-kernel, dri-devel, linux-kernel

The address and reg adds no value to the port node, remove them.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/arm/boot/dts/gemini-dlink-dir-685.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-dlink-dir-685.dts b/arch/arm/boot/dts/gemini-dlink-dir-685.dts
index cc39289e99dd..2eeb142b5464 100644
--- a/arch/arm/boot/dts/gemini-dlink-dir-685.dts
+++ b/arch/arm/boot/dts/gemini-dlink-dir-685.dts
@@ -492,8 +492,7 @@ drive0: ide-port@0 {
 		display-controller@6a000000 {
 			status = "okay";
 
-			port@0 {
-				reg = <0>;
+			port {
 				display_out: endpoint {
 					remote-endpoint = <&panel_in>;
 				};
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display
  2021-05-19 20:35 [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Corentin Labbe
  2021-05-19 20:35 ` [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port Corentin Labbe
@ 2021-05-19 20:35 ` Corentin Labbe
  2021-05-21 23:55   ` Linus Walleij
  2021-05-21  2:00 ` [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Rob Herring
  2021-05-21 23:54 ` Linus Walleij
  3 siblings, 1 reply; 7+ messages in thread
From: Corentin Labbe @ 2021-05-19 20:35 UTC (permalink / raw)
  To: airlied, daniel, linus.walleij, robh+dt, ulli.kroll
  Cc: devicetree, Corentin Labbe, linux-arm-kernel, dri-devel, linux-kernel

dtb_check complains about #address-cells and #size-cells, so lets
remove them.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/arm/boot/dts/gemini.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/gemini.dtsi b/arch/arm/boot/dts/gemini.dtsi
index fa708f5d0c72..34961e5bc7b2 100644
--- a/arch/arm/boot/dts/gemini.dtsi
+++ b/arch/arm/boot/dts/gemini.dtsi
@@ -417,8 +417,6 @@ display-controller@6a000000 {
 			clock-names = "PCLK", "TVE";
 			pinctrl-names = "default";
 			pinctrl-0 = <&tvc_default_pins>;
-			#address-cells = <1>;
-			#size-cells = <0>;
 			status = "disabled";
 		};
 
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200
  2021-05-19 20:35 [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Corentin Labbe
  2021-05-19 20:35 ` [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port Corentin Labbe
  2021-05-19 20:35 ` [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display Corentin Labbe
@ 2021-05-21  2:00 ` Rob Herring
  2021-05-21 23:54 ` Linus Walleij
  3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-05-21  2:00 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: devicetree, airlied, ulli.kroll, linux-kernel, dri-devel,
	robh+dt, linux-arm-kernel

On Wed, 19 May 2021 20:35:45 +0000, Corentin Labbe wrote:
> Converts display/faraday,tve200.txt to yaml.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> Changes since v1:
> - added two subsequent patchs fixing issue found when converting
> - fixed all issues reported by Rob Herring
>  .../bindings/display/faraday,tve200.txt       | 54 ---------------
>  .../bindings/display/faraday,tve200.yaml      | 68 +++++++++++++++++++
>  2 files changed, 68 insertions(+), 54 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/faraday,tve200.txt
>  create mode 100644 Documentation/devicetree/bindings/display/faraday,tve200.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200
  2021-05-19 20:35 [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Corentin Labbe
                   ` (2 preceding siblings ...)
  2021-05-21  2:00 ` [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Rob Herring
@ 2021-05-21 23:54 ` Linus Walleij
  3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-05-21 23:54 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Dave Airlie, Hans Ulli Kroll, linux-kernel,
	open list:DRM PANEL DRIVERS, Rob Herring, Linux ARM

On Wed, May 19, 2021 at 10:35 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> Converts display/faraday,tve200.txt to yaml.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Patch applied to the DRM misc tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port
  2021-05-19 20:35 ` [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port Corentin Labbe
@ 2021-05-21 23:55   ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-05-21 23:55 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Dave Airlie, Hans Ulli Kroll, linux-kernel,
	open list:DRM PANEL DRIVERS, Rob Herring, Linux ARM

On Wed, May 19, 2021 at 10:35 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> The address and reg adds no value to the port node, remove them.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Patch applied to the Gemini tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display
  2021-05-19 20:35 ` [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display Corentin Labbe
@ 2021-05-21 23:55   ` Linus Walleij
  0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-05-21 23:55 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Dave Airlie, Hans Ulli Kroll, linux-kernel,
	open list:DRM PANEL DRIVERS, Rob Herring, Linux ARM

On Wed, May 19, 2021 at 10:35 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> dtb_check complains about #address-cells and #size-cells, so lets
> remove them.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Patch applied to the Gemini tree.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-21 23:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 20:35 [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Corentin Labbe
2021-05-19 20:35 ` [PATCH v2 2/3] ARM: dts: gemini-dlink-dir-685: Remove address from display port Corentin Labbe
2021-05-21 23:55   ` Linus Walleij
2021-05-19 20:35 ` [PATCH v2 3/3] ARM: dts: gemini: remove xxx-cells from display Corentin Labbe
2021-05-21 23:55   ` Linus Walleij
2021-05-21  2:00 ` [PATCH v2 1/3] dt-bindings: display: convert faraday,tve200 Rob Herring
2021-05-21 23:54 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).