From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6940C48BD1 for ; Thu, 10 Jun 2021 23:01:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D65E613E7 for ; Thu, 10 Jun 2021 23:01:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D65E613E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8D596EE0B; Thu, 10 Jun 2021 23:01:00 +0000 (UTC) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 554E86EE0B for ; Thu, 10 Jun 2021 23:00:59 +0000 (UTC) Received: by mail-lf1-x129.google.com with SMTP id r5so5716099lfr.5 for ; Thu, 10 Jun 2021 16:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=avbPEqXIY2sNVjl5X7sBVvA3GrXjDeMoVxyqEkFmSEU=; b=r2P9kw3MVyLuGU1b4OzqmdI+rT5Oy0s1Eb70dLTcJdyPTq9hj73OovKd6elCTdNNpP J00lJMB8A6P6G5o0DB17XpPz+onQC8dV8vHgSVDBins/pDoVCKEwH8YzkYwVEaxwXBUk bSKmHUQLsVps1VR2Esmx+JokInNNhhvfSZ5GX9X8E7uTt3e/3rnsYkl0gDV+oQnOyo5y bW/sNS8Eap/KVooPs8VpnJQb+QAHXhAuaQWwARyi2yFmGKgloE0LepaPUi3y027XDc30 ELzc+6WVHQ/zcqe7NMYnPJgJktsrTUlPwpNaIsNItk6FgltKG+r6PVZkPiKp3XGucNT0 ubpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=avbPEqXIY2sNVjl5X7sBVvA3GrXjDeMoVxyqEkFmSEU=; b=e6r7Ns0hdg0CdwGsfi72LT4ZI9yGkDmN5/ADx4SvkfDPJrTfUoKh+70YtXwRAo6YWW GXyvJABxPo1YHhWgLW+9Sdjd1iCwSzgq9OPhx/ptBZh2coMgR0SHZgQpZzphp8JvXh2z Lmq0ZKRVy5zEB40sZCYCay1oqcNqe24t9S0/o81nMlyN4MXwi+DS2YiDjeL98zxXh24R IE63UwBG8oJW3eGj39aWRb6hW5uVcF3Jd1LNBnZ0nZFhnilk/+L1ymUf3BChwM6qZ6uj FL7WvMWsuku7ZpJ/hdUt/b89Xi2BlaCVfX0pkqovajU3edwebtpnzgd2qIMO/8L+ZRGw S2tw== X-Gm-Message-State: AOAM5300lR9DQ+b1iwPVfcNplh2iN36Stno5c6e19Rhu9TppJ73kfQqk S77yWZmrYBXWPpn2ZqZIgm7PjgkYY4nDxiaa6GXLvhElacw= X-Google-Smtp-Source: ABdhPJwFTNpOCdk3cz45tByAH8DvkgJ8/oSZr/JZIKZY9uizCZsZ+4+A1V9CHeQgqn3W+93AZY7PoMWnHRpCRx/HcQ0= X-Received: by 2002:a19:8157:: with SMTP id c84mr679719lfd.529.1623366057737; Thu, 10 Jun 2021 16:00:57 -0700 (PDT) MIME-Version: 1.0 References: <20210610220527.366432-1-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Fri, 11 Jun 2021 01:00:46 +0200 Message-ID: Subject: Re: [PATCH v5] drm/panel: db7430: Add driver for Samsung DB7430 To: Doug Anderson Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Cercueil , Thierry Reding , Sam Ravnborg , dri-devel , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 11, 2021 at 12:42 AM Doug Anderson wrote: > On Thu, Jun 10, 2021 at 3:39 PM Linus Walleij wrote: > > #define mipi_dbi_command(dbi, cmd, seq...) \ > > ({ \ > > const u8 d[] = { seq }; \ > > mipi_dbi_command_stackbuf(dbi, cmd, d, ARRAY_SIZE(d)); \ > > }) > > > > I'll fix up the include and apply then we can think about > > what to do with mipi_dbi_command(). > > Are you sure that doesn't work? Isn't the return value of a macro the > last expression? In this case the return value of > mipi_dbi_command_stackbuf() should just flow through. w00t I didn't know that. And I like to think of the macro processor as essentially just inserting the content of the macro at the cursor. But arguably it *should* rather be fixed in this macro though? It is used in the same way in all other drivers as well. Yours, Linus Walleij