From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07344C4743D for ; Fri, 4 Jun 2021 21:44:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBC136138C for ; Fri, 4 Jun 2021 21:44:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBC136138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48E0E6F530; Fri, 4 Jun 2021 21:44:53 +0000 (UTC) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 910856F530 for ; Fri, 4 Jun 2021 21:44:52 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id a4so13342353ljq.9 for ; Fri, 04 Jun 2021 14:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GjsAN50ddWQm0VC6qlRfoB/dT6P+8ZqVwoy/BYE0lSw=; b=ZHc08C+7Ibj69IVBB82goPegus+bAv9YuQoOVi9q9e+hDWENTWGrYTASzVNJNr28ii Y7E/XifFGi5YsoiMtuln3nFJzi2+VJCSGQifDJJetuD0tsRwjsUij7KR3i4O/1s7/3zi NClVAgpjP25K3UUqeUWYveb0ihfXIfOH8FXpzYyYITm9evxiETFUQQyyz1+dWm+nDBF9 UGnPUZMzC41fMqye9lXdyLOk94SDBWRCYO2+bTTfW/RSjLuVtL3W3yZXtW3bi4ayGkTn oATemphAWOJ1r8/n4NB/XtZY3Udzt9Me9nva7gNm8ZzkEcvIV122BSG5Zrs89Wj4tWxA hrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GjsAN50ddWQm0VC6qlRfoB/dT6P+8ZqVwoy/BYE0lSw=; b=byb/QPYRcC1s/j14MyvAPtwpW3VXgoeXahES/EeSK6R4cvVoQA/RTydI9OZcavAUzl 2O7nbOV8aSE+e73mKfKJlwubarrEbgPz6jkDhqIHEIxDFR34b7XO7I9Zu7ElSchPvGqW 15Oe5DfXyKYdwXrskAY6G0mGPbwrGoOQcOVzj4nsiy5NmRDtoYy7LFY40kXwPF53/AK2 Z6sCsnrODG0ZWYPrv1PiXeSMZQEzf2RFb5RBbQNQktmF3hD4zINBfOxO+G4ytaA4ZaRe XqRHSUPRu6Ngre2xf+ZBMtziyAclLuso0BYPCwuNln1DX+fvDP7aMXrK3dn62CQ5XK8X uxzA== X-Gm-Message-State: AOAM5339uQuq5kZaczd+ijEvGLijWEHt9xKze/lffTE7Dnz8HAXQnAsq /muK9qJOVeJNWQ1bff0h+7M64Azvv6iyL/bewlGt7Q== X-Google-Smtp-Source: ABdhPJyTRsaaVHVr9ofHVNMandAQLLoQSDxGJmUjBgJVRYEe9VRABdJWRzIKKzECxAYGWrgvTi3XmPiP37aKMIkjmIU= X-Received: by 2002:a2e:889a:: with SMTP id k26mr4923550lji.438.1622843090808; Fri, 04 Jun 2021 14:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20210524131852.263883-1-maxime@cerno.tech> In-Reply-To: <20210524131852.263883-1-maxime@cerno.tech> From: Linus Walleij Date: Fri, 4 Jun 2021 23:44:39 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Tim Gover , Dave Stevenson , David Airlie , linux-kernel , "open list:DRM PANEL DRIVERS" , Hans Verkuil , Thomas Zimmermann , Daniel Vetter , Phil Elwell Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 24, 2021 at 3:19 PM Maxime Ripard wrote: > If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to > the err_unprepare_hsm label. That label will then call > pm_runtime_disable and put_device on the DDC device. > > We just retrieved the DDC device, so the latter is definitely justified. > However at that point we still haven't called pm_runtime_enable, so the > call to pm_runtime_disable is not supposed to be there. > > Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support") > Signed-off-by: Maxime Ripard Reviewed-by: Linus Walleij Yours, Linus Walleij