From: Emil Velikov <emil.l.velikov@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rob Clark <robclark@freedesktop.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH] drm: Detect no-op drmModeAtomicRequest and return early
Date: Tue, 28 Jul 2015 14:42:49 +0100 [thread overview]
Message-ID: <CACvgo50PdPiPKWJ4q3g_D_CYdrxQ5HmReU8EaVrdMrPR4v0OBQ@mail.gmail.com> (raw)
In-Reply-To: <1437483053-2752-1-git-send-email-chris@chris-wilson.co.uk>
On 21 July 2015 at 13:50, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> If the number of items to process in the request is zero, we can forgo
> duplicating, sorting the request and feeding it into the kernel and
> instead report success immediately. This prevents a NULL dereference of
> the sorted->items for the no-op request.
>
Why do you attempt a null/empty commit :P But seriously, nicely caught !
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-28 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 12:50 [PATCH] drm: Detect no-op drmModeAtomicRequest and return early Chris Wilson
2015-07-28 13:42 ` Emil Velikov [this message]
2015-07-28 17:10 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo50PdPiPKWJ4q3g_D_CYdrxQ5HmReU8EaVrdMrPR4v0OBQ@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robclark@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).