dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: libcamera-devel@lists.libcamera.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/fourcc: Add bayer formats and modifiers
Date: Thu, 28 May 2020 16:36:59 +0100	[thread overview]
Message-ID: <CACvgo50SNourym-gBG1s2UxiD4M96=rMfcd7_y=643BgveRhVg@mail.gmail.com> (raw)
In-Reply-To: <20200521235201.279642-1-niklas.soderlund@ragnatech.se>

Hi Niklas,

On Fri, 22 May 2020 at 07:56, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
>
> Bayer formats are used with cameras and contain green, red and blue
> components, with alternating lines of red and green, and blue and green
> pixels in different orders. For each block of 2x2 pixels there is one
> pixel with a red filter, two with a green filter, and one with a blue
> filter. The filters can be arranged in different patterns.
>
> Add DRM fourcc formats to describe the most common Bayer formats. Also
> add a modifiers to describe the custom packing layouts used by the Intel
> IPU3 and in the MIPI (Mobile Industry Processor Interface) CSI-2
> specification.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
> * Changes since v1
> - Rename the defines from DRM_FORMAT_SRGGB8 to DRM_FORMAT_BAYER_RGGB8.
> - Update the fourcc codes passed to fourcc_code() to avoid a conflict.
> - Add diagrams for all Bayer formats memory layout.
> - Update documentation.
> ---
>  include/uapi/drm/drm_fourcc.h | 205 ++++++++++++++++++++++++++++++++++
>  1 file changed, 205 insertions(+)
>
Where is the user for these new formats - be that kernel or userspace?
Did you forget to update the __drm_format_info() in
drivers/gpu/drm/drm_fourcc.c?

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-05-28 15:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 23:52 [PATCH v2] drm/fourcc: Add bayer formats and modifiers Niklas Söderlund
2020-05-25 10:31 ` Sakari Ailus
2020-07-02 21:51   ` Laurent Pinchart
2020-07-03  8:41     ` Neil Armstrong
2020-05-28 15:36 ` Emil Velikov [this message]
2020-07-02 21:57   ` [libcamera-devel] " Laurent Pinchart
2020-06-19 13:06 ` Tomasz Figa
2020-07-02 22:00   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACvgo50SNourym-gBG1s2UxiD4M96=rMfcd7_y=643BgveRhVg@mail.gmail.com' \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=libcamera-devel@lists.libcamera.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).