From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22575C433E0 for ; Fri, 5 Jun 2020 15:02:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E594320663 for ; Fri, 5 Jun 2020 15:02:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iOLKNilR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E594320663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FB846E929; Fri, 5 Jun 2020 15:02:20 +0000 (UTC) Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54B896E929 for ; Fri, 5 Jun 2020 15:02:19 +0000 (UTC) Received: by mail-ua1-x941.google.com with SMTP id b10so2236833uaf.0 for ; Fri, 05 Jun 2020 08:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ceWBNLxWuQhYrkktGQieEFGEV8NTc8EVrrjHEjb4bd4=; b=iOLKNilRGjTp9czkKTXjJ/qsJlNddN2wXsdc4MGcvk3qT2IlR59dHyXrJ7rQqYEx0Z ENbanqlTbYx1wBlNohfjiXbJpxdJTSun0E5e+vV7b63OZcx12K6xcckQsxPSvDqcZAvo Z09lkPb2zEY0kFkHfrRDJP4Khn6eB6VZhBSGIgTlVCkHhbfm7qWySUWx4l23Ant1uKj3 fUSdB5v8L2H9Vg+YisWSgSqBzSVQs7Jgc/X7xN34WvgozybJwOgMzFeI/et9+/neFOAA HPvltQudmO9oROQvnzeZAvxUv6iUqoIWOFqcBY1bRU97UPhlD2PoN1TUwtcxuPZ2deU5 pVUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ceWBNLxWuQhYrkktGQieEFGEV8NTc8EVrrjHEjb4bd4=; b=YtLhcS/tKMBTqZm64gn/ssQ19hRtJFWu/StWuzFRdzGrjHVNWL7AMT9WjGqE0SjyBD swLdx0nqfLbUaK/JakHZQObCXwaxJvk8SXIUY6uLxiSguuW45zKd5ZVNf25/nZvEbwr9 IaRLwJgQWW3UZYfF7e1uWzJigqzAqoIY0QE2r8JrFPpmYijX7Hr8M00WfkRp3v0oAKeq zxQ06xzNWr42e5lN2zMDTgVxmQ7rtfruLRaGCwYdMwPeakQ8qfk+9ctTVqwxbqmWRutk TU1D/UkyCvQjPcCDJ8X/vHTntGQwBCX4u+su7v68Y88kmZpo6suufF119xvGTMhIa0wH pl/A== X-Gm-Message-State: AOAM5301T8t05qqZW5LlnHImA8uTX3uWlvp37CMypvWlWZBEsZQJNbnF xpGMyVfRYyCBZpmu9xAHC+b0tj5fbwF6uHU1LCg= X-Google-Smtp-Source: ABdhPJwChvkFcp5hYobsJGhUThpO9nnKXF1mztiqFSX6H1W+YP9MFl1i0bY9dU/bJzDfZjjsHPmGxUuTCA5Oq/yMWQs= X-Received: by 2002:ab0:3055:: with SMTP id x21mr7791323ual.106.1591369337071; Fri, 05 Jun 2020 08:02:17 -0700 (PDT) MIME-Version: 1.0 References: <20200530031015.15492-1-laurent.pinchart@ideasonboard.com> <20200530031015.15492-21-laurent.pinchart@ideasonboard.com> In-Reply-To: <20200530031015.15492-21-laurent.pinchart@ideasonboard.com> From: Emil Velikov Date: Fri, 5 Jun 2020 15:58:53 +0100 Message-ID: Subject: Re: [PATCH v2 20/22] drm: mxsfb: Merge mxsfb_set_pixel_fmt() and mxsfb_set_bus_fmt() To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , ML dri-devel , NXP Linux Team , Sascha Hauer , Robert Chiras , leonard.crestez@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, With the previous disclaimer in mind, the series is: Reviewed-by: Emil Velikov There's a small suggestion inline, for future work. On Sat, 30 May 2020 at 04:11, Laurent Pinchart wrote: > switch (bus_format) { > case MEDIA_BUS_FMT_RGB565_1X16: > - reg |= CTRL_BUS_WIDTH_16; > + ctrl |= CTRL_BUS_WIDTH_16; > break; > case MEDIA_BUS_FMT_RGB666_1X18: > - reg |= CTRL_BUS_WIDTH_18; > + ctrl |= CTRL_BUS_WIDTH_18; > break; > case MEDIA_BUS_FMT_RGB888_1X24: > - reg |= CTRL_BUS_WIDTH_24; > + ctrl |= CTRL_BUS_WIDTH_24; > break; > default: > dev_err(drm->dev, "Unknown media bus format %d\n", bus_format); > break; Off the top of my head, the default case should be handled in the atomic_check() hook. That is, unless I'm missing something and one can change the bus format in between atomic_check() and atomic_enable(). Which would sound like a very odd thing to do. -Emil _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel