From: Emil Velikov <emil.l.velikov@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vgem: create a render node for vgem
Date: Mon, 29 Oct 2018 12:03:46 +0000 [thread overview]
Message-ID: <CACvgo51s7vzRkHeDP+F06jOuqQDO6sD9g7rBkDmtyFidn+stxQ@mail.gmail.com> (raw)
In-Reply-To: <20181026134036.GO21967@phenom.ffwll.local>
On Fri, 26 Oct 2018 at 14:40, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Fri, Oct 26, 2018 at 01:06:47PM +0100, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov@collabora.com>
> >
> > VGEM doesn't do anything modeset specific, so in a way exposing a
> > primary node is 'wrong'. At the same time, we extensively use if for
> > creating dumb buffers, fences, prime fd <> handle imports/exports.
> >
> > To the point that we explicitly annotate the vgem fence ioctls as
> > DRM_RENDER_ALLOW and have an IGT test which opens the render node.
> >
> > close(drm_open_driver_render(DRIVER_VGEM))
>
> Huh, I guess that test doesn't pass?
>
It does since the IGT code seems bonkers... Namely it silently falls
back to the primary/card node.
It seems to be for historical reasons... back in the days where render
nodes were still experimental and had to be explicitly enabled via
kernel arg.
I'll try and follow-up to address that.
> > Better late than never, let's flip the switch.
> >
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks. I'll give it a few more days for others to review/comment.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-10-29 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 12:06 [PATCH] drm/vgem: create a render node for vgem Emil Velikov
2018-10-26 13:40 ` Daniel Vetter
2018-10-26 14:40 ` Chris Wilson
2018-10-29 12:00 ` Emil Velikov
2018-10-29 12:08 ` Chris Wilson
2018-10-29 12:03 ` Emil Velikov [this message]
2018-10-29 13:51 ` Daniel Vetter
2018-10-26 15:55 ` kbuild test robot
2018-11-05 15:30 ` Chris Wilson
2018-11-05 15:35 ` Emil Velikov
2018-11-06 9:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo51s7vzRkHeDP+F06jOuqQDO6sD9g7rBkDmtyFidn+stxQ@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).