From: Emil Velikov <emil.l.velikov@gmail.com>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Baolin Wang <baolin.wang@linaro.org>,
Dave Airlie <airlied@linux.ie>,
Chunyan Zhang <zhang.lyra@gmail.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Orson Zhai <orsonzhai@gmail.com>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver
Date: Thu, 19 Mar 2020 18:06:02 +0000 [thread overview]
Message-ID: <CACvgo52_KT6O79PujodCPbkegP6LLwuVSFEoRdbarZ=y50B63A@mail.gmail.com> (raw)
In-Reply-To: <1584105767-11963-5-git-send-email-kevin3.tang@gmail.com>
Hey Kevin,
On Sun, 15 Mar 2020 at 23:19, Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem.
> It's support multi planes, scaler, rotation, PQ(Picture Quality) and more.
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang@linaro.org>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
> drivers/gpu/drm/sprd/Makefile | 5 +-
> drivers/gpu/drm/sprd/dpu/Makefile | 7 +
> drivers/gpu/drm/sprd/dpu/dpu_r2p0.c | 750 ++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/sprd/sprd_dpu.c | 501 ++++++++++++++++++++++++
> drivers/gpu/drm/sprd/sprd_dpu.h | 170 ++++++++
> drivers/gpu/drm/sprd/sprd_drm.c | 1 +
> drivers/gpu/drm/sprd/sprd_drm.h | 2 +
Seems like v5 (patch at least, I did not look at the rest) does not
address a handful of the feedback.
- Access registers via readl/writel, instead of current approach
- With ^^ you can drop the compiler workaround
- Checking for unsupported KMS properties (format, rotation, etc)
should happen in the XXX_check callbacks
- Remove always true checks, around the (rather moot) abstraction layer
For the future, please keep the revision/changelog within the
corresponding patch. This way reviewers can see, from the onset, what
is addressed.
Look at `git log -- drivers/gpu/drm` for examples.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-19 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 13:22 [PATCH RFC v5 0/6] Add Unisoc's drm kms module Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 1/6] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 2/6] drm/sprd: add Unisoc's drm kms master Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 3/6] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 4/6] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2020-03-19 18:06 ` Emil Velikov [this message]
2020-07-28 10:18 ` Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2020-03-13 13:22 ` [PATCH RFC v5 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACvgo52_KT6O79PujodCPbkegP6LLwuVSFEoRdbarZ=y50B63A@mail.gmail.com' \
--to=emil.l.velikov@gmail.com \
--cc=airlied@linux.ie \
--cc=baolin.wang@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).