From: Doug Anderson <dianders@chromium.org>
To: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Clark <robdclark@chromium.org>,
David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] drm: panel: simple: Allow timing constraints, not fixed delays
Date: Thu, 5 Nov 2020 13:54:31 -0800 [thread overview]
Message-ID: <CAD=FV=U7PvC5nL3EudxE62MSHeha+zd1u_hCxYyCw8t5SaWUkQ@mail.gmail.com> (raw)
In-Reply-To: <20201028155617.v2.1.I31c4f8b111dbef1ab658f206764655ae983bc560@changeid>
Hi,
On Wed, Oct 28, 2020 at 3:58 PM Douglas Anderson <dianders@chromium.org> wrote:
> @@ -249,18 +327,19 @@ static int panel_simple_unprepare(struct drm_panel *panel)
> {
> struct panel_simple *p = to_panel_simple(panel);
>
> - if (!p->prepared)
> + if (p->prepared_time != 0)
Though I swear I tested this, clearly I didn't test well enough. I
was poking with this patch series some more and realized that I got
the above (and the one in _prepare) totally and utterly backwards.
I'll send out a v3 now...
-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-11-05 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 22:58 [PATCH v2 1/3] drm: panel: simple: Allow timing constraints, not fixed delays Douglas Anderson
2020-10-28 22:58 ` [PATCH v2 2/3] drm: panel: simple: Add BOE NV110WTM-N61 Douglas Anderson
2020-10-28 22:58 ` [PATCH v2 3/3] dt-bindings: dt-bindings: display: " Douglas Anderson
2020-11-02 15:31 ` Rob Herring
2020-11-05 21:54 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=U7PvC5nL3EudxE62MSHeha+zd1u_hCxYyCw8t5SaWUkQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).