From: Doug Anderson <dianders@chromium.org>
To: Rajeev Nandan <rajeevny@codeaurora.org>
Cc: Rob Clark <robdclark@chromium.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>,
Steev Klimaszewski <steev@kali.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Stephen Boyd <swboyd@chromium.org>,
Thierry Reding <treding@nvidia.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC
Date: Mon, 7 Jun 2021 10:07:01 -0700 [thread overview]
Message-ID: <CAD=FV=UEUsP4qRB-zj31ykS2UznnY=6WF2pD26=FDnVZy6rxCg@mail.gmail.com> (raw)
In-Reply-To: <6e0cd667a8a776e524b42f1535827208@codeaurora.org>
Hi,
On Fri, Jun 4, 2021 at 9:10 AM <rajeevny@codeaurora.org> wrote:
>
> Hi Doug,
>
> > panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd");
> > if (!panel->no_hpd) {
> > @@ -708,6 +712,8 @@ static int panel_simple_probe(struct device *dev,
> > const struct panel_desc *desc)
> >
> > if (!panel->ddc)
> > return -EPROBE_DEFER;
> > + } else if (aux) {
> > + panel->ddc = &aux->ddc;
> > }
>
> In panel_simple_probe(), the put_device(&panel->ddc->dev) call is
> causing issue when the aux->ddc is used to assign panel->ddc
> It works well when "ddc-i2c-bus" is used to assign panel->ddc
>
> static int panel_simple_probe(...)
> {
> ...
>
> free_ddc:
> if (panel->ddc)
> put_device(&panel->ddc->dev);
>
> return err;
> }
Thanks for catching! Fixed in v9.
-Doug
next prev parent reply other threads:[~2021-06-07 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 0:01 [PATCH v8 00/11] drm: Fix EDID reading on ti-sn65dsi86 by introducing the DP AUX bus Douglas Anderson
2021-05-25 0:01 ` [PATCH v8 01/11] dt-bindings: display: simple: List hpd properties in panel-simple Douglas Anderson
2021-06-02 18:00 ` Rob Herring
2021-05-25 0:01 ` [PATCH v8 02/11] dt-bindings: drm: Introduce the DP AUX bus Douglas Anderson
2021-06-02 18:08 ` Rob Herring
2021-05-25 0:01 ` [PATCH v8 03/11] dt-bindings: drm/bridge: ti-sn65dsi86: Add aux-bus child Douglas Anderson
2021-05-28 0:29 ` Linus Walleij
2021-06-02 18:06 ` Rob Herring
2021-06-02 18:09 ` Rob Herring
2021-06-02 18:10 ` Rob Herring
2021-05-25 0:01 ` [PATCH v8 04/11] dt-bindings: drm/aux-bus: Add an example Douglas Anderson
2021-05-28 0:31 ` Linus Walleij
2021-06-02 18:16 ` Rob Herring
2021-06-02 19:55 ` Doug Anderson
2021-05-25 0:01 ` [PATCH v8 05/11] drm: Introduce the DP AUX bus Douglas Anderson
2021-05-25 0:01 ` [PATCH v8 06/11] drm/panel: panel-simple: Allow panel-simple be a DP AUX endpoint device Douglas Anderson
2021-05-25 0:01 ` [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC Douglas Anderson
2021-06-04 16:10 ` rajeevny
2021-06-07 17:07 ` Doug Anderson [this message]
2021-05-25 0:01 ` [PATCH v8 08/11] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev Douglas Anderson
2021-06-06 4:40 ` Bjorn Andersson
2021-06-07 17:07 ` Doug Anderson
2021-05-25 0:01 ` [PATCH v8 09/11] drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus Douglas Anderson
2021-05-25 0:01 ` [PATCH v8 10/11] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC Douglas Anderson
2021-05-25 0:01 ` [PATCH v8 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UEUsP4qRB-zj31ykS2UznnY=6WF2pD26=FDnVZy6rxCg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonas@kwiboo.se \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=rajeevny@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=sam@ravnborg.org \
--cc=stanislav.lisovskiy@intel.com \
--cc=steev@kali.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).