From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5A2C47094 for ; Mon, 7 Jun 2021 17:07:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DDF360FE4 for ; Mon, 7 Jun 2021 17:07:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DDF360FE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4DE96E955; Mon, 7 Jun 2021 17:07:15 +0000 (UTC) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by gabe.freedesktop.org (Postfix) with ESMTPS id A54EE6E955 for ; Mon, 7 Jun 2021 17:07:14 +0000 (UTC) Received: by mail-qv1-xf36.google.com with SMTP id q6so9253643qvb.2 for ; Mon, 07 Jun 2021 10:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RmeYQ/ZjjCaIyjItMjlP85jvXRjCl3Zk4JkEtkJYSBY=; b=oISc4cU4YTQkjp0n9pgdr1lbPZXsWrFmqBytfBGf/VTDke+AUi5NgsMmgMWBNX7pOi yz01vx6nHE34B+5QvYaAy5AIp1leR3my8AuccPTtPbCsKKS/0rgd+vFejAGV+pC2337M Hyu649c0Y6FMGVBtvNZni1VLAGOPfx5AL2Blg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RmeYQ/ZjjCaIyjItMjlP85jvXRjCl3Zk4JkEtkJYSBY=; b=peMICHYGcAB0Rn05HHOOLiLL1QIQAfPX1bkZCJCtmxeitKcIQEQwX+wsLHAEuI27uT 75ahbfN+p6ZEpRcYAZWorwuckNW7UFX7HtRlpx6OjmuPyK7Q1Un+HyMYMZE5+Wx402US 3qbNPIIn4cHWsCW3+87OCkqpNdnfqT/vYIobmMGbx7rVru1keCpF2xbV0lNeeWEdZNSU enSpkigkY0q0H1EEmGegyL12M4ZWLyYeyRBpLM9LVhEy+QwSz18iAETaD8a1/oGix6a+ w1bE/BGocHuHlLJPy4FaUYopQuEmXLUK5nb1pRRAseHEE1YP+YzzZuR13QadjpDXJLiS iymg== X-Gm-Message-State: AOAM532rrHcMARnSZPYkodnsUnhEaBcSADZ9J5q9L7C4bAJVvKdpSiCm WdejFnEhWcZgMXvo9jkfdSK85Jr7Q2XDLQ== X-Google-Smtp-Source: ABdhPJwrgU2jxu3b64eaDX5+5KVRDQDUHGU0XkAeNAGU8Ur8602D8VnHqIPpeVM5vyIz/j9onzcdLA== X-Received: by 2002:ad4:4783:: with SMTP id z3mr18804637qvy.43.1623085633834; Mon, 07 Jun 2021 10:07:13 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id d6sm10304199qkf.109.2021.06.07.10.07.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 10:07:13 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id g142so6677657ybf.9 for ; Mon, 07 Jun 2021 10:07:13 -0700 (PDT) X-Received: by 2002:a25:8082:: with SMTP id n2mr25004184ybk.79.1623085632738; Mon, 07 Jun 2021 10:07:12 -0700 (PDT) MIME-Version: 1.0 References: <20210525000159.3384921-1-dianders@chromium.org> <20210524165920.v8.7.I18e60221f6d048d14d6c50a770b15f356fa75092@changeid> <6e0cd667a8a776e524b42f1535827208@codeaurora.org> In-Reply-To: <6e0cd667a8a776e524b42f1535827208@codeaurora.org> From: Doug Anderson Date: Mon, 7 Jun 2021 10:07:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 07/11] drm/panel: panel-simple: Stash DP AUX bus; allow using it for DDC To: Rajeev Nandan Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , dri-devel , Jonas Karlman , David Airlie , linux-arm-msm , Neil Armstrong , LKML , Steev Klimaszewski , Bjorn Andersson , Stanislav Lisovskiy , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Stephen Boyd , Thierry Reding , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Fri, Jun 4, 2021 at 9:10 AM wrote: > > Hi Doug, > > > panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd"); > > if (!panel->no_hpd) { > > @@ -708,6 +712,8 @@ static int panel_simple_probe(struct device *dev, > > const struct panel_desc *desc) > > > > if (!panel->ddc) > > return -EPROBE_DEFER; > > + } else if (aux) { > > + panel->ddc = &aux->ddc; > > } > > In panel_simple_probe(), the put_device(&panel->ddc->dev) call is > causing issue when the aux->ddc is used to assign panel->ddc > It works well when "ddc-i2c-bus" is used to assign panel->ddc > > static int panel_simple_probe(...) > { > ... > > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > > return err; > } Thanks for catching! Fixed in v9. -Doug