From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF86C4320A for ; Thu, 26 Aug 2021 17:17:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0146561038 for ; Thu, 26 Aug 2021 17:17:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0146561038 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 592716E02E; Thu, 26 Aug 2021 17:17:30 +0000 (UTC) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 033676E02E for ; Thu, 26 Aug 2021 17:17:29 +0000 (UTC) Received: by mail-io1-xd2b.google.com with SMTP id b7so4707398iob.4 for ; Thu, 26 Aug 2021 10:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BME6ZBn7IF/dZ4lqKBb5Rr0F3dMtEA2Sl2OiBXFFq94=; b=gnEZYksnbRTTHZAxgGoJLyFZAgueU3IxMhBMrAjtiS1hR3svlzjSi3DDhnVSjnZhtI tWMYx9POOkRLFKf55pXAdfDojo+CPA5QHu/0vXsT/g2wEZ2lYT4231uzDgbRaCRZ54A0 6T8e2cTYL9cpffZv/sh82qCfit8qrU/ndg/ad4lEjvrppvJxRHitA8ugmufCHfrrZohD myJwlh3BPHP1ySTXC1DeFVwagIHrju/0SzNukCspCp9jS/i9UEYZJTTjE/4wQeqP11QS 6oBwAX8/A7fjXbFW+y1Tbt1seeFovtyaSj5ssn4u73enZ3G3R+pFMHIN4ww1v3XZz4Rp T/BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BME6ZBn7IF/dZ4lqKBb5Rr0F3dMtEA2Sl2OiBXFFq94=; b=PlI78Y4EoDowWus589fHPzmfF4avz4+TweRSUrL1+aQZHPzoFukV3WnwVBXnsDRaPh 6Gk2Xx9QzSjG6njQ3qTHSTg8QclCCs6EFrH/ab838uEcoS5Xl585nY9Dpvif436faxue a3Vcfuu1EOFXhS4OGMTv3DkK7OhTWGn7v3me3v4HEiLkjRMNFYh/gPa2o4JgJzuMPaRY wtttRd2bSCMrsP7flMEOPan7AaBDy34PsdwGbSJMzWzlZ70lX7IVlf5yMUUkNs62gYkA prIRB6BL8KQp/OkxKqWnxdNFar240OIzg3YZggknBHYaSONJcgtMgYy66etppEaaQPcA fluA== X-Gm-Message-State: AOAM531wpjETrCuxh5iZ7WFhh/RRwGja81oL7vQH6W+KWpZ6KHPYDv16 Z3x/iejFPTnA0HJySsSf7s7xUB4qlzXM24qRCZaCLg== X-Google-Smtp-Source: ABdhPJxx0itgPizsz4hgdmhvsrxgzP9yB3BK2vfWMyhyRrpAwZAUYwfW4FBYXcd4HZTZkXgzxhNR371WnGrNUCpneLA= X-Received: by 2002:a5d:8acf:: with SMTP id e15mr3853495iot.184.1629998247904; Thu, 26 Aug 2021 10:17:27 -0700 (PDT) MIME-Version: 1.0 References: <20210824014124.1080798-1-yangcong5@huaqin.corp-partner.google.com> In-Reply-To: <20210824014124.1080798-1-yangcong5@huaqin.corp-partner.google.com> From: Doug Anderson Date: Thu, 26 Aug 2021 10:17:15 -0700 Message-ID: Subject: Re: [v2 0/2] Add driver for BOE tv110c9m-ll3 panel To: yangcong Cc: Sam Ravnborg , David Airlie , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dri-devel , LKML , Thierry Reding Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Mon, Aug 23, 2021 at 6:41 PM yangcong wrote: > > Hi Sam, > This driver support boe tv1110c9m-ll3 and inx hj110iz-01a panel.The IC chip is used NT36523, which is a new IC. > > 1: panel-boe-tv101wum-nl6.c driver cannot meet the timing requirements of the current two panel. > > 2: The screen cannot be work in HS mode, panel-boe-tv101wum-nl6.c will switch to HS mode when boe_panel_enter_sleep_mode. > > static int boe_panel_enter_sleep_mode(struct boe_panel *boe) > { > struct mipi_dsi_device *dsi = boe->dsi; > int ret; > > dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; > ... > ... > } It's really up to Sam how he wants to proceed here, but certainly you could support things with the existing driver even if there are differences. In general you can add more things to the `struct panel_desc` in the driver and then make them different for your panel. Look, for instance, at `discharge_on_disable`. Not all panels supported by this driver do that, so you could support your "cannot work in HS mode" in a similar way. For the timings, you could also add another bit to the `struct panel_desc` to select a different delay for your panel or (if it's just a small delay) you could just increase it across the board. I guess you need a 10 ms delay instead of a 5 ms delay in probe? I'd just make it 10 ms across the board and call it done. Similarly looks like something needs .5 ms => 1 ms. Again, this is likely fine across the board for all panels. Unless Sam comes back and says "no, wait, keep it two drivers!" then I'd suggest that you post a new version that works as Sam suggests. In the worst case if having it combined into one driver looks too ugly then we can always go back to a split driver. -Doug