From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 080ABC04A68 for ; Fri, 29 Jul 2022 00:29:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D1A211BEE9; Fri, 29 Jul 2022 00:29:25 +0000 (UTC) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54FE011BF03 for ; Fri, 29 Jul 2022 00:29:23 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id l23so5816076ejr.5 for ; Thu, 28 Jul 2022 17:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=YbqiOPzZmbvFzZa130GwJGGGwEXthWuw9oeJXPqxLMw=; b=kRjkFi56KoI/XZGvwlf6yOjdbiP1tOmPWovRkV0lQ9r/9z+zKKFuNvzZ526mN8SbkY 2TdEpBoXlMQ+lVoNCpoWhAPvoC8JWZChWscjFpUjaHrW9+uuQyrM093O5JJ2ch0W3yhw 53t5JnC3EDdl/YBCZLn7vwtZGg7twxgkwE0VE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YbqiOPzZmbvFzZa130GwJGGGwEXthWuw9oeJXPqxLMw=; b=3Jccw2rxBS3Gi1e2bjQVxwmR5bwraacXOhDCXIvgIZaqZj2UnZTQI/c5rCBJ6NZkR1 /Z7YZfuNz/mvfuOiYw0ukd7H5q/AGsnqMoVHJWsNHsPxiHo3Gy63pCLzNHDz0KaTYcP6 mfVxkUWdHH2FPL+GJATCemJKqXxugwmjvRvpEhtu/PSjFQXi1Wg6ADYTXXL5nXr+H32w I959adNY+usRCHsDF2twRs2GGLJKQCiL1PkUMLFW6CZwTzfoc9KS4cfrTN5kr8MGW80c 48NvFKyAKYchKcLbJKD7NtFbwjdcvl31g0iqvEqqph+uVATZflMHkDu8Lr4mbYZBIzDx sn0Q== X-Gm-Message-State: AJIora/+MeePT9LUYXyLar7Mnore4M5Od5bltXGxCA+MeUKKxAJpdYvm cIeiuOsA8CSHLdbcNTRdMJdjQFBcTE/t4rZ61bY= X-Google-Smtp-Source: AGRyM1t5r/BKsZ5gEoaZg4O7uAKxBXxHfwa5Y3mPtWX+2uSfdomy/Yo/O1VlzT251gJxx0LjWBvTjw== X-Received: by 2002:a17:907:16a6:b0:72b:5ce6:1f7d with SMTP id hc38-20020a17090716a600b0072b5ce61f7dmr1056626ejc.28.1659054561361; Thu, 28 Jul 2022 17:29:21 -0700 (PDT) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com. [209.85.221.51]) by smtp.gmail.com with ESMTPSA id b21-20020a170906195500b0072faba59dd1sm963661eje.165.2022.07.28.17.29.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 17:29:21 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id i8so4164925wro.11 for ; Thu, 28 Jul 2022 17:29:21 -0700 (PDT) X-Received: by 2002:adf:fb12:0:b0:20c:79b2:a200 with SMTP id c18-20020adffb12000000b0020c79b2a200mr744258wrr.617.1659054151464; Thu, 28 Jul 2022 17:22:31 -0700 (PDT) MIME-Version: 1.0 References: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com> In-Reply-To: <1657544224-10680-1-git-send-email-quic_vpolimer@quicinc.com> From: Doug Anderson Date: Thu, 28 Jul 2022 17:22:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 00/10] Add PSR support for eDP To: Vinod Polimera Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sankeerth Billakanti , "Abhinav Kumar \(QUIC\)" , quic_vproddut , linux-arm-msm , LKML , dri-devel , Stephen Boyd , Bjorn Andersson , Dmitry Baryshkov , "Aravind Venkateswaran \(QUIC\)" , "Kuogee Hsieh \(QUIC\)" , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Mon, Jul 11, 2022 at 5:57 AM Vinod Polimera wrote: > > Changes in v2: > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > - Don't modify whitespaces. > - Set self refresh aware from atomic_check. > - Set self refresh aware only if psr is supported. > - Provide a stub for msm_dp_display_set_psr. > - Move dp functions to bridge code. > > Changes in v3: > - Change callback names to reflect atomic interfaces. > - Move bridge callback change to separate patch as suggested by Dmitry. > - Remove psr function declaration from msm_drv.h. > - Set self_refresh_aware flag only if psr is supported. > - Modify the variable names to simpler form. > - Define bit fields for PSR settings. > - Add comments explaining the steps to enter/exit psr. > - Change DRM_INFO to drm_dbg_db. > > Changes in v4: > - Move the get crtc functions to drm_atomic. > - Add atomic functions for DP bridge too. > - Add ternary operator to choose eDP or DP ops. > - Return true/false instead of 1/0. > - mode_valid missing in the eDP bridge ops. > - Move the functions to get crtc into drm_atomic.c. > - Fix compilation issues. > - Remove dpu_assign_crtc and get crtc from drm_enc instead of dpu_enc. > - Check for crtc state enable while reserving resources. > > Changes in v5: > - Move the mode_valid changes into a different patch. > - Complete psr_op_comp only when isr is set. > - Move the DP atomic callback changes to a different patch. > - Get crtc from drm connector state crtc. > - Move to separate patch for check for crtc state enable while > reserving resources. > > Changes in v6: > - Remove crtc from dpu_encoder_virt struct. > - fix crtc check during vblank toggle crtc. > - Misc changes. > > Signed-off-by: Sankeerth Billakanti > Signed-off-by: Kalyan Thota > Signed-off-by: Vinod Polimera > > Vinod Polimera (10): > drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector > state instead of dpu_enc > drm: add helper functions to retrieve old and new crtc > drm/msm/dp: use atomic callbacks for DP bridge ops > drm/msm/dp: Add basic PSR support for eDP > drm/msm/dp: use the eDP bridge ops to validate eDP modes > drm/bridge: use atomic enable/disable callbacks for panel bridge > drm/bridge: add psr support for panel bridge callbacks > drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder > functions > drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver > drm/msm/disp/dpu: check for crtc enable rather than crtc active to > release shared resources > > drivers/gpu/drm/bridge/panel.c | 68 ++++++++-- > drivers/gpu/drm/drm_atomic.c | 60 +++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 56 +++++---- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 -- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- > drivers/gpu/drm/msm/dp/dp_catalog.c | 81 ++++++++++++ > drivers/gpu/drm/msm/dp/dp_catalog.h | 4 + > drivers/gpu/drm/msm/dp/dp_ctrl.c | 73 +++++++++++ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 + > drivers/gpu/drm/msm/dp/dp_display.c | 31 +++-- > drivers/gpu/drm/msm/dp/dp_display.h | 2 + > drivers/gpu/drm/msm/dp/dp_drm.c | 184 ++++++++++++++++++++++++++-- > drivers/gpu/drm/msm/dp/dp_drm.h | 9 +- > drivers/gpu/drm/msm/dp/dp_link.c | 36 ++++++ > drivers/gpu/drm/msm/dp/dp_panel.c | 22 ++++ > drivers/gpu/drm/msm/dp/dp_panel.h | 6 + > drivers/gpu/drm/msm/dp/dp_reg.h | 27 ++++ > include/drm/drm_atomic.h | 7 ++ > 19 files changed, 631 insertions(+), 65 deletions(-) I spent some time looking at the first few patches. I can try to look at more later this week, though (as you've noticed) many of my reviews are more nit-picks because I don't really have experience with PSR and my overall knowledge of the Qualcomm DP driver is pretty weak. I tried to at least pick to give a Tested-by, but when I did that it didn't work flawlessly. I picked this series to the chromeos-5.15 tree, which is pretty close to mainline right now. I left it sitting at a screen with a blinking cursor which pretty much means it's always transitioning into and out of PSR. I've seen several glitches on the screen with the series applied. :( No idea what's wrong--that's just me black-box testing. I did try to add debug printouts to see if we were hitting "PSR_UPDATE_ERROR_INT | PSR_WAKE_ERROR_INT" but I didn't see my printouts... FWIW: I'm running with KASAN enabled which could affect timings... Glitches happen every few minutes or so for me and so far I haven't see any glitches without KASAN, but that could just be chance... -Doug