From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E3FC47254 for ; Tue, 5 May 2020 22:27:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F8932064A for ; Tue, 5 May 2020 22:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE/K4RGC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F8932064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0EB136E0B8; Tue, 5 May 2020 22:27:55 +0000 (UTC) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2033B6E0B8 for ; Tue, 5 May 2020 22:27:54 +0000 (UTC) Received: by mail-qk1-x72b.google.com with SMTP id t3so34182qkg.1 for ; Tue, 05 May 2020 15:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lnXVcC4PmkkaSlygdgSA58xD9NRnNWBO39vWxCfGzbo=; b=aE/K4RGCwL5H8pGJiV/vdQLvVaJd9tXpnqvrytbKm6od9bvlfy0siwTVw2G2gAkcMA uO3RZAk+bNNenRLYNiW2Jej3t/+oZ7b80undk7JNleUvpaSGcciLBDWp+IQrSI/emWjW Y7/hn/eopBxIWfGIF7HgcYXyEboo8UR1BLcL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lnXVcC4PmkkaSlygdgSA58xD9NRnNWBO39vWxCfGzbo=; b=QucN9jYAwZuRAy1Qsen0WNZ1N0ZZAQOcTBvJC2V36ImTduu+6pBzDAzkfdHoFGKT7t sIeZvZau3C6rUPUxGLl/oSb/Xvx4RY2b3/vYox+ogkZBVve1Ti0d0d7or14LV7ATpxk+ OXEooERZ9ZZkOS1c/yQVmXVHJ36lDNVCVWC08f0Rd+UAKY/JR2CV0+UxgVgqALfSjMJJ QYHPC0VWGtjrwQT38NvYmkVW2M7QCUGdAzxkcC2ZBKpk3eIt2tpsWay4bcMPB/w8bf4o mGVsrdICcD++n660uRBO0RCAkIVCRMxtGKqOH8EVi5HnhxvXlwtGBPlTYdVsgAueMxIz bJlw== X-Gm-Message-State: AGi0PubxVm9fB8ZnP0Qy3E+8og3SbePvg2zecgzXKuY5MZ1QTCzDV6f8 B0Y+/D8nzuY1PgwQuVvrRJvUQa2JBGQ= X-Google-Smtp-Source: APiQypLSfjwjAlu/7RmILz6rVSNUlO04ROuB0rV28QopyrdEyVS8+cfCb2SGHh+4kvgODFtcUKAs8A== X-Received: by 2002:a37:a7d6:: with SMTP id q205mr2808212qke.85.1588717672685; Tue, 05 May 2020 15:27:52 -0700 (PDT) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id s15sm3122084qtc.31.2020.05.05.15.27.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2020 15:27:52 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id a8so121316ybs.3 for ; Tue, 05 May 2020 15:27:52 -0700 (PDT) X-Received: by 2002:ab0:375a:: with SMTP id i26mr4534579uat.120.1588717280132; Tue, 05 May 2020 15:21:20 -0700 (PDT) MIME-Version: 1.0 References: <20200430194617.197510-1-dianders@chromium.org> <20200430124442.v4.4.Ifcdc4ecb12742a27862744ee1e8753cb95a38a7f@changeid> <20200505213450.GA8640@pendragon.ideasonboard.com> In-Reply-To: <20200505213450.GA8640@pendragon.ideasonboard.com> From: Doug Anderson Date: Tue, 5 May 2020 15:21:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/6] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml To: Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jernej Skrabec , Neil Armstrong , David Airlie , linux-arm-msm , Jonas Karlman , Jeffrey Hugo , Sandeep Panda , dri-devel , Bjorn Andersson , Andrzej Hajda , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , "open list:GPIO SUBSYSTEM" , Paul Walmsley , Stephen Boyd , LKML Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Laurent, On Tue, May 5, 2020 at 2:35 PM Laurent Pinchart wrote: > > Hi Doug, > > Thank you for the patch. > > On Thu, Apr 30, 2020 at 12:46:15PM -0700, Douglas Anderson wrote: > > This moves the bindings over, based a lot on toshiba,tc358768.yaml. > > Unless there's someone known to be better, I've set the maintainer in > > the yaml as the first person to submit bindings. > > > > Signed-off-by: Douglas Anderson > > Reviewed-by: Stephen Boyd > > --- > > > > Changes in v4: None > > Changes in v3: None > > Changes in v2: > > - specification => specifier. > > - power up => power. > > - Added back missing suspend-gpios. > > - data-lanes and lane-polarities are are the right place now. > > - endpoints don't need to be patternProperties. > > - Specified more details for data-lanes and lane-polarities. > > - Added old example back in, fixing bugs in it. > > - Example i2c bus is just called "i2c", not "i2c1" now. > > > > .../bindings/display/bridge/ti,sn65dsi86.txt | 87 ------ > > .../bindings/display/bridge/ti,sn65dsi86.yaml | 279 ++++++++++++++++++ > > 2 files changed, 279 insertions(+), 87 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > deleted file mode 100644 > > index 8ec4a7f2623a..000000000000 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt > > +++ /dev/null > > @@ -1,87 +0,0 @@ > > -SN65DSI86 DSI to eDP bridge chip > > --------------------------------- > > - > > -This is the binding for Texas Instruments SN65DSI86 bridge. > > -http://www.ti.com/general/docs/lit/getliterature.tsp?genericPartNumber=sn65dsi86&fileType=pdf > > - > > -Required properties: > > -- compatible: Must be "ti,sn65dsi86" > > -- reg: i2c address of the chip, 0x2d as per datasheet > > -- enable-gpios: gpio specification for bridge_en pin (active high) > > - > > -- vccio-supply: A 1.8V supply that powers up the digital IOs. > > -- vpll-supply: A 1.8V supply that powers up the displayport PLL. > > -- vcca-supply: A 1.2V supply that powers up the analog circuits. > > -- vcc-supply: A 1.2V supply that powers up the digital core. > > - > > -Optional properties: > > -- interrupts-extended: Specifier for the SN65DSI86 interrupt line. > > - > > -- gpio-controller: Marks the device has a GPIO controller. > > -- #gpio-cells : Should be two. The first cell is the pin number and > > - the second cell is used to specify flags. > > - See ../../gpio/gpio.txt for more information. > > -- #pwm-cells : Should be one. See ../../pwm/pwm.yaml for description of > > - the cell formats. > > - > > -- clock-names: should be "refclk" > > -- clocks: Specification for input reference clock. The reference > > - clock rate must be 12 MHz, 19.2 MHz, 26 MHz, 27 MHz or 38.4 MHz. > > - > > -- data-lanes: See ../../media/video-interface.txt > > -- lane-polarities: See ../../media/video-interface.txt > > - > > -- suspend-gpios: specification for GPIO1 pin on bridge (active low) > > - > > -Required nodes: > > -This device has two video ports. Their connections are modelled using the > > -OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > - > > -- Video port 0 for DSI input > > -- Video port 1 for eDP output > > - > > -Example > > -------- > > - > > -edp-bridge@2d { > > - compatible = "ti,sn65dsi86"; > > - #address-cells = <1>; > > - #size-cells = <0>; > > - reg = <0x2d>; > > - > > - enable-gpios = <&msmgpio 33 GPIO_ACTIVE_HIGH>; > > - suspend-gpios = <&msmgpio 34 GPIO_ACTIVE_LOW>; > > - > > - interrupts-extended = <&gpio3 4 IRQ_TYPE_EDGE_FALLING>; > > - > > - vccio-supply = <&pm8916_l17>; > > - vcca-supply = <&pm8916_l6>; > > - vpll-supply = <&pm8916_l17>; > > - vcc-supply = <&pm8916_l6>; > > - > > - clock-names = "refclk"; > > - clocks = <&input_refclk>; > > - > > - ports { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - port@0 { > > - reg = <0>; > > - > > - edp_bridge_in: endpoint { > > - remote-endpoint = <&dsi_out>; > > - }; > > - }; > > - > > - port@1 { > > - reg = <1>; > > - > > - edp_bridge_out: endpoint { > > - data-lanes = <2 1 3 0>; > > - lane-polarities = <0 1 0 1>; > > - remote-endpoint = <&edp_panel_in>; > > - }; > > - }; > > - }; > > -} > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > new file mode 100644 > > index 000000000000..6d7d40ad45ac > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > > @@ -0,0 +1,279 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi86.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SN65DSI86 DSI to eDP bridge chip > > + > > +maintainers: > > + - Sandeep Panda > > + > > +description: | > > + The Texas Instruments SN65DSI86 bridge takes MIPI DSI in and outputs eDP. > > + http://www.ti.com/general/docs/lit/getliterature.tsp?genericPartNumber=sn65dsi86&fileType=pdf > > + > > +properties: > > + compatible: > > + const: ti,sn65dsi86 > > + > > + reg: > > + const: 0x2d > > + > > + enable-gpios: > > + maxItems: 1 > > + description: GPIO specifier for bridge_en pin (active high). > > + > > + suspend-gpios: > > + maxItems: 1 > > + description: GPIO specifier for GPIO1 pin on bridge (active low). > > + > > + vccio-supply: > > + description: A 1.8V supply that powers the digital IOs. > > + > > + vpll-supply: > > + description: A 1.8V supply that powers the DisplayPort PLL. > > + > > + vcca-supply: > > + description: A 1.2V supply that powers the analog circuits. > > + > > + vcc-supply: > > + description: A 1.2V supply that powers the digital core. > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + description: > > + Clock specifier for input reference clock. The reference clock rate must > > + be 12 MHz, 19.2 MHz, 26 MHz, 27 MHz or 38.4 MHz. > > + > > + clock-names: > > + const: refclk > > + > > + gpio-controller: true > > + '#gpio-cells': > > + const: 2 > > + description: > > + First cell is pin number, second cell is flags. GPIO pin numbers are > > + 1-based to match the datasheet. See ../../gpio/gpio.txt for more > > + information. > > + > > + '#pwm-cells': > > + const: 1 > > + description: See ../../pwm/pwm.yaml for description of the cell formats. > > + > > + ports: > > + type: object > > Maybe > > additionalProperties: false > > here ? Ah, this is to keep people from adding "additionalProperties" under the ports node. I will hold off on sending v5 for now. If there happens to be nothing else wrong I'm happy for this to be added by a maintainer when landing or I can quickly spin a v5. > > + > > + properties: > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + port@0: > > + type: object > > + additionalProperties: false > > + > > + description: > > + Video port for MIPI DSI input > > + > > + properties: > > + reg: > > + const: 0 > > + > > + endpoint: > > + type: object > > + additionalProperties: false > > + > > + properties: > > + remote-endpoint: true > > + > > + data-lanes: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + enum: > > + - 0 > > + - 1 > > + - 2 > > + - 3 > > + description: See ../../media/video-interface.txt > > And maybe > uniqueItems: true > > ? Same for port@1. Sounds good. Again, I'll hold off on sending v5 for now and (if no other problems) happy if this gets done when applied. > Reviewed-by: Laurent Pinchart Thanks! -Doug _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel