From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE63C4363A for ; Thu, 29 Oct 2020 16:11:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFE5120790 for ; Thu, 29 Oct 2020 16:11:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="c4n8wyrP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFE5120790 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02D356E8C9; Thu, 29 Oct 2020 16:11:24 +0000 (UTC) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71F076E8D9 for ; Thu, 29 Oct 2020 16:11:23 +0000 (UTC) Received: by mail-vs1-xe44.google.com with SMTP id b3so1817157vsc.5 for ; Thu, 29 Oct 2020 09:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I0lmuE6RR3dhx0tK+loCxehAgyFNZWus4zKcvrq/a24=; b=c4n8wyrP3vlNQPilsWu9vKqsJGfZS8wahksMfrJ7rGMn9SebslvVzpHL1QvVP8Kkk0 r15i5okYMIBlkgnrGCzn5fGybIoXW/2YDlB/3KynBPOYl7OxIWX67hWjnL+Rwr0Ngo2D 3iMpMaHecSvq/RZDhhk4HqXoxDDD/X+SWxDnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I0lmuE6RR3dhx0tK+loCxehAgyFNZWus4zKcvrq/a24=; b=HJF0UL4lW8fvzNR0N/BhBs5SOCfdJD2wg/p0ZerWBHzSM1d45S0JqenbLyJrMmkj/n K+KN1UU/WJemNT2ZxicyQbPIEomi61IR0FniRfqIYdRe/+7vAe8qlywU5KOlJpK9qEDJ dXsOs7RDIIWvhZ8inBQYNrVS7YeR2lLPFsYFADTyAaqPugAdV1rljt8qHllZ+X3mlW5b iHzD/11o+WDWccWE3BSswYeNqgZ/UKdEIaQ+nYo9YYzhwZ+Q0Jww9sP49rY4FxlKe6UY n7UV0rbmp6A0nQaVoji/bwoBDsYtRcOkEBzDlf1T8P1BhU0ETh6QhqxFg+a0UfnRBw7r G9zw== X-Gm-Message-State: AOAM532+iuVVX/qPtIUn2zNaiOH/WgginHX3y2EhuvkqX1jmevt6i8zs PgpodA6cnCAI2SHGsoDwddHFmnH2WYmRnw== X-Google-Smtp-Source: ABdhPJylshi1O4uCRk8+CBgZmqoJxihDnHcxM67BiQsEhq08ymBSo5m56OLdo0BmpcWPpor3qt05tw== X-Received: by 2002:a67:1e01:: with SMTP id e1mr3873037vse.49.1603987882217; Thu, 29 Oct 2020 09:11:22 -0700 (PDT) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com. [209.85.221.179]) by smtp.gmail.com with ESMTPSA id h7sm369623vke.55.2020.10.29.09.11.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 09:11:21 -0700 (PDT) Received: by mail-vk1-f179.google.com with SMTP id u202so823115vkb.4 for ; Thu, 29 Oct 2020 09:11:21 -0700 (PDT) X-Received: by 2002:a1f:8d91:: with SMTP id p139mr3942003vkd.9.1603987880886; Thu, 29 Oct 2020 09:11:20 -0700 (PDT) MIME-Version: 1.0 References: <20201029011154.1515687-1-swboyd@chromium.org> <20201029011154.1515687-3-swboyd@chromium.org> In-Reply-To: <20201029011154.1515687-3-swboyd@chromium.org> From: Doug Anderson Date: Thu, 29 Oct 2020 09:11:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] drm/bridge: ti-sn65dsi86: Make polling a busy loop To: Stephen Boyd X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , Neil Armstrong , LKML , dri-devel , Andrzej Hajda , Sean Paul , Laurent Pinchart , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > There's no reason we need to wait here to poll a register over i2c. The > i2c bus is inherently slow and delays are practically part of the > protocol because we have to wait for the device to respond to any > request for a register. Let's rely on the sleeping of the i2c controller > instead of adding any sort of delay here in the bridge driver. > > Cc: Douglas Anderson > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Sean Paul > Signed-off-by: Stephen Boyd > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Since we already did some early reviews off-list, it's not a surprise that I have no comments. ;-) Reviewed-by: Douglas Anderson _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel