From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00337C433B4 for ; Thu, 1 Apr 2021 15:35:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB04461370 for ; Thu, 1 Apr 2021 15:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB04461370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5516E03A; Thu, 1 Apr 2021 15:35:04 +0000 (UTC) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by gabe.freedesktop.org (Postfix) with ESMTPS id 617246E03A for ; Thu, 1 Apr 2021 15:35:03 +0000 (UTC) Received: by mail-qt1-x830.google.com with SMTP id 1so1790045qtb.0 for ; Thu, 01 Apr 2021 08:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SPcX6QtS7Ve6UUCNbDaDbB4vAvudpBUFG69ugXPs6T8=; b=AHguOOTFAO2NQe8XmSdmlyagtr/wB7GhsgTQRCF/4VWbWuMjMbDGipaw0RxlA0M6yR men4W9o7Z3lOPEhONt01til0PnMg/us3/Y7ioK47S+E3qh5tEsfAwsau3lssAXnET16Z y4UgVblAdat0wp63BW2m5H52N9VLE+J5QNlQ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SPcX6QtS7Ve6UUCNbDaDbB4vAvudpBUFG69ugXPs6T8=; b=BHueAbidQHh7cyC4ydypKi8+poXRVpskPdT1yM6QfyLppkCoyc9a2PzuEDiimnXnfv 8djhxaiqZMsD8dcGYQ9jRrb+JfCz0cBWL1xSdE/nsn4/cPyMDTHQa6H1a7ek3NbZAW8m +knUjtgCxgs2ZLuLGPBR9S3gxWDG813qZS3oBIjz69HQPhI6OzdHVgOj6gX5vFjIoVC+ 91sw3pApYd2j4//pVc7Cr+vci3f/ao4a/YyNzD+wvJqEDWDF/UlU9iALrDK7JOkYYZC4 XY9Xj6ZPNSCXA9TKcy63pLaWERBiNdtdfR6iklnvrkN4SyfDA4Mi1Rj0WEz3XpFrypPL wedw== X-Gm-Message-State: AOAM533NJekjjS8R6QdQQ3ZRF14Bd6pidgqJVWS/BQ0KrWb5mQGQtPdW bZokgErMb+H4+YSjlS8AdQvzbgH5cdRziA== X-Google-Smtp-Source: ABdhPJwcBv6lVhvV/EqbTXf2eBDIGoevYyWPU5Hd1T6LGAUZBxhCffNchzNt1uqfhJ3vnTq7yrXEUg== X-Received: by 2002:ac8:6c3b:: with SMTP id k27mr7595128qtu.354.1617291302358; Thu, 01 Apr 2021 08:35:02 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id x14sm1178779qkn.98.2021.04.01.08.35.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 08:35:01 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id m132so2226569ybf.2 for ; Thu, 01 Apr 2021 08:35:01 -0700 (PDT) X-Received: by 2002:a25:74ca:: with SMTP id p193mr12383521ybc.405.1617291301361; Thu, 01 Apr 2021 08:35:01 -0700 (PDT) MIME-Version: 1.0 References: <20210331221630.488498-1-robdclark@gmail.com> <20210401012722.527712-1-robdclark@gmail.com> <20210401012722.527712-4-robdclark@gmail.com> In-Reply-To: <20210401012722.527712-4-robdclark@gmail.com> From: Doug Anderson Date: Thu, 1 Apr 2021 08:34:50 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/4] drm/msm: Fix debugfs deadlock To: Rob Clark X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , dri-devel , Jordan Crouse , "Kristian H. Kristensen" , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Wed, Mar 31, 2021 at 6:24 PM Rob Clark wrote: > > From: Rob Clark > > In normal cases the gem obj lock is acquired first before mm_lock. The > exception is iterating the various object lists. In the shrinker path, > deadlock is avoided by using msm_gem_trylock() and skipping over objects > that cannot be locked. But for debugfs the straightforward thing is to > split things out into a separate list of all objects protected by it's > own lock. > > Fixes: d984457b31c4 ("drm/msm: Add priv->mm_lock to protect active/inactive lists") > Signed-off-by: Rob Clark > Tested-by: Douglas Anderson Reviewed-by: Douglas Anderson _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel