From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50EBEC3404B for ; Tue, 18 Feb 2020 21:58:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 177E5207FD for ; Tue, 18 Feb 2020 21:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anholt-net.20150623.gappssmtp.com header.i=@anholt-net.20150623.gappssmtp.com header.b="kdpjP80s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 177E5207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 849DF6E41A; Tue, 18 Feb 2020 21:58:54 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE5F76EA92 for ; Tue, 18 Feb 2020 21:58:52 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id c23so15693898lfi.7 for ; Tue, 18 Feb 2020 13:58:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ahpk/GappiCcM5wW00z5eRTm7XSNbwAT9p1AedeyQaE=; b=kdpjP80seFPRBqxhxIpalWncJhJycuWAQPQT0uf/BhAioMxpA/HQSrB4FFdQP+vo/L KzZMVoRXpw4PUTQavb0o6cZHHaGKHSVcOUgix+7f/NfUfAl9aCz7L0/IbtVECP3Hmx5k uQFJiRqinUNrrBdMEj/yIhEp3RBT2Uxd72BlqR4nMUwzHAyMKM7YPchqExAMmNWGqoBi Ph19zMTGlFHeCAUda62180ibnNyy2wl7eOxbVuLhU6Jsy9cLpevU3SYjCp9Zrk7UP43A VMce/XyzyXhUBuaWX2tdTaeUxZdF5O1Zs8APWnkdHzTNx1e2XTvdK45WjNKQLPXeMS0F 1T4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ahpk/GappiCcM5wW00z5eRTm7XSNbwAT9p1AedeyQaE=; b=sqPOIPo4GS515kOlz4FbhKBHzE7+0zg6tPyRhUcQo3pEKKiOY8cxDJwMYOzE3QjNKf eyVw35zE9So+zfjPMx1C4fJSxP0YfC2GLSUt5fnH/bVsvZXkrQsHuCFcFWeMf7S2vjDx xu9GH/IavFUvcVEdt4z3JKtm6OzSJdxFVr5iyip640qFPE834s+bRbuOAO9iG03TOQII aw4dVw80ol5xXSWovV/S5tW75DszivYzNi7omwSrvq4Z1A+vp9Mi9JtjuYOqPinIt6vT ghB9uk/oiMr0MEMp4G65E4kqLJ/hV7l6i4TChcMqJPiRmA0dntrEpEVqmN96pHkXH/vo MB+g== X-Gm-Message-State: APjAAAVVeYYRTuYh34rTPMTRujpmTzMEn4fYcjWzcbyVPO0KaTl9TZj2 oWfnpJ+k+oWNvKWxcbItzRDv+W4lWpTOpPDTwcwtag== X-Google-Smtp-Source: APXvYqwfJ/KjDHUqMyRYTcya4wxUGjDyhjQGBQJimj1/3xX/vD0XeMTB9CXlS07iJHjcgr5dOlc5NuiOgM8QWSquNew= X-Received: by 2002:ac2:4214:: with SMTP id y20mr11460778lfh.212.1582063131075; Tue, 18 Feb 2020 13:58:51 -0800 (PST) MIME-Version: 1.0 References: <1581705404-5124-1-git-send-email-jcrouse@codeaurora.org> In-Reply-To: <1581705404-5124-1-git-send-email-jcrouse@codeaurora.org> From: Eric Anholt Date: Tue, 18 Feb 2020 13:58:39 -0800 Message-ID: Subject: Re: [PATCH] drm/msm/a5xx: Always set an OPP supported hardware value To: Jordan Crouse X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Jeffrey Hugo , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, DRI Development , Ben Dooks , Thomas Gleixner , AngeloGioacchino Del Regno , Sean Paul , Wen Yang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 14, 2020 at 10:36 AM Jordan Crouse wrote: > > If the opp table specifies opp-supported-hw as a property but the driver > has not set a supported hardware value the OPP subsystem will reject > all the table entries. > > Set a "default" value that will match the default table entries but not > conflict with any possible real bin values. Also fix a small memory leak > and free the buffer allocated by nvmem_cell_read(). > > Signed-off-by: Jordan Crouse This does fix my warn at boot on db820c. Reviewed-by: Eric Anholt _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel