From: ChiYuan Huang <u0084500@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
b.zolnierkie@samsung.com, jingoohan1@gmail.com,
lgirdwood@gmail.com, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, cy_huang <cy_huang@richtek.com>,
Mark Brown <broonie@kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight
Date: Tue, 4 May 2021 09:10:37 +0800 [thread overview]
Message-ID: <CADiBU3_SkXL1F5O6G+n=qjokmqLhbUuJNeRPGfWUqVRbcB=acA@mail.gmail.com> (raw)
In-Reply-To: <20210430201026.GA3797206@robh.at.kernel.org>
Hi,
Rob Herring <robh@kernel.org> 於 2021年5月1日 週六 上午4:10寫道:
>
> On Mon, Apr 26, 2021 at 03:18:09PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Adds DT binding document for Richtek RT4831 backlight.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > ---
> > Resend this v6 patch series to loop devicetree reviewers.
> >
> > For next, need to add the below line
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > ---
> > .../leds/backlight/richtek,rt4831-backlight.yaml | 65 ++++++++++++++++++++++
> > include/dt-bindings/leds/rt4831-backlight.h | 23 ++++++++
> > 2 files changed, 88 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > create mode 100644 include/dt-bindings/leds/rt4831-backlight.h
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > new file mode 100644
> > index 00000000..4da6a66
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/richtek,rt4831-backlight.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Richtek RT4831 Backlight
> > +
> > +maintainers:
> > + - ChiYuan Huang <cy_huang@richtek.com>
> > +
> > +description: |
> > + RT4831 is a mutifunctional device that can provide power to the LCD display
> > + and LCD backlight.
> > +
> > + For the LCD backlight, it can provide four channel WLED driving capability.
> > + Each channel driving current is up to 30mA
> > +
> > + Datasheet is available at
> > + https://www.richtek.com/assets/product_file/RT4831A/DS4831A-05.pdf
> > +
>
> Need to reference common backlight schema:
>
> allOf:
> - $ref: common.yaml#
>
> > +properties:
> > + compatible:
> > + const: richtek,rt4831-backlight
> > +
> > + default-brightness:
> > + description: |
> > + The default brightness that applied to the system on start-up.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> Drop description and $ref. Covered in common.yaml.
>
OK
> > + minimum: 0
> > + maximum: 2048
> > +
> > + max-brightness:
> > + description: |
> > + The max brightness for the H/W limit
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> And here.
>
OK
The above changes will be merged in next, thanks.
After mfd code patch reviewed, I'll send v7 for all of review comments.
> > + minimum: 0
> > + maximum: 2048
> > +
> > + richtek,pwm-enable:
> > + description: |
> > + Specify the backlight dimming following by PWM duty or by SW control.
> > + type: boolean
> > +
> > + richtek,bled-ovp-sel:
> > + description: |
> > + Backlight OVP level selection, currently support 17V/21V/25V/29V.
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + default: 1
> > + minimum: 0
> > + maximum: 3
> > +
> > + richtek,channel-use:
> > + description: |
> > + Backlight LED channel to be used.
> > + BIT 0/1/2/3 is used to indicate led channel 1/2/3/4 enable or disable.
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + minimum: 1
> > + maximum: 15
> > +
> > +required:
> > + - compatible
> > + - richtek,channel-use
> > +
> > +additionalProperties: false
> > diff --git a/include/dt-bindings/leds/rt4831-backlight.h b/include/dt-bindings/leds/rt4831-backlight.h
> > new file mode 100644
> > index 00000000..125c635
> > --- /dev/null
> > +++ b/include/dt-bindings/leds/rt4831-backlight.h
> > @@ -0,0 +1,23 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +/*
> > + * This header provides constants for rt4831 backlight bindings.
> > + *
> > + * Copyright (C) 2020, Richtek Technology Corp.
> > + * Author: ChiYuan Huang <cy_huang@richtek.com>
> > + */
> > +
> > +#ifndef _DT_BINDINGS_RT4831_BACKLIGHT_H
> > +#define _DT_BINDINGS_RT4831_BACKLIGHT_H
> > +
> > +#define RT4831_BLOVPLVL_17V 0
> > +#define RT4831_BLOVPLVL_21V 1
> > +#define RT4831_BLOVPLVL_25V 2
> > +#define RT4831_BLOVPLVL_29V 3
> > +
> > +#define RT4831_BLED_CH1EN (1 << 0)
> > +#define RT4831_BLED_CH2EN (1 << 1)
> > +#define RT4831_BLED_CH3EN (1 << 2)
> > +#define RT4831_BLED_CH4EN (1 << 3)
> > +#define RT4831_BLED_ALLCHEN ((1 << 4) - 1)
> > +
> > +#endif /* _DT_BINDINGS_RT4831_BACKLIGHT_H */
> > --
> > 2.7.4
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-05-04 1:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 7:18 [RESEND PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831 cy_huang
2021-04-26 7:18 ` [RESEND PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight cy_huang
2021-04-30 20:10 ` Rob Herring
2021-05-04 1:10 ` ChiYuan Huang [this message]
2021-04-26 7:18 ` [RESEND PATCH v6 3/4] mfd: rt4831: Adds DT binding document for Richtek RT4831 cy_huang
2021-04-30 20:10 ` Rob Herring
2021-05-04 1:04 ` ChiYuan Huang
2021-04-26 7:18 ` [RESEND PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight cy_huang
2021-04-26 10:19 ` Daniel Thompson
2021-04-26 10:50 ` ChiYuan Huang
2021-04-26 12:24 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADiBU3_SkXL1F5O6G+n=qjokmqLhbUuJNeRPGfWUqVRbcB=acA@mail.gmail.com' \
--to=u0084500@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).