From: Alex Deucher <alexdeucher@gmail.com>
To: "André Almeida" <andrealmeid@igalia.com>
Cc: "Tom St Denis" <tom.stdenis@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>, "Tao Zhou" <tao.zhou1@amd.com>,
kernel-dev@igalia.com, "David Airlie" <airlied@linux.ie>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Pan Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh
Date: Wed, 10 Aug 2022 11:57:26 -0400 [thread overview]
Message-ID: <CADnq5_MJAbhQ8VZcPVY5nhg3VnefKPnSscMnRPsm2wB04G6wBg@mail.gmail.com> (raw)
In-Reply-To: <20220726182152.123649-1-andrealmeid@igalia.com>
On Tue, Jul 26, 2022 at 2:23 PM André Almeida <andrealmeid@igalia.com> wrote:
>
> This series adds new logging features for GFXOFF available for vangogh
> and documentation for it.
>
> I've created a small userspace program to interact with this new debugfs
> interface and it can be found at:
>
> https://gitlab.freedesktop.org/andrealmeid/gfxoff_tool
>
> Changelog:
> v2:
> - Make entrycount uint64_t
> - Add a note in docs about data types and overflow
A minor comment on patch 2, the rest looks good to me.
Thanks,
Alex
>
> André Almeida (4):
> drm/amd: Add detailed GFXOFF stats to debugfs
> drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh
> Documentation/gpu: Document GFXOFF's count and residency
> drm/amdgpu: Document gfx_off members of struct amdgpu_gfx
>
> Documentation/gpu/amdgpu/thermal.rst | 18 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 168 ++++++++++++++++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 39 ++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 14 +-
> drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 45 +++++
> drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 3 +
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 35 +++-
> drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 22 +++
> .../pm/swsmu/inc/pmfw_if/smu_v11_5_ppsmc.h | 5 +-
> drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 5 +-
> .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 92 ++++++++++
> drivers/gpu/drm/amd/pm/swsmu/smu_internal.h | 3 +
> 13 files changed, 443 insertions(+), 8 deletions(-)
>
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-10 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 18:21 [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh André Almeida
2022-07-26 18:21 ` [PATCH v2 1/4] drm/amd: Add detailed GFXOFF stats to debugfs André Almeida
2022-07-26 18:21 ` [PATCH v2 2/4] drm/amd/pm: Implement GFXOFF's entry count and residency for vangogh André Almeida
2022-08-10 15:54 ` Alex Deucher
2022-07-26 18:21 ` [PATCH v2 3/4] Documentation/gpu: Document GFXOFF's count and residency André Almeida
2022-07-26 18:21 ` [PATCH v2 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx André Almeida
2022-08-10 15:57 ` Alex Deucher [this message]
2022-08-10 16:01 ` [PATCH v2 0/4] drm/amd: Add more GFXOFF stats for vangogh André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_MJAbhQ8VZcPVY5nhg3VnefKPnSscMnRPsm2wB04G6wBg@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Felix.Kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.zhou1@amd.com \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).