From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0992C433E1 for ; Tue, 23 Jun 2020 16:51:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B77A92076E for ; Tue, 23 Jun 2020 16:51:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mqlbr0Ht" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B77A92076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CAF5A89E65; Tue, 23 Jun 2020 16:51:16 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF30689E65; Tue, 23 Jun 2020 16:51:15 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id g21so4013376wmg.0; Tue, 23 Jun 2020 09:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bg1C/maXc1yHDgyZ8N7KDhwmSTHqJRAHyYrqsJclewo=; b=mqlbr0HtalRaLV/mTAHk1BaZYRLajtzzuqOA2+xIlE7AFpAXzv6NUeqUeqKEUQlwLX l5zgIuas0ANzK8c/p/RVzTC8TwzZoJjhGuECNWqjYzxw2eUIHeaX19dSA6JsOFE7pzCd bZgOU/3pXAshIfBoutWFqGiniMWEyegzk+QZUs0G3s22hBkrCE0JIGhU8lmWLZh3mpMb TCJzyR+rCR7xtKssZCUDO1iE8cvoTbSTu12OfaEeVSGaQe5LilnfEZ9X2bAACBMwShMa K+KszQp30zSwChCOwZUwT1wzgpqRgLnHnd5PeO+xeLbJxAhePjlwb9yXjzsXOhL8SlPS g7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bg1C/maXc1yHDgyZ8N7KDhwmSTHqJRAHyYrqsJclewo=; b=DSJTGwDDAGD3Nen6VFoIBQC5ezo6PHWQC7CBLB091KdgiT0l09EK6SGisVnofJ7+4n YbZyVFE6RHDgNCtErX7wxPQRSnv3D7eBXZqemh5iKnDzpGRxpvNbGTVdZWXnAq1lOqmj EcXBlXh0oDB/JvdLKGnjPkGfDJJ9OS0ercS/pzK/cZEcvghhKoJlpCs7CfPY7pVuxIma BoqG5Wu/hY2KfZUdsik2d78V6e/PGSleg3wJ7Ok6Et4JUixjyrxyAHfOgCOu0Ix2M06z PYwiTDOphP3CBPYoVXYlf7/jugHv5dpi3u1lKYC3xCwgeX8Uuu5EzDr5paZ3Jw1P3k/+ 7H5g== X-Gm-Message-State: AOAM532CHThja1OHmV6/K/ALbuqaaTNwrhKEuy/eFUbN5fKgs0DBColt bCS5Vv4kwf7zkl57O0YhoUF6mkb/oeuPijwqo2M= X-Google-Smtp-Source: ABdhPJzXWe6A3dDxn3bWQEVxIsTa+qlEbGIxqOQmoCTQoQfdJpqdMBYbeYGxrWp7QJDkL5X7Bvoa+gqY9oAeDztKizQ= X-Received: by 2002:a1c:3954:: with SMTP id g81mr11521140wma.73.1592931074567; Tue, 23 Jun 2020 09:51:14 -0700 (PDT) MIME-Version: 1.0 References: <20200622203122.25749-1-efremov@linux.com> In-Reply-To: <20200622203122.25749-1-efremov@linux.com> From: Alex Deucher Date: Tue, 23 Jun 2020 12:51:03 -0400 Message-ID: Subject: Re: [PATCH] drm/radeon: fix fb_div check in ni_init_smc_spll_table() To: Denis Efremov X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , "for 3.8" , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jun 22, 2020 at 5:56 PM Denis Efremov wrote: > > clk_s is checked twice in a row in ni_init_smc_spll_table(). > fb_div should be checked instead. > > Fixes: 69e0b57a91ad ("drm/radeon/kms: add dpm support for cayman (v5)") > Cc: stable@vger.kernel.org > Signed-off-by: Denis Efremov Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ni_dpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/ni_dpm.c b/drivers/gpu/drm/radeon/ni_dpm.c > index b57c37ddd164..c7fbb7932f37 100644 > --- a/drivers/gpu/drm/radeon/ni_dpm.c > +++ b/drivers/gpu/drm/radeon/ni_dpm.c > @@ -2127,7 +2127,7 @@ static int ni_init_smc_spll_table(struct radeon_device *rdev) > if (clk_s & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_MASK >> SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_SHIFT)) > ret = -EINVAL; > > - if (clk_s & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_MASK >> SMC_NISLANDS_SPLL_DIV_TABLE_CLKS_SHIFT)) > + if (fb_div & ~(SMC_NISLANDS_SPLL_DIV_TABLE_FBDIV_MASK >> SMC_NISLANDS_SPLL_DIV_TABLE_FBDIV_SHIFT)) > ret = -EINVAL; > > if (clk_v & ~(SMC_NISLANDS_SPLL_DIV_TABLE_CLKV_MASK >> SMC_NISLANDS_SPLL_DIV_TABLE_CLKV_SHIFT)) > -- > 2.26.2 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel